All of lore.kernel.org
 help / color / mirror / Atom feed
From: Andy Shevchenko <andy.shevchenko@gmail.com>
To: u-boot@lists.denx.de
Subject: use invd instead of wbinvd in real mode start code
Date: Mon, 17 Feb 2020 15:47:18 +0200	[thread overview]
Message-ID: <CAHp75VdUY7zJfkc4YV-KTt1aEKg9Ggy6PsJAEOkgo9eCtQx9Kg@mail.gmail.com> (raw)
In-Reply-To: <CAHp75Veri=85osuFy0xDukEKN9zAULJpk+1sTdHynTL_deK=0Q@mail.gmail.com>

(Cc'ing mailing list and Tom again, thus keep entire previous answer)

On Mon, Feb 17, 2020 at 3:39 PM Andy Shevchenko
<andy.shevchenko@gmail.com> wrote:
> On Mon, Feb 17, 2020 at 2:41 PM Masahiro Yamada <masahiroy@kernel.org> wrote:
> > On Mon, Feb 17, 2020 at 9:31 PM Andy Shevchenko
> > <andy.shevchenko@gmail.com> wrote:
>
> > > It seems Masahiro's patches (don't know yet which one out of two,
> > > probably invd one) broke the boot on Intel Edison.
> > >
> > > Reverting (both for now) helps.
> >
> > Why both?
>
> Because I did bisecting by intuition (much faster than usual one).
>
> > git bisect is the usual way to figure out the culprit.
>
> Too much work to do this way.
>
> And since I was about to have my lunch, I didn't continue
> investigating. Let me do it now.

OK, as my intuition told me the problematic one is

commit 0d67fac29f3187e67f4fd3ef15f73e91be2fad12
Author: Masahiro Yamada <masahiroy@kernel.org>
Date:   Wed Jan 8 20:08:44 2020 +0900

   x86: use invd instead of wbinvd in real mode start code


Please, revert or fix ASAP before v2020.04 release!
^^^

> > > P.S. I dunno how it has been tested, so, if you have Intel Edison in
> > > possession, please, don't forget to test on it. It's not first time
> > > the Intel Edison behaviour is broken due to poor testing.
> >
> >
> > I tested my patches on qemu.
>
> Exactly my point of definition "poor".
> It's not first time (and not last) when QEmu sucks.
>
> > Sorry for the breakage on your board, but I do not
> > have Edison board.
> > It is not possible to test every board.
>
> No problem, it's rather to x86 maintainers to have at least one-two
> real hardware testing before applying this.
> QEMU is completely not enough!

-- 
With Best Regards,
Andy Shevchenko

  parent reply	other threads:[~2020-02-17 13:47 UTC|newest]

Thread overview: 23+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <CAHp75VdtevMO=AWeZZ-kfmo0Dx5RrGBZEW8Mm5ubLU2pm3Nh=g@mail.gmail.com>
2020-02-17 12:31 ` Fwd: use invd instead of wbinvd in real mode start code Andy Shevchenko
2020-02-17 12:33   ` Andy Shevchenko
     [not found] ` <CAK7LNASQuuEWCypyK+TDYa1eYk__KKRZ1Z8JgsEbhd+4KNFNjw@mail.gmail.com>
     [not found]   ` <CAHp75Veri=85osuFy0xDukEKN9zAULJpk+1sTdHynTL_deK=0Q@mail.gmail.com>
2020-02-17 13:47     ` Andy Shevchenko [this message]
2020-02-17 13:52       ` Bin Meng
2020-02-17 14:00         ` Andy Shevchenko
2020-02-17 14:49           ` Bin Meng
2020-02-17 15:31             ` Andy Shevchenko
2020-02-17 15:09       ` Wolfgang Denk
2020-02-17 15:13         ` Tom Rini
2020-02-17 15:32         ` Andy Shevchenko
2020-02-17 15:33           ` Andy Shevchenko
2020-02-17 16:02             ` Tom Rini
2020-02-17 16:04           ` Wolfgang Denk
2020-02-18  5:48             ` Heiko Schocher
2020-02-18 10:45               ` Andy Shevchenko
2020-02-18 11:06                 ` Heiko Schocher
2020-02-18 11:29                   ` Andy Shevchenko
2020-02-18 14:43                     ` Tom Rini
2020-02-18 15:37                       ` Andy Shevchenko
2020-02-19 13:14                   ` Wolfgang Denk
2020-02-19 13:42                     ` Tom Rini
2020-02-19 14:04                       ` Heiko Schocher
2020-02-17 16:05           ` Tom Rini

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAHp75VdUY7zJfkc4YV-KTt1aEKg9Ggy6PsJAEOkgo9eCtQx9Kg@mail.gmail.com \
    --to=andy.shevchenko@gmail.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.