From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.7 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6C8FFC433E9 for ; Thu, 18 Feb 2021 16:48:12 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 1A7FA64EB1 for ; Thu, 18 Feb 2021 16:48:12 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233483AbhBRQrk (ORCPT ); Thu, 18 Feb 2021 11:47:40 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:53472 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230073AbhBRPFE (ORCPT ); Thu, 18 Feb 2021 10:05:04 -0500 Received: from mail-pf1-x42a.google.com (mail-pf1-x42a.google.com [IPv6:2607:f8b0:4864:20::42a]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 9B56EC061574; Thu, 18 Feb 2021 07:04:18 -0800 (PST) Received: by mail-pf1-x42a.google.com with SMTP id z15so1475332pfc.3; Thu, 18 Feb 2021 07:04:18 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=SCWX+UOWBBJn4LzW9Yj7QYHcJVlwVskIMygyEWiC3wA=; b=ptTekISckA2jYFmD+CelhT4CRuY+9zmgwQo3vUOOSVTtYU+u8puIb5X6zY9O9vS4Qt 1MVrE0TXQvA7aPaTJMlSGwlJCmmU2FjesAbdk6HWoy+6ECmBtkwBHrWfLk340T+lqtUr tdlpQjK67nm7aAClC/zNZtIW5TdxJTr0Nn3H3Zi5ilLW6kUonpRBd8U3ufddQMCY+XKw 1u0NzVmgKd2Dtg8j62nf7CIB933MdcHVI+wy0MJaTfX66TYJr4epBwbhuxQ7WDefLkeb IzLkM4Wm9B9CfW/6kCUDReQYeXq3pXwpzi5DKlcM7ZnXDryILmtYSrRE05ziGFtkycuO fPQw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=SCWX+UOWBBJn4LzW9Yj7QYHcJVlwVskIMygyEWiC3wA=; b=AsFwABVPeEPUgOK9qEcxcvjpuI4U+Bpb6fMOpx8u8WAg6k2Rr4FAQSXGy3oT3ExNV4 1fX72lbpDw9lzkkrpE6muw+/ya8Ek/P3qcROA9rf31JAioBg9VpHvYLRuGABiBa3q6tD iWi2EfRrFpAfSC+OTf0Q1bYaimyt9HjD9QyQWZaWvLvxGxm2BX0IPByNga0maHtow8pG Z7Plf5qhdO3vJS789f+JbaoOLFwRZp4PSYjWNyqIAwsAiNAwx/1MdM9vGoCMqRirFDjN uP3t7U3kKnLtRrYaPb0yDDI+7TXWfKmYqgY7LoHzwTB9wGaFut9SYUM6E0DyW0d63qAr 4G1g== X-Gm-Message-State: AOAM533f9iAsL51R3dDHoMfbGtX18vTj6LlteRERNl3QeAZGJ9ldCNTr LuBz9OoP3iwslWqfNkM7hrQO8TAIGe34A1XGReM= X-Google-Smtp-Source: ABdhPJwG5zE0x+hjJvBnpEznOmm5sOnqdV/YjJZRzgbBogf8unojEji7hX1GRoH0IU+rEawkdJbKxqx0xsaizjPJhNE= X-Received: by 2002:a65:4c08:: with SMTP id u8mr4275873pgq.203.1613660658089; Thu, 18 Feb 2021 07:04:18 -0800 (PST) MIME-Version: 1.0 References: <20210218052654.28995-1-calvin.johnson@oss.nxp.com> <20210218052654.28995-16-calvin.johnson@oss.nxp.com> In-Reply-To: <20210218052654.28995-16-calvin.johnson@oss.nxp.com> From: Andy Shevchenko Date: Thu, 18 Feb 2021 17:04:02 +0200 Message-ID: Subject: Re: [net-next PATCH v6 15/15] net: dpaa2-mac: Add ACPI support for DPAA2 MAC driver To: Calvin Johnson Cc: Grant Likely , "Rafael J . Wysocki" , Jeremy Linton , Andrew Lunn , Florian Fainelli , Russell King - ARM Linux admin , Cristi Sovaiala , Florin Laurentiu Chiculita , Ioana Ciornei , Madalin Bucur , Heikki Krogerus , Marcin Wojtas , Pieter Jansen Van Vuuren , Jon , Saravana Kannan , Randy Dunlap , Linux Kernel Mailing List , netdev , ACPI Devel Maling List , Laurentiu Tudor , Diana Madalina Craciun , linux-arm Mailing List , "linux.cj" , "David S. Miller" , Ioana Radulescu , Jakub Kicinski Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-acpi@vger.kernel.org On Thu, Feb 18, 2021 at 7:29 AM Calvin Johnson wrote: > > Modify dpaa2_mac_get_node() to get the dpmac fwnode from either > DT or ACPI. > > Modify dpaa2_mac_get_if_mode() to get interface mode from dpmac_node > which is a fwnode. > > Modify dpaa2_pcs_create() to create pcs from dpmac_node fwnode. > > Modify dpaa2_mac_connect() to support ACPI along with DT. ... > + if (is_of_node(fwnode)) Redundant check I think. If it's not an fwnode, the dpmacs is NULL and of_node_put() is NULL-aware. > + of_node_put(dpmacs); ... > + if (is_of_node(fwnode)) > + of_node_put(dpmacs); Ditto. ... > mac->if_link_type = mac->attr.link_type; > - Do we need to remove this blank line? ... > + if (is_of_node(dpmac_node)) > + fwnode_handle_put(dpmac_node); > + if (is_of_node(dpmac_node)) > + fwnode_handle_put(dpmac_node); Also not sure that you need a check in the above code excerpts. -- With Best Regards, Andy Shevchenko From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.7 required=3.0 tests=BAYES_00,DKIM_ADSP_CUSTOM_MED, DKIM_SIGNED,DKIM_VALID,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 71797C433E0 for ; Thu, 18 Feb 2021 15:06:36 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 022B664E6F for ; Thu, 18 Feb 2021 15:06:35 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 022B664E6F Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:To:Subject:Message-ID:Date:From:In-Reply-To: References:MIME-Version:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=lgwMAam0nXACxeXNKPzdGCHCeazPyd3XxYXyNeW7kJM=; b=K7wABOnOgVAdZ5qZw296kSnm7 ESed/g/W6D+JKBJORYTFj3nk1i0dEWsij7iw+rEbFyAbb4ZiYyDYs2t++cZfgs9YNYdYqagTX9Qnj dRE2eY2MSVZGgfv3tXkjnJFkLJwSg/kjnTfxZ+SZ1Qtuj8ZGDZRuHoDVrw839SRE4CEZoQZk6Q4t7 mlTp98x6qC5RwViA24SINWYw4uOXnyByvyv/XcNy7kJDAtIw4yeFY4wBYtrxFnu+DvOgB8kDZ1Gbj zVZbFaiYOup+S5VFn9n7EUJDAA0289grS4b/MfRbEsBQ9htO0pPQOhPAApGiWxjDPk1PQKqblNKKe lWz8n4zbw==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1lCkqt-0002Gi-1T; Thu, 18 Feb 2021 15:04:23 +0000 Received: from mail-pf1-x42c.google.com ([2607:f8b0:4864:20::42c]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1lCkqq-0002Fq-8u for linux-arm-kernel@lists.infradead.org; Thu, 18 Feb 2021 15:04:21 +0000 Received: by mail-pf1-x42c.google.com with SMTP id t29so1451748pfg.11 for ; Thu, 18 Feb 2021 07:04:19 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=SCWX+UOWBBJn4LzW9Yj7QYHcJVlwVskIMygyEWiC3wA=; b=ptTekISckA2jYFmD+CelhT4CRuY+9zmgwQo3vUOOSVTtYU+u8puIb5X6zY9O9vS4Qt 1MVrE0TXQvA7aPaTJMlSGwlJCmmU2FjesAbdk6HWoy+6ECmBtkwBHrWfLk340T+lqtUr tdlpQjK67nm7aAClC/zNZtIW5TdxJTr0Nn3H3Zi5ilLW6kUonpRBd8U3ufddQMCY+XKw 1u0NzVmgKd2Dtg8j62nf7CIB933MdcHVI+wy0MJaTfX66TYJr4epBwbhuxQ7WDefLkeb IzLkM4Wm9B9CfW/6kCUDReQYeXq3pXwpzi5DKlcM7ZnXDryILmtYSrRE05ziGFtkycuO fPQw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=SCWX+UOWBBJn4LzW9Yj7QYHcJVlwVskIMygyEWiC3wA=; b=GiV2DZIXge3bobaNj1xyC91QLvRgJZ/w2zD0Mx2NbvG+0G8q3I3OXX0F+0/2nsoDM2 ZHVhU0sPh8xdz4/tMi9imxS3da8MnFl2PTz46yTpqD9ubW85XR/tBYGO21ucfeP4Q6u/ 2/Kdf2P+qorkqfZecTMx5yVzWUJF5DNgFrcOUYzM7RiMf2XhE2uPUhPKsdh2rFAfsjS3 Aftop5HqIC569xEBK3dWt0FkG8OB8YsM9Rn9Rest6ORHaavvIwlLGZI9bKX9sjw99Tw6 2+wNric/vI7ih6OPQldxSwIMKtyaZQNyoSdAJnh+Zjb8GddnoUoRQxYoRQ9zqJZO2PEG i6lQ== X-Gm-Message-State: AOAM530+0xB9OzYtiQTmXF5aEsJdF1AS4EkgN0koxCcXEvDF3ssDEoz4 UCPFRXFL0UUQOz8fSMhY/Psfsfdw2ZHjDGHoVc9lzTf0m69dMA== X-Google-Smtp-Source: ABdhPJwG5zE0x+hjJvBnpEznOmm5sOnqdV/YjJZRzgbBogf8unojEji7hX1GRoH0IU+rEawkdJbKxqx0xsaizjPJhNE= X-Received: by 2002:a65:4c08:: with SMTP id u8mr4275873pgq.203.1613660658089; Thu, 18 Feb 2021 07:04:18 -0800 (PST) MIME-Version: 1.0 References: <20210218052654.28995-1-calvin.johnson@oss.nxp.com> <20210218052654.28995-16-calvin.johnson@oss.nxp.com> In-Reply-To: <20210218052654.28995-16-calvin.johnson@oss.nxp.com> From: Andy Shevchenko Date: Thu, 18 Feb 2021 17:04:02 +0200 Message-ID: Subject: Re: [net-next PATCH v6 15/15] net: dpaa2-mac: Add ACPI support for DPAA2 MAC driver To: Calvin Johnson X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210218_100420_391169_7447E18F X-CRM114-Status: GOOD ( 15.85 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Andrew Lunn , Heikki Krogerus , "Rafael J . Wysocki" , Grant Likely , Ioana Ciornei , Florian Fainelli , Saravana Kannan , Jon , Russell King - ARM Linux admin , Diana Madalina Craciun , ACPI Devel Maling List , Jakub Kicinski , Florin Laurentiu Chiculita , Madalin Bucur , Pieter Jansen Van Vuuren , Marcin Wojtas , linux-arm Mailing List , Laurentiu Tudor , Ioana Radulescu , netdev , Randy Dunlap , Linux Kernel Mailing List , Jeremy Linton , Cristi Sovaiala , "linux.cj" , "David S. Miller" Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Thu, Feb 18, 2021 at 7:29 AM Calvin Johnson wrote: > > Modify dpaa2_mac_get_node() to get the dpmac fwnode from either > DT or ACPI. > > Modify dpaa2_mac_get_if_mode() to get interface mode from dpmac_node > which is a fwnode. > > Modify dpaa2_pcs_create() to create pcs from dpmac_node fwnode. > > Modify dpaa2_mac_connect() to support ACPI along with DT. ... > + if (is_of_node(fwnode)) Redundant check I think. If it's not an fwnode, the dpmacs is NULL and of_node_put() is NULL-aware. > + of_node_put(dpmacs); ... > + if (is_of_node(fwnode)) > + of_node_put(dpmacs); Ditto. ... > mac->if_link_type = mac->attr.link_type; > - Do we need to remove this blank line? ... > + if (is_of_node(dpmac_node)) > + fwnode_handle_put(dpmac_node); > + if (is_of_node(dpmac_node)) > + fwnode_handle_put(dpmac_node); Also not sure that you need a check in the above code excerpts. -- With Best Regards, Andy Shevchenko _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel