From: Andy Shevchenko <andy.shevchenko@gmail.com>
To: Guenter Roeck <linux@roeck-us.net>
Cc: Wim Van Sebroeck <wim@iguana.be>,
linux-watchdog@vger.kernel.org,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 3/4] watchdog: iTCO_wdt: Use pdev for platform device and pci_dev for pci device
Date: Wed, 4 Jan 2017 01:50:45 +0200 [thread overview]
Message-ID: <CAHp75VdVDG7aDgW8TOK-TQoAS5p8LC+U6jnhbZv-KwEoyzsDNQ@mail.gmail.com> (raw)
In-Reply-To: <CAHp75VcYArTMypmCZxM=kj_m-iWqKuOXd7V=fnWNv5Q+jmN0xw@mail.gmail.com>
On Wed, Jan 4, 2017 at 1:48 AM, Andy Shevchenko
<andy.shevchenko@gmail.com> wrote:
> On Wed, Jan 4, 2017 at 1:40 AM, Guenter Roeck <linux@roeck-us.net> wrote:
>> On Wed, Jan 04, 2017 at 12:39:59AM +0200, Andy Shevchenko wrote:
>>> On Tue, Jan 3, 2017 at 4:39 PM, Guenter Roeck <linux@roeck-us.net> wrote:
>>> > Use pdev for struct platform_device, pcidev for struct pci_dev, and dev
>>> > for struct device variables to improve consistency.
>>> >
>>> > Remove 'struct platform_device *dev;' from struct iTCO_wdt_private since
>>> > it was unused.
>>>
>>> Would pci_dev work?
>>>
>> Sure, or maybe just 'pci'. Any preference ?
>
> Just slightly prefer pci_dev over others (pcidev, pci), but do not
> insist. Up to you.
Or even
struct device *dev;
...
struct pci_dev *pci_dev = to_pci_dev(dev);
in places where it's guaranteed to be PCI.
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2017-01-03 23:50 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-01-03 14:39 [PATCH 1/4] watchdog: iTCO_wdt: Use allocated data structures Guenter Roeck
2017-01-03 14:39 ` [PATCH 2/4] watchdog: iTCO_wdt: Use device managed resources Guenter Roeck
2017-01-03 22:41 ` Andy Shevchenko
2017-01-03 23:38 ` Guenter Roeck
2017-01-04 2:44 ` Guenter Roeck
2017-01-03 14:39 ` [PATCH 3/4] watchdog: iTCO_wdt: Use pdev for platform device and pci_dev for pci device Guenter Roeck
2017-01-03 22:39 ` Andy Shevchenko
2017-01-03 23:40 ` Guenter Roeck
2017-01-03 23:48 ` Andy Shevchenko
2017-01-03 23:50 ` Andy Shevchenko [this message]
2017-01-04 1:38 ` Guenter Roeck
2017-01-03 14:39 ` [PATCH 4/4] watchdog: iTCO_wdt: Simplify module init function Guenter Roeck
2017-01-03 22:38 ` Andy Shevchenko
2017-01-03 22:44 ` [PATCH 1/4] watchdog: iTCO_wdt: Use allocated data structures Andy Shevchenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAHp75VdVDG7aDgW8TOK-TQoAS5p8LC+U6jnhbZv-KwEoyzsDNQ@mail.gmail.com \
--to=andy.shevchenko@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-watchdog@vger.kernel.org \
--cc=linux@roeck-us.net \
--cc=wim@iguana.be \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.