From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 98621ECAAD5 for ; Thu, 1 Sep 2022 19:39:22 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234626AbiIATjV (ORCPT ); Thu, 1 Sep 2022 15:39:21 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:43030 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234628AbiIATjS (ORCPT ); Thu, 1 Sep 2022 15:39:18 -0400 Received: from mail-qt1-x836.google.com (mail-qt1-x836.google.com [IPv6:2607:f8b0:4864:20::836]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 9FF769A9B4 for ; Thu, 1 Sep 2022 12:39:17 -0700 (PDT) Received: by mail-qt1-x836.google.com with SMTP id h22so14309064qtu.2 for ; Thu, 01 Sep 2022 12:39:17 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date; bh=caA/FC3GwEIv5k9saHBJim4xjLc8yHfbXgArB9Vpu9o=; b=KOA+pEkUTKh6NEiZvW0bhOuMsKMrHRq0GZiZppZfrIzhJJlf/cNhMT5nKA3TMNP8r3 Wo6rhkS0WvSoCvTy65pQrh2rO+8OEqebCcaPd40uEpi3IO0luDF8LcQ9/0tQ2BqMelYi 7KKGmUWZbiv3yUcuuoNFr+RhkGCla80rI/V6FLXc2KuqKCeGFT7WsqixGlO6IdDJJCeE hPRCBX5Tc3zbkoRnFBueyUKt3BDNeSo7y5IZFPkqhhUWlTe0EZKfzobTpmLOrXExn8Mk zK0oQRfAldkCNbAo9cRUG2hIAUFxJRbNQ4uCNeDc6iwrGB7z55hO5EJKxzJF4X8ZJCWO kTRQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date; bh=caA/FC3GwEIv5k9saHBJim4xjLc8yHfbXgArB9Vpu9o=; b=eaghx7NbJaN+V0w0oD6nNTAsK5SU2R5M43SgDlxvTui3LZnKV0TGmBNhPtWjtrpOP+ BMwD/WDuxSRcfqdaGozHWfH0l4waGG7zee6a/9/5c+IW9oXb4tqsSy1aXqJhnm4D5m22 6cg8uopMbtPpYkNf9szNw/wd8997plAcT0Wy7E/n52lNiMpUgLZCHBCS70p74Hk0Nd9o gTEySiisn0W+zsVJ/Aosw+YzLj467yomaoduFFDP+203zOBiI25Dmbc5jBu/O8SElu9X thVgjaAGmf0mq94TY/JRAg/KypnO6q4ft/15m8v/c+SWQlMQgeW1WR/qJtcpsXm6yKoG c1fA== X-Gm-Message-State: ACgBeo0uc2K3SbGF7i8nu4/QAx65caiyK1QegEKxpXQ0TjWxrWRU9OLv 53zdbpNHEBWPomFM6ta2tLDrpY6MhbnSpB0Ikso= X-Google-Smtp-Source: AA6agR7ycdrj03TpdN1pNIKGGZ9QWs6zk+zelMKiqHJgiCa6yv0iI9OO+AGRoQEK0SvmHRtqi1edNJROMh8PLIAu4EE= X-Received: by 2002:ac8:5786:0:b0:343:3051:170d with SMTP id v6-20020ac85786000000b003433051170dmr25052426qta.429.1662061156594; Thu, 01 Sep 2022 12:39:16 -0700 (PDT) MIME-Version: 1.0 References: <20220901175022.334824-1-cezary.rojewski@intel.com> <20220901175022.334824-3-cezary.rojewski@intel.com> In-Reply-To: <20220901175022.334824-3-cezary.rojewski@intel.com> From: Andy Shevchenko Date: Thu, 1 Sep 2022 22:38:40 +0300 Message-ID: Subject: Re: [PATCH v3 2/2] ASoC: SOF: Remove strsplit_u32() and tokenize_input() To: Cezary Rojewski Cc: ALSA Development Mailing List , Mark Brown , Takashi Iwai , Jaroslav Kysela , amadeuszx.slawinski@linux.intel.com, Pierre-Louis Bossart , Hans de Goede , Liam Girdwood , Kai Vehmanen , =?UTF-8?Q?P=C3=A9ter_Ujfalusi?= , Ranjani Sridharan , Bard Liao , Andy Shevchenko , Linux Kernel Mailing List , Matthew Wilcox Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Sep 1, 2022 at 8:40 PM Cezary Rojewski wrote: > > Make use of global user input tokenization helper instead of the > internal one as both serve same purpose. With that, both strsplit_u32() the same > and tokenize_input() become unused so remove them. ... > #include > #include > #include > +#include I believe either blank line needs to be here (to split the sound / SOF group of headers) or this should be put after 'so*'-ones > #include > #include > #include "sof-client.h" ... > struct sof_probes_priv *priv = cdev->data; > struct device *dev = &cdev->auxdev.dev; > struct sof_probe_point_desc *desc; > - size_t num_tkns, bytes; > - u32 *tkns; > + size_t bytes; > + u32 num_tkns, *tkns; I would expect a longer line first. > int ret, err; ... With the above addressed Reviewed-by: Andy Shevchenko -- With Best Regards, Andy Shevchenko From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 75C8CC6FA82 for ; Thu, 1 Sep 2022 19:40:19 +0000 (UTC) Received: from alsa1.perex.cz (alsa1.perex.cz [207.180.221.201]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by alsa0.perex.cz (Postfix) with ESMTPS id 73ECB1621; Thu, 1 Sep 2022 21:39:27 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa0.perex.cz 73ECB1621 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=alsa-project.org; s=default; t=1662061217; bh=czf+hxpxVjL2zRVTqzVr6h0JvZ3Vy0/hvkIxm79vY9g=; h=References:In-Reply-To:From:Date:Subject:To:Cc:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From; b=nTMnLZ/cRLoTQ5y+q3uX2ENnYHAcs8/AKV8adgjj0xjrhD7870GvziaC61NxbVNYi C0MwbOWMttzTiNUeQEAEC3AxO0WFCFTcdmHddwF+XNkFA9JjD2Jc7K/4AOw/Jnb9Ut XR6DcxpSOQaajIMtH4jv9jd5BFb+MxHsWgB+sHeU= Received: from alsa1.perex.cz (localhost.localdomain [127.0.0.1]) by alsa1.perex.cz (Postfix) with ESMTP id 1AE17F8026A; Thu, 1 Sep 2022 21:39:27 +0200 (CEST) Received: by alsa1.perex.cz (Postfix, from userid 50401) id 6FB4AF8026D; Thu, 1 Sep 2022 21:39:25 +0200 (CEST) Received: from mail-qt1-x834.google.com (mail-qt1-x834.google.com [IPv6:2607:f8b0:4864:20::834]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by alsa1.perex.cz (Postfix) with ESMTPS id ED91FF80236 for ; Thu, 1 Sep 2022 21:39:18 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa1.perex.cz ED91FF80236 Authentication-Results: alsa1.perex.cz; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="KOA+pEkU" Received: by mail-qt1-x834.google.com with SMTP id x5so14290978qtv.9 for ; Thu, 01 Sep 2022 12:39:18 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date; bh=caA/FC3GwEIv5k9saHBJim4xjLc8yHfbXgArB9Vpu9o=; b=KOA+pEkUTKh6NEiZvW0bhOuMsKMrHRq0GZiZppZfrIzhJJlf/cNhMT5nKA3TMNP8r3 Wo6rhkS0WvSoCvTy65pQrh2rO+8OEqebCcaPd40uEpi3IO0luDF8LcQ9/0tQ2BqMelYi 7KKGmUWZbiv3yUcuuoNFr+RhkGCla80rI/V6FLXc2KuqKCeGFT7WsqixGlO6IdDJJCeE hPRCBX5Tc3zbkoRnFBueyUKt3BDNeSo7y5IZFPkqhhUWlTe0EZKfzobTpmLOrXExn8Mk zK0oQRfAldkCNbAo9cRUG2hIAUFxJRbNQ4uCNeDc6iwrGB7z55hO5EJKxzJF4X8ZJCWO kTRQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date; bh=caA/FC3GwEIv5k9saHBJim4xjLc8yHfbXgArB9Vpu9o=; b=WlKA1UkI5z0jG7IlcI7C3govhLNJ5V+ETVYUdpnmEdVUKTa/GIRMWt0OEPDqyePnrX Rc5lhVtsrnzXMEpzP2R9IleDP07oK1wNf9szy08iy2Fm/DeRZhQqXW6hKREMMGp/Iuna ORD2Lbvajy4fAenR5n4QbqnaVvQxCEZxcDwpgS2C3HWytWDQJCJvKgVdi9P/duKjYkmI nH3Hy/wBvi91R844jjrK5dpg9LC7NESMPsPn7ldEueFyOQywwha97T1Kx7s5QxYlr/in pGVplWPMmz37u41Y3OVj+c3vT8bwt1RbQ355fnShsUp0viOptdlWeuXAa73feqTIIlnD u12Q== X-Gm-Message-State: ACgBeo0h74CloiCCeGjpflRjOS3eIVuMgIFqGHA6cFhki5tWtTOJYeyH VSFyw3y/8vw4psM9QmDYdHYweR/aR7KjhcG3bPE= X-Google-Smtp-Source: AA6agR7ycdrj03TpdN1pNIKGGZ9QWs6zk+zelMKiqHJgiCa6yv0iI9OO+AGRoQEK0SvmHRtqi1edNJROMh8PLIAu4EE= X-Received: by 2002:ac8:5786:0:b0:343:3051:170d with SMTP id v6-20020ac85786000000b003433051170dmr25052426qta.429.1662061156594; Thu, 01 Sep 2022 12:39:16 -0700 (PDT) MIME-Version: 1.0 References: <20220901175022.334824-1-cezary.rojewski@intel.com> <20220901175022.334824-3-cezary.rojewski@intel.com> In-Reply-To: <20220901175022.334824-3-cezary.rojewski@intel.com> From: Andy Shevchenko Date: Thu, 1 Sep 2022 22:38:40 +0300 Message-ID: Subject: Re: [PATCH v3 2/2] ASoC: SOF: Remove strsplit_u32() and tokenize_input() To: Cezary Rojewski Content-Type: text/plain; charset="UTF-8" Cc: Andy Shevchenko , ALSA Development Mailing List , Kai Vehmanen , Liam Girdwood , Bard Liao , Pierre-Louis Bossart , Matthew Wilcox , Takashi Iwai , Hans de Goede , Mark Brown , Ranjani Sridharan , amadeuszx.slawinski@linux.intel.com, =?UTF-8?Q?P=C3=A9ter_Ujfalusi?= , Linux Kernel Mailing List X-BeenThere: alsa-devel@alsa-project.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: alsa-devel-bounces@alsa-project.org Sender: "Alsa-devel" On Thu, Sep 1, 2022 at 8:40 PM Cezary Rojewski wrote: > > Make use of global user input tokenization helper instead of the > internal one as both serve same purpose. With that, both strsplit_u32() the same > and tokenize_input() become unused so remove them. ... > #include > #include > #include > +#include I believe either blank line needs to be here (to split the sound / SOF group of headers) or this should be put after 'so*'-ones > #include > #include > #include "sof-client.h" ... > struct sof_probes_priv *priv = cdev->data; > struct device *dev = &cdev->auxdev.dev; > struct sof_probe_point_desc *desc; > - size_t num_tkns, bytes; > - u32 *tkns; > + size_t bytes; > + u32 num_tkns, *tkns; I would expect a longer line first. > int ret, err; ... With the above addressed Reviewed-by: Andy Shevchenko -- With Best Regards, Andy Shevchenko