From mboxrd@z Thu Jan  1 00:00:00 1970
From: Andy Shevchenko <andy.shevchenko@gmail.com>
Date: Mon, 16 Jul 2018 18:47:21 +0300
Subject: [U-Boot] [PATCH] serial: ns16550: Add register shift variable
In-Reply-To: <4881796E12491D4BB15146FE0209CE64681148D9@DE02WEMBXB.internal.synopsys.com>
References: <1531492980-16543-1-git-send-email-fb@ltec.ch>
 <20180714104721.A8B69240175@gemini.denx.de>
 <20180714154933.GF2888@bill-the-cat>
 <4881796E12491D4BB15146FE0209CE646811421F@DE02WEMBXB.internal.synopsys.com>
 <bdf1a23a-ea64-a0ca-5cc1-290b254f2ec8@ltec.ch>
 <4881796E12491D4BB15146FE0209CE64681148D9@DE02WEMBXB.internal.synopsys.com>
Message-ID: <CAHp75VdYDirzq8qKNrgwSOkyOJj12-GiCo84gRc+CjeDif90nA@mail.gmail.com>
List-Id: <u-boot.lists.denx.de>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
To: u-boot@lists.denx.de

On Mon, Jul 16, 2018 at 6:04 PM, Alexey Brodkin
<Alexey.Brodkin@synopsys.com> wrote:

>> > Any chance to get a reference to the commit in Linux kernel that introduces that change?
>> >
>> In fact I believe that the <reg-shift> property never existed in the
>> am33xx.dtsi file from Linux. U-Boot commit 85cf0e6299 shows that the
>> property has been added to U-Boot's am33xx.dtsi file. The commit log
>> clearly states why this happened:
>>
>> "With the commit 'c7b9686d5d48 ("ns16550: unify serial_omap")' all
>> TI platforms are broken with DM/DT boot as ns16550 driver expects
>> reg-shift from DT which is not populated for TI platforms.
>> Earlier it worked as it was hard coded to 2 in serial-omap
>> driver. So adding the reg-shift to serial nodes for dra7, am4372
>> and am33xx dtsi files. Tested this patch on am437x-sk-evm,
>> am437x-gp-evm, am335x-boneblack, dra74x-evm and dra72x-evm."
>
> Ok so this has nothing to do with changes in Linux kernel I guess.
> Why don't we go the other way around and not just submit
> a change to .dts files in Linux kernel that are missing required properties?

You may change DTSi files in the Linux kernel sources tree, but you
wouldn't be able to fix all DTB:s in the wild.
In this case Linux should have a fallback to the previous value in
case property is not found.

-- 
With Best Regards,
Andy Shevchenko