From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id DA700C19F28 for ; Wed, 3 Aug 2022 11:33:26 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S237535AbiHCLdZ (ORCPT ); Wed, 3 Aug 2022 07:33:25 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:53382 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S237607AbiHCLdT (ORCPT ); Wed, 3 Aug 2022 07:33:19 -0400 Received: from mail-ej1-x62a.google.com (mail-ej1-x62a.google.com [IPv6:2a00:1450:4864:20::62a]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id C679F4E61E; Wed, 3 Aug 2022 04:33:11 -0700 (PDT) Received: by mail-ej1-x62a.google.com with SMTP id gk3so18753668ejb.8; Wed, 03 Aug 2022 04:33:11 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc; bh=vao2Cp7i5f6/k5QYAFT9/dBZf5yhq/l9mTWgGJqR6PY=; b=bWIMn9pC4xFcXuTK4bWw29xOdTVboCuIfO1+MCkkSWj4i30GZm2QG93Qmw2QCJGamO Cgrb9KXyDgBtTRh1j7tOsoRtCwJUAegKJ+y6Go1NlRhIJLc/0cNWdW8O1N1o8gZsglVW CbrG0u9x/x2rpo4d0VHdeqJ2TCMvLugC2oyZ8EJmwQl/6hhno0vtJBtx/8wyi0bEkZuB NNcxeYx1qIKFRr2yyLd4MARfZo8m7X0zfZjfyOFD8USyfmrMyGF7VIFMTA8zbi4Wfcci WeUK0HBL1RY1uKud3XQJjZpXnfWQuU+eqkbpQ3AHkKD9aen1I5A2iq8SYXIwSUXAnJZH O70g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc; bh=vao2Cp7i5f6/k5QYAFT9/dBZf5yhq/l9mTWgGJqR6PY=; b=ehQ33XYEQWWlyKRIDwsyzoV2Qa1u0FCxlaDKClbGopCFBUvcZ6GtQuNhku2IHmi7dc slvhmhQ0zNl8Vj5YiS0YrGheVv4GgPDMHfeUQk33cZTLgRgELeRFQM97fdYbdk4lXTkc n/4gCMVEdu4Ex06df1Mz27xkP6u6m2KRK7ZoY77nr6Eh8GzpLxY03sMzlJCH4+0SJBA5 ojNXcj/vWQ33o1YjsL7VvvGHdGm/TJ1WJ0Z8S/hByV10zVdZFj3VmR8Q8YpLZTgcNegF zpY995SL8H9eIbFuNAmDzj/iEli4tFO2epo0VoYgJ3EOUa0FjHhvfGM+MZDvgOTxUTF2 FGLA== X-Gm-Message-State: AJIora9zEMypk8gszwenFiYI4eclOnbTwFJzNCMsJbKRSd1+Cn7aipYL g7EvzjzCqRNVH28tm+MNkaUb7vmJKXj6oAlJ10o= X-Google-Smtp-Source: AGRyM1udxSQf76xVtwQpbkoB2qLWhTDDrQa++hbKCvIQy32osP8KAwyThml0YqEPpjzgdiCNXi/b7MNyT9hXQzjdWEA= X-Received: by 2002:a17:907:2dab:b0:72f:f7:bdd6 with SMTP id gt43-20020a1709072dab00b0072f00f7bdd6mr20763646ejc.330.1659526390304; Wed, 03 Aug 2022 04:33:10 -0700 (PDT) MIME-Version: 1.0 References: <20220803054728.1541104-1-colin.foster@in-advantage.com> <20220803054728.1541104-6-colin.foster@in-advantage.com> In-Reply-To: <20220803054728.1541104-6-colin.foster@in-advantage.com> From: Andy Shevchenko Date: Wed, 3 Aug 2022 13:32:33 +0200 Message-ID: Subject: Re: [PATCH v15 mfd 5/9] pinctrl: microchip-sgpio: allow sgpio driver to be used as a module To: Colin Foster Cc: linux-arm Mailing List , "open list:GPIO SUBSYSTEM" , netdev , Linux Kernel Mailing List , devicetree , Terry Bowman , Vladimir Oltean , Wolfram Sang , Microchip Linux Driver Support , Steen Hegelund , Lars Povlsen , Linus Walleij , Paolo Abeni , Jakub Kicinski , Eric Dumazet , "David S. Miller" , Russell King , Heiner Kallweit , Andrew Lunn , Krzysztof Kozlowski , Rob Herring , Lee Jones , katie.morris@in-advantage.com, Florian Fainelli Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-gpio@vger.kernel.org On Wed, Aug 3, 2022 at 7:47 AM Colin Foster wrote: > > As the commit message suggests, this simply adds the ability to select > SGPIO pinctrl as a module. This becomes more practical when the SGPIO > hardware exists on an external chip, controlled indirectly by I2C or SPI. > This commit enables that level of control. FWIW, Reviewed-by: Andy Shevchenko > Signed-off-by: Colin Foster > Reviewed-by: Linus Walleij > Reviewed-by: Florian Fainelli > Reviewed-by: Vladimir Oltean > --- > > (No changes since before v14) > > v14 > * No changes > > --- > drivers/pinctrl/Kconfig | 5 ++++- > drivers/pinctrl/pinctrl-microchip-sgpio.c | 6 +++++- > 2 files changed, 9 insertions(+), 2 deletions(-) > > diff --git a/drivers/pinctrl/Kconfig b/drivers/pinctrl/Kconfig > index ba48ff8be6e2..4e8d0ae6c81e 100644 > --- a/drivers/pinctrl/Kconfig > +++ b/drivers/pinctrl/Kconfig > @@ -292,7 +292,7 @@ config PINCTRL_MCP23S08 > corresponding interrupt-controller. > > config PINCTRL_MICROCHIP_SGPIO > - bool "Pinctrl driver for Microsemi/Microchip Serial GPIO" > + tristate "Pinctrl driver for Microsemi/Microchip Serial GPIO" > depends on OF > depends on HAS_IOMEM > select GPIOLIB > @@ -310,6 +310,9 @@ config PINCTRL_MICROCHIP_SGPIO > connect control signals from SFP modules and to act as an > LED controller. > > + If compiled as a module, the module name will be > + pinctrl-microchip-sgpio. > + > config PINCTRL_OCELOT > tristate "Pinctrl driver for the Microsemi Ocelot and Jaguar2 SoCs" > depends on OF > diff --git a/drivers/pinctrl/pinctrl-microchip-sgpio.c b/drivers/pinctrl/pinctrl-microchip-sgpio.c > index 6f55bf7d5e05..e56074b7e659 100644 > --- a/drivers/pinctrl/pinctrl-microchip-sgpio.c > +++ b/drivers/pinctrl/pinctrl-microchip-sgpio.c > @@ -999,6 +999,7 @@ static const struct of_device_id microchip_sgpio_gpio_of_match[] = { > /* sentinel */ > } > }; > +MODULE_DEVICE_TABLE(of, microchip_sgpio_gpio_of_match); > > static struct platform_driver microchip_sgpio_pinctrl_driver = { > .driver = { > @@ -1008,4 +1009,7 @@ static struct platform_driver microchip_sgpio_pinctrl_driver = { > }, > .probe = microchip_sgpio_probe, > }; > -builtin_platform_driver(microchip_sgpio_pinctrl_driver); > +module_platform_driver(microchip_sgpio_pinctrl_driver); > + > +MODULE_DESCRIPTION("Microchip SGPIO Pinctrl Driver"); > +MODULE_LICENSE("GPL"); > -- > 2.25.1 > -- With Best Regards, Andy Shevchenko From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id E79C9C19F28 for ; Wed, 3 Aug 2022 11:35:30 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:Cc:To:Subject:Message-ID:Date:From: In-Reply-To:References:MIME-Version:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=DcGopyyU0vVAUkplB7stxTuO5deci5KD8OSRhnPGh6I=; b=3tJHGYP09f6F4c b7Vfq5gHjOCpSGQ5lXnZ2M3sgqFaEPcID1eOi7fusXaMZ3xygTwmrCdyMV24rlFfDz/0FFCZKwch/ ZcY0qSqRpUlnrhK70c63fl/OzdqSSLnTk/0kW7usi/XHSUAj4lafWQQRZWqWMpubvtljF6lf159T7 eB6yOdmutebI2SNzXxlxrNrGA1vZO2sS/rJatHZwXRImY66pYoMeRCiNjFesncw7Lkl2fil+1JuYs sYD3rbXjgi6l6yzgqn8sNwCIw2frn47dMmVO/8au9Elqo9Tp4QKqBg5w29AD/bbot2Tq9O/u/cuUs TMNBIxANgAIdnWoV2cpw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1oJCdZ-005OfV-M1; Wed, 03 Aug 2022 11:34:06 +0000 Received: from mail-ej1-x630.google.com ([2a00:1450:4864:20::630]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1oJCck-005O2I-4o for linux-arm-kernel@lists.infradead.org; Wed, 03 Aug 2022 11:33:19 +0000 Received: by mail-ej1-x630.google.com with SMTP id gb36so5357452ejc.10 for ; Wed, 03 Aug 2022 04:33:11 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc; bh=vao2Cp7i5f6/k5QYAFT9/dBZf5yhq/l9mTWgGJqR6PY=; b=bWIMn9pC4xFcXuTK4bWw29xOdTVboCuIfO1+MCkkSWj4i30GZm2QG93Qmw2QCJGamO Cgrb9KXyDgBtTRh1j7tOsoRtCwJUAegKJ+y6Go1NlRhIJLc/0cNWdW8O1N1o8gZsglVW CbrG0u9x/x2rpo4d0VHdeqJ2TCMvLugC2oyZ8EJmwQl/6hhno0vtJBtx/8wyi0bEkZuB NNcxeYx1qIKFRr2yyLd4MARfZo8m7X0zfZjfyOFD8USyfmrMyGF7VIFMTA8zbi4Wfcci WeUK0HBL1RY1uKud3XQJjZpXnfWQuU+eqkbpQ3AHkKD9aen1I5A2iq8SYXIwSUXAnJZH O70g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc; bh=vao2Cp7i5f6/k5QYAFT9/dBZf5yhq/l9mTWgGJqR6PY=; b=pZct8YCZ1xi36nMcxggh1oyYcMTXrLXGbvY9NA1egouh2sZQwCdZQ7yhABv5AUPoSY hpRayXDukl5aeqLexIT0RuwBM56yKltHUiHONdWEmTcw5P6E/cznI4mdI2nG0DA7kk1+ XsLwnLldJtmfC+t7AV47qJqCuBavMFhdpDnMTGiyNaVyFxbubnnGRITvs4vlQPF7OEYK NIPvz7yMDI7+7Cxw0z3e67Yspxe9kJRT7X3Mf3FpQpQwOiL5HYDRVLRgEKOkJrVJ30hj SSUK166Jwe80RhVCq6ZRtfLGvfXfY6aZ5igJ/5f7b3O2Z8gXeq4pi7/krfklOOuBCaeq BB5A== X-Gm-Message-State: AJIora91fzSXDXtTf4zfhv271873n0F04Yl3DhQqwhktHTez+oOQ4sBW t4IWJK8sb5WfdJOpAtE8UOKDyhAKDaHsXghzOYQ= X-Google-Smtp-Source: AGRyM1udxSQf76xVtwQpbkoB2qLWhTDDrQa++hbKCvIQy32osP8KAwyThml0YqEPpjzgdiCNXi/b7MNyT9hXQzjdWEA= X-Received: by 2002:a17:907:2dab:b0:72f:f7:bdd6 with SMTP id gt43-20020a1709072dab00b0072f00f7bdd6mr20763646ejc.330.1659526390304; Wed, 03 Aug 2022 04:33:10 -0700 (PDT) MIME-Version: 1.0 References: <20220803054728.1541104-1-colin.foster@in-advantage.com> <20220803054728.1541104-6-colin.foster@in-advantage.com> In-Reply-To: <20220803054728.1541104-6-colin.foster@in-advantage.com> From: Andy Shevchenko Date: Wed, 3 Aug 2022 13:32:33 +0200 Message-ID: Subject: Re: [PATCH v15 mfd 5/9] pinctrl: microchip-sgpio: allow sgpio driver to be used as a module To: Colin Foster Cc: linux-arm Mailing List , "open list:GPIO SUBSYSTEM" , netdev , Linux Kernel Mailing List , devicetree , Terry Bowman , Vladimir Oltean , Wolfram Sang , Microchip Linux Driver Support , Steen Hegelund , Lars Povlsen , Linus Walleij , Paolo Abeni , Jakub Kicinski , Eric Dumazet , "David S. Miller" , Russell King , Heiner Kallweit , Andrew Lunn , Krzysztof Kozlowski , Rob Herring , Lee Jones , katie.morris@in-advantage.com, Florian Fainelli X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220803_043314_379423_15CD17C8 X-CRM114-Status: GOOD ( 26.77 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Wed, Aug 3, 2022 at 7:47 AM Colin Foster wrote: > > As the commit message suggests, this simply adds the ability to select > SGPIO pinctrl as a module. This becomes more practical when the SGPIO > hardware exists on an external chip, controlled indirectly by I2C or SPI. > This commit enables that level of control. FWIW, Reviewed-by: Andy Shevchenko > Signed-off-by: Colin Foster > Reviewed-by: Linus Walleij > Reviewed-by: Florian Fainelli > Reviewed-by: Vladimir Oltean > --- > > (No changes since before v14) > > v14 > * No changes > > --- > drivers/pinctrl/Kconfig | 5 ++++- > drivers/pinctrl/pinctrl-microchip-sgpio.c | 6 +++++- > 2 files changed, 9 insertions(+), 2 deletions(-) > > diff --git a/drivers/pinctrl/Kconfig b/drivers/pinctrl/Kconfig > index ba48ff8be6e2..4e8d0ae6c81e 100644 > --- a/drivers/pinctrl/Kconfig > +++ b/drivers/pinctrl/Kconfig > @@ -292,7 +292,7 @@ config PINCTRL_MCP23S08 > corresponding interrupt-controller. > > config PINCTRL_MICROCHIP_SGPIO > - bool "Pinctrl driver for Microsemi/Microchip Serial GPIO" > + tristate "Pinctrl driver for Microsemi/Microchip Serial GPIO" > depends on OF > depends on HAS_IOMEM > select GPIOLIB > @@ -310,6 +310,9 @@ config PINCTRL_MICROCHIP_SGPIO > connect control signals from SFP modules and to act as an > LED controller. > > + If compiled as a module, the module name will be > + pinctrl-microchip-sgpio. > + > config PINCTRL_OCELOT > tristate "Pinctrl driver for the Microsemi Ocelot and Jaguar2 SoCs" > depends on OF > diff --git a/drivers/pinctrl/pinctrl-microchip-sgpio.c b/drivers/pinctrl/pinctrl-microchip-sgpio.c > index 6f55bf7d5e05..e56074b7e659 100644 > --- a/drivers/pinctrl/pinctrl-microchip-sgpio.c > +++ b/drivers/pinctrl/pinctrl-microchip-sgpio.c > @@ -999,6 +999,7 @@ static const struct of_device_id microchip_sgpio_gpio_of_match[] = { > /* sentinel */ > } > }; > +MODULE_DEVICE_TABLE(of, microchip_sgpio_gpio_of_match); > > static struct platform_driver microchip_sgpio_pinctrl_driver = { > .driver = { > @@ -1008,4 +1009,7 @@ static struct platform_driver microchip_sgpio_pinctrl_driver = { > }, > .probe = microchip_sgpio_probe, > }; > -builtin_platform_driver(microchip_sgpio_pinctrl_driver); > +module_platform_driver(microchip_sgpio_pinctrl_driver); > + > +MODULE_DESCRIPTION("Microchip SGPIO Pinctrl Driver"); > +MODULE_LICENSE("GPL"); > -- > 2.25.1 > -- With Best Regards, Andy Shevchenko _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel