From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752013AbdDCJoN (ORCPT ); Mon, 3 Apr 2017 05:44:13 -0400 Received: from mail-qt0-f194.google.com ([209.85.216.194]:33738 "EHLO mail-qt0-f194.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751738AbdDCJoM (ORCPT ); Mon, 3 Apr 2017 05:44:12 -0400 MIME-Version: 1.0 In-Reply-To: References: <201704030713.jb1PXu29%fengguang.wu@intel.com> From: Andy Shevchenko Date: Mon, 3 Apr 2017 12:44:11 +0300 Message-ID: Subject: Re: [tip:x86/platform 1/1] platform_bt.c:undefined reference to `gpiod_add_lookup_table' To: Arnd Bergmann Cc: kbuild test robot , Andy Shevchenko , kbuild-all@01.org, "linux-kernel@vger.kernel.org" , tipbuild@zytor.com, Ingo Molnar Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Apr 3, 2017 at 12:36 PM, Andy Shevchenko wrote: > On Mon, Apr 3, 2017 at 12:31 PM, Arnd Bergmann wrote: >> On Mon, Apr 3, 2017 at 10:13 AM, Andy Shevchenko >> wrote: >>> On Mon, Apr 3, 2017 at 2:23 AM, kbuild test robot >>> wrote: >>>> arch/x86/built-in.o: In function `tng_bt_sfi_setup': >>>>>> platform_bt.c:(.init.text+0x13a30): undefined reference to `gpiod_add_lookup_table' >> >> I'd guess it's a missing dependency on GPIOLIB > > Apparently not this one. > > The module is purely built whenever HCIUART_BCM is defined which is a > consumer of GPIO. > And that one does not have a dependency. ...and they should not. So, there are two ways of fix this: - add a stub for gpiod_add_lookup_table() for !GPIOLIB case, or - add ifdeffery around this code here (with obvious increase of ugliness). -- With Best Regards, Andy Shevchenko