From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756872AbcBJGlT (ORCPT ); Wed, 10 Feb 2016 01:41:19 -0500 Received: from mail-yk0-f180.google.com ([209.85.160.180]:36837 "EHLO mail-yk0-f180.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751058AbcBJGlS (ORCPT ); Wed, 10 Feb 2016 01:41:18 -0500 MIME-Version: 1.0 In-Reply-To: <1455048677-19882-2-git-send-email-linux@rasmusvillemoes.dk> References: <1455048677-19882-1-git-send-email-linux@rasmusvillemoes.dk> <1455048677-19882-2-git-send-email-linux@rasmusvillemoes.dk> Date: Wed, 10 Feb 2016 08:41:17 +0200 Message-ID: Subject: Re: [PATCH 1/5] drm/gma500: fix error path in gma_intel_setup_gmbus() From: Andy Shevchenko To: Rasmus Villemoes Cc: Patrik Jakobsson , David Airlie , dri-devel@lists.freedesktop.org, "linux-kernel@vger.kernel.org" Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Feb 9, 2016 at 10:11 PM, Rasmus Villemoes wrote: > The current code fails to call i2c_del_adapter on > dev_prev->gmbus[0].adapter, and if the for loop above failed already > at i==0, all hell breaks loose when we do the loop body for > i = -1,-2,... > Reviewed-by: Andy Shevchenko > Signed-off-by: Rasmus Villemoes > --- > drivers/gpu/drm/gma500/intel_gmbus.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/gpu/drm/gma500/intel_gmbus.c b/drivers/gpu/drm/gma500/intel_gmbus.c > index 566d330aaeea..e7e22187c539 100644 > --- a/drivers/gpu/drm/gma500/intel_gmbus.c > +++ b/drivers/gpu/drm/gma500/intel_gmbus.c > @@ -436,7 +436,7 @@ int gma_intel_setup_gmbus(struct drm_device *dev) > return 0; > > err: > - while (--i) { > + while (i--) { > struct intel_gmbus *bus = &dev_priv->gmbus[i]; > i2c_del_adapter(&bus->adapter); > } > -- > 2.1.4 > -- With Best Regards, Andy Shevchenko From mboxrd@z Thu Jan 1 00:00:00 1970 From: Andy Shevchenko Subject: Re: [PATCH 1/5] drm/gma500: fix error path in gma_intel_setup_gmbus() Date: Wed, 10 Feb 2016 08:41:17 +0200 Message-ID: References: <1455048677-19882-1-git-send-email-linux@rasmusvillemoes.dk> <1455048677-19882-2-git-send-email-linux@rasmusvillemoes.dk> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mail-yk0-f182.google.com (mail-yk0-f182.google.com [209.85.160.182]) by gabe.freedesktop.org (Postfix) with ESMTPS id 08E786E64B for ; Tue, 9 Feb 2016 22:41:18 -0800 (PST) Received: by mail-yk0-f182.google.com with SMTP id z13so4232273ykd.0 for ; Tue, 09 Feb 2016 22:41:18 -0800 (PST) In-Reply-To: <1455048677-19882-2-git-send-email-linux@rasmusvillemoes.dk> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Rasmus Villemoes Cc: dri-devel@lists.freedesktop.org, "linux-kernel@vger.kernel.org" List-Id: dri-devel@lists.freedesktop.org T24gVHVlLCBGZWIgOSwgMjAxNiBhdCAxMDoxMSBQTSwgUmFzbXVzIFZpbGxlbW9lcwo8bGludXhA cmFzbXVzdmlsbGVtb2VzLmRrPiB3cm90ZToKPiBUaGUgY3VycmVudCBjb2RlIGZhaWxzIHRvIGNh bGwgaTJjX2RlbF9hZGFwdGVyIG9uCj4gZGV2X3ByZXYtPmdtYnVzWzBdLmFkYXB0ZXIsIGFuZCBp ZiB0aGUgZm9yIGxvb3AgYWJvdmUgZmFpbGVkIGFscmVhZHkKPiBhdCBpPT0wLCBhbGwgaGVsbCBi cmVha3MgbG9vc2Ugd2hlbiB3ZSBkbyB0aGUgbG9vcCBib2R5IGZvcgo+IGkgPSAtMSwtMiwuLi4K PgoKUmV2aWV3ZWQtYnk6IEFuZHkgU2hldmNoZW5rbyA8YW5keS5zaGV2Y2hlbmtvQGdtYWlsLmNv bT4KCj4gU2lnbmVkLW9mZi1ieTogUmFzbXVzIFZpbGxlbW9lcyA8bGludXhAcmFzbXVzdmlsbGVt b2VzLmRrPgo+IC0tLQo+ICBkcml2ZXJzL2dwdS9kcm0vZ21hNTAwL2ludGVsX2dtYnVzLmMgfCAy ICstCj4gIDEgZmlsZSBjaGFuZ2VkLCAxIGluc2VydGlvbigrKSwgMSBkZWxldGlvbigtKQo+Cj4g ZGlmZiAtLWdpdCBhL2RyaXZlcnMvZ3B1L2RybS9nbWE1MDAvaW50ZWxfZ21idXMuYyBiL2RyaXZl cnMvZ3B1L2RybS9nbWE1MDAvaW50ZWxfZ21idXMuYwo+IGluZGV4IDU2NmQzMzBhYWVlYS4uZTdl MjIxODdjNTM5IDEwMDY0NAo+IC0tLSBhL2RyaXZlcnMvZ3B1L2RybS9nbWE1MDAvaW50ZWxfZ21i dXMuYwo+ICsrKyBiL2RyaXZlcnMvZ3B1L2RybS9nbWE1MDAvaW50ZWxfZ21idXMuYwo+IEBAIC00 MzYsNyArNDM2LDcgQEAgaW50IGdtYV9pbnRlbF9zZXR1cF9nbWJ1cyhzdHJ1Y3QgZHJtX2Rldmlj ZSAqZGV2KQo+ICAgICAgICAgcmV0dXJuIDA7Cj4KPiAgZXJyOgo+IC0gICAgICAgd2hpbGUgKC0t aSkgewo+ICsgICAgICAgd2hpbGUgKGktLSkgewo+ICAgICAgICAgICAgICAgICBzdHJ1Y3QgaW50 ZWxfZ21idXMgKmJ1cyA9ICZkZXZfcHJpdi0+Z21idXNbaV07Cj4gICAgICAgICAgICAgICAgIGky Y19kZWxfYWRhcHRlcigmYnVzLT5hZGFwdGVyKTsKPiAgICAgICAgIH0KPiAtLQo+IDIuMS40Cj4K CgoKLS0gCldpdGggQmVzdCBSZWdhcmRzLApBbmR5IFNoZXZjaGVua28KX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KZHJpLWRldmVsIG1haWxpbmcgbGlzdApk cmktZGV2ZWxAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHBzOi8vbGlzdHMuZnJlZWRlc2t0b3Au b3JnL21haWxtYW4vbGlzdGluZm8vZHJpLWRldmVsCg==