All of lore.kernel.org
 help / color / mirror / Atom feed
From: Andy Shevchenko <andy.shevchenko@gmail.com>
To: Sergey Shtylyov <s.shtylyov@omp.ru>
Cc: Andy Shevchenko <andriy.shevchenko@intel.com>,
	Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	"Rafael J. Wysocki" <rafael@kernel.org>,
	Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] platform: finally disallow IRQ0 in platform_get_irq() and its ilk
Date: Wed, 5 Jan 2022 12:09:08 +0200	[thread overview]
Message-ID: <CAHp75VddS225riMvTD36M4UNKC=zKYLCmUdJsACvWbf7=8CqRA@mail.gmail.com> (raw)
In-Reply-To: <8a415980-990b-abae-6f60-dedd0c199583@omp.ru>

On Wed, Jan 5, 2022 at 9:40 AM Sergey Shtylyov <s.shtylyov@omp.ru> wrote:
> On 12/10/21 2:17 PM, Andy Shevchenko wrote:

> >>> Wanna help?
> >>
> >>    No, I'm afraid you're on your own here...
>
>    Tell me please, how far you've got with this by now?
>    (I've already started to add the fixups to your patch -- unfortunately, this change has to be
> done atomically, not piecemeal.)

I just returned from vacation and will have another one soon, I don't
think I will be doing much for the next couple of weeks.


> >>>> Fixes: a85a6c86c25b ("driver core: platform: Clarify that IRQ 0 is invalid")
> >>>
> >>> Not sure.
> >>
> >>    Why? It fixes gthe IRQ0 problem, so that you don't have to check for IRQ0 in many callers
> >> (for the subsytems that treat 0 as s/th special, like polling mode)... If you have something
> >> to improve, you can do that atop of this patch...
> >
> > Because first we need to fix all users of platform_get_irq_optional().
>
>    I still don't understand why your issue should be fixed 1st -- but I don't really care about
> the order...

See my other comments on the discussion.
The rough roadmap is:
1) check which drivers are still subjects of vIRQ0 which is retrieved
via IRQ resource
2) fix them accordingly (for example, by transforming to IRQ domains)
3) convert platform_get_irq() and Co (including optional variants) to
follow the pattern
 a) non-optional APIs never return 0
 b) optional APIs return negative error, or positive vIRQ or 0 when
IRQ not found

Alternatively you may put a big comment in the drivers first and use
platform_get_resource() for retrieving IRQ0 without WARN(). Then they
will be subject to fix later on.

-- 
With Best Regards,
Andy Shevchenko

  reply	other threads:[~2022-01-05 10:09 UTC|newest]

Thread overview: 25+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-11-06 20:26 [PATCH] platform: finally disallow IRQ0 in platform_get_irq() and its ilk Sergey Shtylyov
2021-11-26 16:20 ` Greg Kroah-Hartman
2021-12-02 21:11   ` Sergey Shtylyov
2021-12-09 20:06 ` Andy Shevchenko
2021-12-09 20:21   ` Sergey Shtylyov
2021-12-10 11:17     ` Andy Shevchenko
2022-01-04 19:27       ` Sergey Shtylyov
2022-01-05 10:09         ` Andy Shevchenko [this message]
2022-01-09 11:31           ` Sergey Shtylyov
2022-01-04  9:26 ` Marc Zyngier
2022-01-04  9:47   ` Geert Uytterhoeven
2022-01-04 10:48     ` Marc Zyngier
2022-01-04 10:53       ` Greg Kroah-Hartman
2022-01-04 11:13         ` Marc Zyngier
2022-01-05 10:02         ` Andy Shevchenko
2022-01-04 11:24       ` Geert Uytterhoeven
2022-01-05  9:59         ` Andy Shevchenko
2022-01-04 12:23     ` Sergey Shtylyov
2022-01-04 20:30   ` Sergey Shtylyov
2022-01-12 17:53   ` Sergey Shtylyov
2022-01-12 18:08     ` Marc Zyngier
2022-01-12 20:08       ` Sergey Shtylyov
2022-02-11 20:20       ` Sergey Shtylyov
2022-01-12 18:19     ` Greg Kroah-Hartman
2022-01-12 20:20       ` Sergey Shtylyov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAHp75VddS225riMvTD36M4UNKC=zKYLCmUdJsACvWbf7=8CqRA@mail.gmail.com' \
    --to=andy.shevchenko@gmail.com \
    --cc=andriy.shevchenko@intel.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=rafael@kernel.org \
    --cc=s.shtylyov@omp.ru \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.