From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1758193AbdACWic (ORCPT ); Tue, 3 Jan 2017 17:38:32 -0500 Received: from mail-qt0-f195.google.com ([209.85.216.195]:35004 "EHLO mail-qt0-f195.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752738AbdACWiO (ORCPT ); Tue, 3 Jan 2017 17:38:14 -0500 MIME-Version: 1.0 In-Reply-To: <1483454364-28650-4-git-send-email-linux@roeck-us.net> References: <1483454364-28650-1-git-send-email-linux@roeck-us.net> <1483454364-28650-4-git-send-email-linux@roeck-us.net> From: Andy Shevchenko Date: Wed, 4 Jan 2017 00:38:03 +0200 Message-ID: Subject: Re: [PATCH 4/4] watchdog: iTCO_wdt: Simplify module init function To: Guenter Roeck Cc: Wim Van Sebroeck , linux-watchdog@vger.kernel.org, "linux-kernel@vger.kernel.org" , Matt Fleming Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Jan 3, 2017 at 4:39 PM, Guenter Roeck wrote: > The 'ret' variable in iTCO_wdt_init_module() does not add any value; > drop it. Perhaps 'err', otherwise: Reviewed-by: Andy Shevchenko > > Signed-off-by: Guenter Roeck > --- > drivers/watchdog/iTCO_wdt.c | 8 +------- > 1 file changed, 1 insertion(+), 7 deletions(-) > > diff --git a/drivers/watchdog/iTCO_wdt.c b/drivers/watchdog/iTCO_wdt.c > index ad29ae03a30b..fc7712112412 100644 > --- a/drivers/watchdog/iTCO_wdt.c > +++ b/drivers/watchdog/iTCO_wdt.c > @@ -612,15 +612,9 @@ static struct platform_driver iTCO_wdt_driver = { > > static int __init iTCO_wdt_init_module(void) > { > - int err; > - > pr_info("Intel TCO WatchDog Timer Driver v%s\n", DRV_VERSION); > > - err = platform_driver_register(&iTCO_wdt_driver); > - if (err) > - return err; > - > - return 0; > + return platform_driver_register(&iTCO_wdt_driver); > } > > static void __exit iTCO_wdt_cleanup_module(void) > -- > 2.7.4 > -- With Best Regards, Andy Shevchenko