From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5EA29C433E2 for ; Mon, 29 Mar 2021 10:41:06 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 280076196E for ; Mon, 29 Mar 2021 10:41:06 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232218AbhC2Kkd (ORCPT ); Mon, 29 Mar 2021 06:40:33 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:51102 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231451AbhC2KkB (ORCPT ); Mon, 29 Mar 2021 06:40:01 -0400 Received: from mail-pl1-x635.google.com (mail-pl1-x635.google.com [IPv6:2607:f8b0:4864:20::635]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 4BEC9C061574; Mon, 29 Mar 2021 03:40:01 -0700 (PDT) Received: by mail-pl1-x635.google.com with SMTP id e14so4193202plj.2; Mon, 29 Mar 2021 03:40:01 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=v6A8lkGT7qlDfG5OHFA7dTWCjZVRjtLZtjsAR4wx34Y=; b=o15S4Oc4W6Wisr5EVArkn/MoM98iA9zt3Z7a9BPfcrkZuwq/IjnGzlwFxOZELQiVxv 4uP8RbtXTVyaYb7xFT5oVNy8SwZ1kxh8r/wb10klTriK+oztFTTMOMBpohkVP7C0awWK Rdqev+mG3mOq1807VMYcQhUGLBlCYwVOGNOYtGNLjGQuIlN0cQ/u4JN3veExuvqD7BDR AIIudAb8hzETq6PXf4rrMPyp+X1Sdityk8cED4+ry00dU3ner0HmgunrQ0rAAaduU1ww 8NESqpfusXX2QDUQJaNYHwCxwaj0G1ggEjsm2j5unfuLQDIF0443zj2tcA0ciPD4D4ES c8nw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=v6A8lkGT7qlDfG5OHFA7dTWCjZVRjtLZtjsAR4wx34Y=; b=WUvGL6xE/pHaHH9mqLeI6VT5zG3pWnuRDuXEtbkgLGBJw7qKO9XBCZeiCs7SEHEDVi g8gIgcf8rbsfQwHSM20umNKeeQ19+EfyhDKZZOlBnRPn+6nPSlhwkQLtQkXR66VwvVfO p1ukoWEBNGk7T3b9pYHfDWUexWA+VmKRVIqvByrVu5vsz78HKRKIY2DkPIz9eWfRGaBj i8S7fwNADg4uuBFiWXsEf7PSZkH1FjR2hY58L5zVRON8jVA9FXXtfJzJ/sU4N/237hn+ feFXq9HTUAPa9wI5gLf5bNi60l6hbGedObzZT8xfWNF7SCLIxfSzZTdwlYnOHQmAhbnY D2Fw== X-Gm-Message-State: AOAM533qmcWbtiGBvLD2e7L5AYhk7XF3eLx7bVg/DL3oGiiJMvjZWxC1 gJzfUOlOQrJXkNm/zWn0wSi3P8ZcdENSsIRw1gU= X-Google-Smtp-Source: ABdhPJxMqjp3WRvYACSDA9CGb4Oltl2JpPqKhGqAKCml3IGmC6SV9SabeXywKUP5qljAGJbNZQYUbFqOZS08vWp6gWA= X-Received: by 2002:a17:90a:b311:: with SMTP id d17mr26467330pjr.228.1617014400860; Mon, 29 Mar 2021 03:40:00 -0700 (PDT) MIME-Version: 1.0 References: <20210304034141.7062-1-brad@pensando.io> <20210304034141.7062-2-brad@pensando.io> In-Reply-To: From: Andy Shevchenko Date: Mon, 29 Mar 2021 13:39:44 +0300 Message-ID: Subject: Re: [PATCH 1/8] gpio: Add Elba SoC gpio driver for spi cs control To: Brad Larson Cc: linux-arm Mailing List , Arnd Bergmann , Linus Walleij , Bartosz Golaszewski , Mark Brown , Serge Semin , Adrian Hunter , Ulf Hansson , Olof Johansson , "open list:GPIO SUBSYSTEM" , linux-spi , linux-mmc , devicetree , Linux Kernel Mailing List Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-gpio@vger.kernel.org On Mon, Mar 29, 2021 at 4:19 AM Brad Larson wrote: > On Sun, Mar 7, 2021 at 11:21 AM Andy Shevchenko > wrote: > > On Thu, Mar 4, 2021 at 4:40 PM Brad Larson wrote: ... > > > +config GPIO_ELBA_SPICS > > > + bool "Pensando Elba SPI chip-select" > > > > Can't it be a module? Why? > > All Elba SoC based platforms require this driver to be built-in to boot and > removing the module would result in a variety of exceptions/errors. Needs to be at least in the commit message. > > > + depends on ARCH_PENSANDO_ELBA_SOC > > > + help > > > + Say yes here to support the Pensndo Elba SoC SPI chip-select driver > > > > Please give more explanation what it is and why users might need it, > > and also tell users how the module will be named (if there is no > > strong argument why it can't be a module). > > > Fixed the typo. Yeah, according to the above, you better elaborate what this module is and why people would need it. Also can be a good hint to add default ARCH_MY_COOL_PLATFORM ... > > > +#include > > > > It's not used here, but you missed mod_devicetable.h. > > Removed . There is no dependency on mod_devicetable.h. What do you mean? You don't use data structures from that? of_device_id or other ID structures are defined there. Your module works without them? ... > > > + res = platform_get_resource(pdev, IORESOURCE_MEM, 0); > > > + p->base = devm_ioremap_resource(&pdev->dev, res); > > > > p->base = devm_platform_ioremap_resource(pdev, 0); > > Implementation follows devm_ioremap_resource() example in lib/devres.c. So? How does this make it impossible to address my comment? > > > + if (IS_ERR(p->base)) { > > > > > + dev_err(&pdev->dev, "failed to remap I/O memory\n"); > > > > Duplicate noisy message. > > > > > + return PTR_ERR(p->base); > > > + } -- With Best Regards, Andy Shevchenko From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.7 required=3.0 tests=BAYES_00,DKIM_ADSP_CUSTOM_MED, DKIM_SIGNED,DKIM_VALID,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 933A9C433C1 for ; Mon, 29 Mar 2021 18:40:03 +0000 (UTC) Received: from desiato.infradead.org (desiato.infradead.org [90.155.92.199]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id D22C461989 for ; Mon, 29 Mar 2021 18:40:02 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org D22C461989 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=desiato.20200630; h=Sender:Content-Transfer-Encoding :Content-Type:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:Cc:To:Subject:Message-ID:Date:From:In-Reply-To: References:MIME-Version:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=wkjr/558sHR89p2jT8+Lj/JEIWQJ8D+/r2HI5kP1K04=; b=Fo+8GffjzNl8Np//PxF2y7u+F /yEBUU+dANJfVft3rBCtnVSgB76SI7NET+KcIZ31cXVJNtod0m58MempcgvpeSQMj9yGtiPHpC+JS B+H6jqleNiODu0V6/y7zzS1Mru9AUSdYHA1t52lW7Q/42+Te/9Q3ecAa524QMk1KEAa8II+n+uBzl LY00aGYZs0anXJ/QMkEHlupYPOjU5PhDfnln25OPTOlrfNtd4P64vrFQ8EmlnvXyePcMWJ3Hu/IAS shbvvT7/CcRlQPQxlosc3TUhPzrxyfU6vvdk07y+V66TBRic5rfaMa9Lbj99jIfBtHBrqXSeI2HHD Kj68gNxIA==; Received: from localhost ([::1] helo=desiato.infradead.org) by desiato.infradead.org with esmtp (Exim 4.94 #2 (Red Hat Linux)) id 1lQwjP-0014j1-Dn; Mon, 29 Mar 2021 18:35:21 +0000 Received: from mail-pj1-x102f.google.com ([2607:f8b0:4864:20::102f]) by desiato.infradead.org with esmtps (Exim 4.94 #2 (Red Hat Linux)) id 1lQpJS-000af2-Sh for linux-arm-kernel@lists.infradead.org; Mon, 29 Mar 2021 10:40:04 +0000 Received: by mail-pj1-x102f.google.com with SMTP id w8so5788455pjf.4 for ; Mon, 29 Mar 2021 03:40:02 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=v6A8lkGT7qlDfG5OHFA7dTWCjZVRjtLZtjsAR4wx34Y=; b=o15S4Oc4W6Wisr5EVArkn/MoM98iA9zt3Z7a9BPfcrkZuwq/IjnGzlwFxOZELQiVxv 4uP8RbtXTVyaYb7xFT5oVNy8SwZ1kxh8r/wb10klTriK+oztFTTMOMBpohkVP7C0awWK Rdqev+mG3mOq1807VMYcQhUGLBlCYwVOGNOYtGNLjGQuIlN0cQ/u4JN3veExuvqD7BDR AIIudAb8hzETq6PXf4rrMPyp+X1Sdityk8cED4+ry00dU3ner0HmgunrQ0rAAaduU1ww 8NESqpfusXX2QDUQJaNYHwCxwaj0G1ggEjsm2j5unfuLQDIF0443zj2tcA0ciPD4D4ES c8nw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=v6A8lkGT7qlDfG5OHFA7dTWCjZVRjtLZtjsAR4wx34Y=; b=jhx9pQLZREFovUSuxoXeA62bbCKa5S8IbsaRpavfSwB4yGq1xREbneJQv2hCruJHCJ z/nOrK2UaaPyapurcwyXd9kQeNiACeeRMiDjEK7iPd80FuBsJL557RdNPrGoFErMRyzB OoL+zsHqqcdNK3Fua0uETSCj4YQIHIXBNa25ZPS+eBeA7isF03rbj5Tg1cELlZhxn0IY usD3AM3KmjNMkE5Bi9LQ7J4kPI99+Jp1Fdxm/bwKPQ25fmIV3VSCX30oLbGRER2zieyk qGqIRZ7aX9SdxaxAZ46AmvSPRaL4X+pqdccenOAO76CkqUvvOjJzvd/0f0ZrObyYDaXD aaQQ== X-Gm-Message-State: AOAM5311Mh6Z5jsYDPdYkkO4oRxvnhGkj0buGh3/OeeFRdDs8Vh2syXS QXZ2GXSWNIbkiIwlNGFvUBChne72DRyGxGS0Oek= X-Google-Smtp-Source: ABdhPJxMqjp3WRvYACSDA9CGb4Oltl2JpPqKhGqAKCml3IGmC6SV9SabeXywKUP5qljAGJbNZQYUbFqOZS08vWp6gWA= X-Received: by 2002:a17:90a:b311:: with SMTP id d17mr26467330pjr.228.1617014400860; Mon, 29 Mar 2021 03:40:00 -0700 (PDT) MIME-Version: 1.0 References: <20210304034141.7062-1-brad@pensando.io> <20210304034141.7062-2-brad@pensando.io> In-Reply-To: From: Andy Shevchenko Date: Mon, 29 Mar 2021 13:39:44 +0300 Message-ID: Subject: Re: [PATCH 1/8] gpio: Add Elba SoC gpio driver for spi cs control To: Brad Larson Cc: linux-arm Mailing List , Arnd Bergmann , Linus Walleij , Bartosz Golaszewski , Mark Brown , Serge Semin , Adrian Hunter , Ulf Hansson , Olof Johansson , "open list:GPIO SUBSYSTEM" , linux-spi , linux-mmc , devicetree , Linux Kernel Mailing List X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210329_114002_995702_89D76585 X-CRM114-Status: GOOD ( 26.95 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Mon, Mar 29, 2021 at 4:19 AM Brad Larson wrote: > On Sun, Mar 7, 2021 at 11:21 AM Andy Shevchenko > wrote: > > On Thu, Mar 4, 2021 at 4:40 PM Brad Larson wrote: ... > > > +config GPIO_ELBA_SPICS > > > + bool "Pensando Elba SPI chip-select" > > > > Can't it be a module? Why? > > All Elba SoC based platforms require this driver to be built-in to boot and > removing the module would result in a variety of exceptions/errors. Needs to be at least in the commit message. > > > + depends on ARCH_PENSANDO_ELBA_SOC > > > + help > > > + Say yes here to support the Pensndo Elba SoC SPI chip-select driver > > > > Please give more explanation what it is and why users might need it, > > and also tell users how the module will be named (if there is no > > strong argument why it can't be a module). > > > Fixed the typo. Yeah, according to the above, you better elaborate what this module is and why people would need it. Also can be a good hint to add default ARCH_MY_COOL_PLATFORM ... > > > +#include > > > > It's not used here, but you missed mod_devicetable.h. > > Removed . There is no dependency on mod_devicetable.h. What do you mean? You don't use data structures from that? of_device_id or other ID structures are defined there. Your module works without them? ... > > > + res = platform_get_resource(pdev, IORESOURCE_MEM, 0); > > > + p->base = devm_ioremap_resource(&pdev->dev, res); > > > > p->base = devm_platform_ioremap_resource(pdev, 0); > > Implementation follows devm_ioremap_resource() example in lib/devres.c. So? How does this make it impossible to address my comment? > > > + if (IS_ERR(p->base)) { > > > > > + dev_err(&pdev->dev, "failed to remap I/O memory\n"); > > > > Duplicate noisy message. > > > > > + return PTR_ERR(p->base); > > > + } -- With Best Regards, Andy Shevchenko _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel