From: Andy Shevchenko <andy.shevchenko@gmail.com>
To: Matthias Kaehlcke <mka@chromium.org>
Cc: Zha Qipeng <qipeng.zha@intel.com>,
Darren Hart <dvhart@infradead.org>,
Andy Shevchenko <andy@infradead.org>,
Alan Cox <gnomes@lxorguk.ukuu.org.uk>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
Platform Driver <platform-driver-x86@vger.kernel.org>,
Douglas Anderson <dianders@chromium.org>
Subject: Re: [PATCH] platform/x86: intel_pmc_ipc: Mark ipc_data_readb() as __maybe_unused
Date: Fri, 26 May 2017 12:53:52 +0300 [thread overview]
Message-ID: <CAHp75VdjrwYX72e87xKFzcdmhAd7=zZeKRU84zgBc3iNuKPXdQ@mail.gmail.com> (raw)
In-Reply-To: <20170525221510.41751-1-mka@chromium.org>
On Fri, May 26, 2017 at 1:15 AM, Matthias Kaehlcke <mka@chromium.org> wrote:
> The function is currently not used, however it is part of the API and
> might be used in the future. Adding the attribute fixes the following
> warning when building with clang:
>
> drivers/platform/x86/intel_pmc_ipc.c:189:18: error: unused function
> 'ipc_data_readb' [-Werror,-Wunused-function]
>
Pushed to testing, thanks!
> Signed-off-by: Matthias Kaehlcke <mka@chromium.org>
> ---
> drivers/platform/x86/intel_pmc_ipc.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/platform/x86/intel_pmc_ipc.c b/drivers/platform/x86/intel_pmc_ipc.c
> index e4d4dfe3e1d1..bb792a52248b 100644
> --- a/drivers/platform/x86/intel_pmc_ipc.c
> +++ b/drivers/platform/x86/intel_pmc_ipc.c
> @@ -186,7 +186,7 @@ static inline void ipc_data_writel(u32 data, u32 offset)
> writel(data, ipcdev.ipc_base + IPC_WRITE_BUFFER + offset);
> }
>
> -static inline u8 ipc_data_readb(u32 offset)
> +static inline u8 __maybe_unused ipc_data_readb(u32 offset)
> {
> return readb(ipcdev.ipc_base + IPC_READ_BUFFER + offset);
> }
> --
> 2.13.0.219.gdb65acc882-goog
>
--
With Best Regards,
Andy Shevchenko
prev parent reply other threads:[~2017-05-26 9:54 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-05-25 22:15 [PATCH] platform/x86: intel_pmc_ipc: Mark ipc_data_readb() as __maybe_unused Matthias Kaehlcke
2017-05-26 9:53 ` Andy Shevchenko [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAHp75VdjrwYX72e87xKFzcdmhAd7=zZeKRU84zgBc3iNuKPXdQ@mail.gmail.com' \
--to=andy.shevchenko@gmail.com \
--cc=andy@infradead.org \
--cc=dianders@chromium.org \
--cc=dvhart@infradead.org \
--cc=gnomes@lxorguk.ukuu.org.uk \
--cc=linux-kernel@vger.kernel.org \
--cc=mka@chromium.org \
--cc=platform-driver-x86@vger.kernel.org \
--cc=qipeng.zha@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.