Re: [PATCH V5 2/7] soc: qcom-geni-se: Add interconnect support to fix earlycon crash

[Andy Shevchenko <andy.shevchenko@gmail.com>]

On Fri, May 8, 2020 at 9:34 AM Akash Asthana <akashast@codeaurora.org> wrote:
>
> QUP core clock is shared among all the SE drivers present on particular
> QUP wrapper, the system will reset(unclocked access) if earlycon used after
> QUP core clock is put to 0 from other SE drivers before real console comes
> up.
>
> As earlycon can't vote for it's QUP core need, to fix this add ICC
> support to common/QUP wrapper driver and put vote for QUP core from
> probe on behalf of earlycon and remove vote during earlycon exit call.

...

> +       for_each_child_of_node(parent, child) {

> +               if (of_device_is_compatible(child, "qcom,geni-se-qup")) {

if (!...)
 continue;

will save you a readability of the loop body.

Or...

> +                       wrapper = platform_get_drvdata(of_find_device_by_node(
> +                                       child));

...leave this on one line

> +                       icc_put(wrapper->to_core.path);
> +                       wrapper->to_core.path = NULL;
> +               }

And here is the question, what do you want to do if you find more
devices with the same compatible string?

> +       }

-- 
With Best Regards,
Andy Shevchenko