From mboxrd@z Thu Jan 1 00:00:00 1970 From: Andy Shevchenko Subject: Re: [PATCH v2 2/9] dmapool: cleanup error messages Date: Fri, 3 Aug 2018 19:01:42 +0300 Message-ID: References: <7a943124-c65e-f0ed-cc5c-20b23f021505@cybernetics.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: iommu-bounces-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org Errors-To: iommu-bounces-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org To: Tony Battersby Cc: linux-scsi , Chaitra P B , Suganath Prabu Subramani , Sathya Prakash , Matthew Wilcox , linux-mm , iommu-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org, MPT-FusionLinux.pdl-dY08KVG/lbpWk0Htik3J/w@public.gmane.org, Christoph Hellwig List-Id: linux-scsi@vger.kernel.org On Fri, Aug 3, 2018 at 6:59 PM, Andy Shevchenko wrote: > On Fri, Aug 3, 2018 at 6:17 PM, Tony Battersby wrote: >> But then I decided to simplify it to just use dev_err(). I still have >> the old version. When I submit v3 of the patchset, which would you prefer? > > JFYI: git log --no-merges --grep 'NULL device \*' Example: commit b4ba97e76763c4e582e3af1079e220e93b1b0d76 Author: Chris Wilson Date: Fri Aug 19 08:37:50 2016 +0100 drm: Avoid calling dev_printk(.dev = NULL) > P.S. I already shared my opinion on this anyway. -- With Best Regards, Andy Shevchenko From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-ua0-f199.google.com (mail-ua0-f199.google.com [209.85.217.199]) by kanga.kvack.org (Postfix) with ESMTP id 9CF7F6B000A for ; Fri, 3 Aug 2018 12:01:45 -0400 (EDT) Received: by mail-ua0-f199.google.com with SMTP id z17-v6so2823733uap.5 for ; Fri, 03 Aug 2018 09:01:45 -0700 (PDT) Received: from mail-sor-f65.google.com (mail-sor-f65.google.com. [209.85.220.65]) by mx.google.com with SMTPS id i61-v6sor1914138uad.77.2018.08.03.09.01.43 for (Google Transport Security); Fri, 03 Aug 2018 09:01:43 -0700 (PDT) MIME-Version: 1.0 In-Reply-To: References: <7a943124-c65e-f0ed-cc5c-20b23f021505@cybernetics.com> From: Andy Shevchenko Date: Fri, 3 Aug 2018 19:01:42 +0300 Message-ID: Subject: Re: [PATCH v2 2/9] dmapool: cleanup error messages Content-Type: text/plain; charset="UTF-8" Sender: owner-linux-mm@kvack.org List-ID: To: Tony Battersby Cc: Matthew Wilcox , Christoph Hellwig , Marek Szyprowski , Sathya Prakash , Chaitra P B , Suganath Prabu Subramani , iommu@lists.linux-foundation.org, linux-mm , linux-scsi , MPT-FusionLinux.pdl@broadcom.com On Fri, Aug 3, 2018 at 6:59 PM, Andy Shevchenko wrote: > On Fri, Aug 3, 2018 at 6:17 PM, Tony Battersby wrote: >> But then I decided to simplify it to just use dev_err(). I still have >> the old version. When I submit v3 of the patchset, which would you prefer? > > JFYI: git log --no-merges --grep 'NULL device \*' Example: commit b4ba97e76763c4e582e3af1079e220e93b1b0d76 Author: Chris Wilson Date: Fri Aug 19 08:37:50 2016 +0100 drm: Avoid calling dev_printk(.dev = NULL) > P.S. I already shared my opinion on this anyway. -- With Best Regards, Andy Shevchenko