From: Andy Shevchenko <andy.shevchenko@gmail.com>
To: Eddie James <eajames@linux.ibm.com>
Cc: linux-iio <linux-iio@vger.kernel.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Lars-Peter Clausen <lars@metafoo.de>,
Jonathan Cameron <jic23@kernel.org>,
Joel Stanley <joel@jms.id.au>
Subject: Re: [PATCH v3 1/2] iio: pressure: dps310: Refactor startup procedure
Date: Wed, 25 May 2022 18:34:55 +0200 [thread overview]
Message-ID: <CAHp75VdmDWgCMDZMywhF0nSsR7HjYZj56jPtXw=43epBkniroA@mail.gmail.com> (raw)
In-Reply-To: <20220524201729.39503-2-eajames@linux.ibm.com>
On Tue, May 24, 2022 at 10:35 PM Eddie James <eajames@linux.ibm.com> wrote:
>
> Move the startup procedure into a function, and correct a missing
> check on the return code for writing the PRS_CFG register.
...
> +/*
> + * Some verions of chip will read temperatures in the ~60C range when
versions
of the chip(s)
> + * its actually ~20C. This is the manufacturer recommended workaround
it's
> + * to correct the issue. The registers used below are undocumented.
> + */
Yes, they are in the original code, but you may just fix while at it.
...
> + rc = dps310_temp_workaround(data);
> + if (rc < 0)
These ' < 0' parts are cargo cult, I believe.
That's why this makes code longer and confusing by "what is the
meaning of the positive values here?"
> + return rc;
> +
> + return 0;
That said,
return dps310_temp_workaround(data);
should suffice.
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2022-05-25 16:35 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-05-24 20:17 [PATCH v3 0/2] iio: pressure: dps310: Reset chip if MEAS_CFG is corrupt Eddie James
2022-05-24 20:17 ` [PATCH v3 1/2] iio: pressure: dps310: Refactor startup procedure Eddie James
2022-05-25 1:00 ` Joel Stanley
2022-05-25 16:34 ` Andy Shevchenko [this message]
2022-05-24 20:17 ` [PATCH v3 2/2] iio: pressure: dps310: Reset chip if MEAS_CFG is corrupt Eddie James
2022-05-25 0:59 ` Joel Stanley
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAHp75VdmDWgCMDZMywhF0nSsR7HjYZj56jPtXw=43epBkniroA@mail.gmail.com' \
--to=andy.shevchenko@gmail.com \
--cc=eajames@linux.ibm.com \
--cc=jic23@kernel.org \
--cc=joel@jms.id.au \
--cc=lars@metafoo.de \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.