From mboxrd@z Thu Jan 1 00:00:00 1970 From: Andy Shevchenko Subject: Re: [patch V3 05/20] acpi: Remove header dependency Date: Sat, 21 Mar 2020 14:23:58 +0200 Message-ID: References: <20200321112544.878032781@linutronix.de> <20200321113241.246190285@linutronix.de> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Return-path: In-Reply-To: <20200321113241.246190285@linutronix.de> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: linuxppc-dev-bounces+glppe-linuxppc-embedded-2=m.gmane-mx.org@lists.ozlabs.org Sender: "Linuxppc-dev" To: Thomas Gleixner Cc: USB , linux-ia64@vger.kernel.org, Peter Zijlstra , linux-pci@vger.kernel.org, Sebastian Siewior , Oleg Nesterov , Guo Ren , Joel Fernandes , Vincent Chen , Ingo Molnar , Davidlohr Bueso , kbuild test robot , Brian Cain , Jonathan Corbet , "Paul E . McKenney" , linux-hexagon@vger.kernel.org, "Rafael J. Wysocki" , linux-csky@vger.kernel.org, ACPI Devel Maling List , Darren Hart , Zhang Rui , Len Brown , Fenghua Yu , Randy Dunlap , Arnd Bergmann List-Id: platform-driver-x86.vger.kernel.org On Sat, Mar 21, 2020 at 1:34 PM Thomas Gleixner wrote: > > From: Peter Zijlstra > > In order to avoid future header hell, remove the inclusion of > proc_fs.h from acpi_bus.h. All it needs is a forward declaration of a > struct. > Acked-by: Andy Shevchenko # for PDx86 > Signed-off-by: Peter Zijlstra (Intel) > Signed-off-by: Thomas Gleixner > Cc: Darren Hart > Cc: Andy Shevchenko > Cc: platform-driver-x86@vger.kernel.org > Cc: Greg Kroah-Hartman > Cc: Zhang Rui > Cc: "Rafael J. Wysocki" > Cc: linux-pm@vger.kernel.org > Cc: Len Brown > Cc: linux-acpi@vger.kernel.org > --- > drivers/platform/x86/dell-smo8800.c | 1 + > drivers/platform/x86/wmi.c | 1 + > drivers/thermal/intel/int340x_thermal/acpi_thermal_rel.c | 1 + > include/acpi/acpi_bus.h | 2 +- > 4 files changed, 4 insertions(+), 1 deletion(-) > > --- a/drivers/platform/x86/dell-smo8800.c > +++ b/drivers/platform/x86/dell-smo8800.c > @@ -16,6 +16,7 @@ > #include > #include > #include > +#include > > struct smo8800_device { > u32 irq; /* acpi device irq */ > --- a/drivers/platform/x86/wmi.c > +++ b/drivers/platform/x86/wmi.c > @@ -29,6 +29,7 @@ > #include > #include > #include > +#include > #include > > ACPI_MODULE_NAME("wmi"); > --- a/drivers/thermal/intel/int340x_thermal/acpi_thermal_rel.c > +++ b/drivers/thermal/intel/int340x_thermal/acpi_thermal_rel.c > @@ -19,6 +19,7 @@ > #include > #include > #include > +#include > #include "acpi_thermal_rel.h" > > static acpi_handle acpi_thermal_rel_handle; > --- a/include/acpi/acpi_bus.h > +++ b/include/acpi/acpi_bus.h > @@ -80,7 +80,7 @@ bool acpi_dev_present(const char *hid, c > > #ifdef CONFIG_ACPI > > -#include > +struct proc_dir_entry; > > #define ACPI_BUS_FILE_ROOT "acpi" > extern struct proc_dir_entry *acpi_root_dir; > > -- With Best Regards, Andy Shevchenko From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.5 required=3.0 tests=DKIM_ADSP_CUSTOM_MED, DKIM_INVALID,DKIM_SIGNED,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 32D54C4332B for ; Sat, 21 Mar 2020 12:41:16 +0000 (UTC) Received: from lists.ozlabs.org (lists.ozlabs.org [203.11.71.2]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id CADB620757 for ; Sat, 21 Mar 2020 12:41:15 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="guZnHeGo" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org CADB620757 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=linuxppc-dev-bounces+linuxppc-dev=archiver.kernel.org@lists.ozlabs.org Received: from lists.ozlabs.org (lists.ozlabs.org [IPv6:2401:3900:2:1::3]) by lists.ozlabs.org (Postfix) with ESMTP id 48l0cn5KbCzDrnl for ; Sat, 21 Mar 2020 23:41:13 +1100 (AEDT) Authentication-Results: lists.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=gmail.com (client-ip=2607:f8b0:4864:20::442; helo=mail-pf1-x442.google.com; envelope-from=andy.shevchenko@gmail.com; receiver=) Authentication-Results: lists.ozlabs.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: lists.ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256 header.s=20161025 header.b=guZnHeGo; dkim-atps=neutral Received: from mail-pf1-x442.google.com (mail-pf1-x442.google.com [IPv6:2607:f8b0:4864:20::442]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 48l0FC2VGBzDrSK for ; Sat, 21 Mar 2020 23:24:14 +1100 (AEDT) Received: by mail-pf1-x442.google.com with SMTP id b72so4754255pfb.11 for ; Sat, 21 Mar 2020 05:24:14 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=Ao4Jy8e8i2H3r6C7mhPUev+j75PjWe4TRVOreHP2VzM=; b=guZnHeGo0HvHKP2uIKtZiCtNOUIkrUT7OLzB66Ehtw0EiRz0K0c6LtX4CWuNZp6QIL YrUqqmUsqOQIHILQRs1SrnxRO54uRVwILm5bNdlpUGX6dcExdOPMfmuKHkPcvMtu6WbT /P7MLfISznzr7ogM6J98U4cpx8/lCga6dEpI2eG7/1joslz9HVe0MCBWrJjlYlA5S7Mc eufctIYPsclmo3tJk89MVDURTNM43DP4w2vS8LbbG17swocgZVGzaGEA17iUCtLk8pQy WDK9dsn4zUgoCJeFNLPI823x3rR/fKz2B+dGyCO9zePvxDJWWT98LbXkAlCqWcnM1iF7 hq3A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=Ao4Jy8e8i2H3r6C7mhPUev+j75PjWe4TRVOreHP2VzM=; b=Zf127xze9yTIaTWyxZ/S5TnomtPQpg26mKg+kqtQQDwZ3dZ5Nt/RBc5au8v1CdC7Sh Hrf78J1vFE2nGPX/LIOWBeyTk4+zPiU1iWtteCTJ6Lx7jTxF0mLlLq0nqs2zIei1xQ7D SLalguXy8V/8ZIvV0djZ42WCGemGsKLM9esB09f0WmkRar7joJujcGigP6t60f/YA0G3 nzaGxHKQI8l2dVRtjiyZY1HzdFuJNfaHCJ8Pq0EOUzA9nNdEMDJr/ZIBHX1A0LeSyRzF qjM8+INnXjPb1Pkg03ZEbYy9XJJfc6b2uPt+JJ2B6dFQaqIBuI9oC9bkRMQ75MXEcxZ2 L6Zw== X-Gm-Message-State: ANhLgQ0cguxeYtuYj4od6Oh9uhUfrQUHSIWq+k6EtLRxUvADsUVsLR5t vTpiscdyI91srm/RfO89uU8hFg49oR3YHApIkX0= X-Google-Smtp-Source: ADFU+vt9Uo865ldMhbCuXqa1losEi96vNHQ702LMl19aMUCd3u8qFTNaK8m+H4VKt7G9g6ODyA9ZVzAxynAs7rQFJOc= X-Received: by 2002:a05:6a00:2b4:: with SMTP id q20mr3102817pfs.36.1584793451157; Sat, 21 Mar 2020 05:24:11 -0700 (PDT) MIME-Version: 1.0 References: <20200321112544.878032781@linutronix.de> <20200321113241.246190285@linutronix.de> In-Reply-To: <20200321113241.246190285@linutronix.de> From: Andy Shevchenko Date: Sat, 21 Mar 2020 14:23:58 +0200 Message-ID: Subject: Re: [patch V3 05/20] acpi: Remove header dependency To: Thomas Gleixner Content-Type: text/plain; charset="UTF-8" X-BeenThere: linuxppc-dev@lists.ozlabs.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: USB , linux-ia64@vger.kernel.org, Peter Zijlstra , linux-pci@vger.kernel.org, Sebastian Siewior , Oleg Nesterov , Guo Ren , Joel Fernandes , Vincent Chen , Ingo Molnar , Davidlohr Bueso , kbuild test robot , Brian Cain , Jonathan Corbet , "Paul E . McKenney" , linux-hexagon@vger.kernel.org, "Rafael J. Wysocki" , linux-csky@vger.kernel.org, ACPI Devel Maling List , Darren Hart , Zhang Rui , Len Brown , Fenghua Yu , Randy Dunlap , Arnd Bergmann , Linux PM , "open list:LINUX FOR POWERPC PA SEMI PWRFICIENT" , Greentime Hu , Bjorn Helgaas , Kurt Schwemmer , Platform Driver , Kalle Valo , Felipe Balbi , Michal Simek , Tony Luck , Nick Hu , Geoff Levand , Greg Kroah-Hartman , Linus Torvalds , "open list:TI WILINK WIRELES..." , LKML , Davidlohr Bueso , netdev , Logan Gunthorpe , "David S. Miller" , Andy Shevchenko Errors-To: linuxppc-dev-bounces+linuxppc-dev=archiver.kernel.org@lists.ozlabs.org Sender: "Linuxppc-dev" On Sat, Mar 21, 2020 at 1:34 PM Thomas Gleixner wrote: > > From: Peter Zijlstra > > In order to avoid future header hell, remove the inclusion of > proc_fs.h from acpi_bus.h. All it needs is a forward declaration of a > struct. > Acked-by: Andy Shevchenko # for PDx86 > Signed-off-by: Peter Zijlstra (Intel) > Signed-off-by: Thomas Gleixner > Cc: Darren Hart > Cc: Andy Shevchenko > Cc: platform-driver-x86@vger.kernel.org > Cc: Greg Kroah-Hartman > Cc: Zhang Rui > Cc: "Rafael J. Wysocki" > Cc: linux-pm@vger.kernel.org > Cc: Len Brown > Cc: linux-acpi@vger.kernel.org > --- > drivers/platform/x86/dell-smo8800.c | 1 + > drivers/platform/x86/wmi.c | 1 + > drivers/thermal/intel/int340x_thermal/acpi_thermal_rel.c | 1 + > include/acpi/acpi_bus.h | 2 +- > 4 files changed, 4 insertions(+), 1 deletion(-) > > --- a/drivers/platform/x86/dell-smo8800.c > +++ b/drivers/platform/x86/dell-smo8800.c > @@ -16,6 +16,7 @@ > #include > #include > #include > +#include > > struct smo8800_device { > u32 irq; /* acpi device irq */ > --- a/drivers/platform/x86/wmi.c > +++ b/drivers/platform/x86/wmi.c > @@ -29,6 +29,7 @@ > #include > #include > #include > +#include > #include > > ACPI_MODULE_NAME("wmi"); > --- a/drivers/thermal/intel/int340x_thermal/acpi_thermal_rel.c > +++ b/drivers/thermal/intel/int340x_thermal/acpi_thermal_rel.c > @@ -19,6 +19,7 @@ > #include > #include > #include > +#include > #include "acpi_thermal_rel.h" > > static acpi_handle acpi_thermal_rel_handle; > --- a/include/acpi/acpi_bus.h > +++ b/include/acpi/acpi_bus.h > @@ -80,7 +80,7 @@ bool acpi_dev_present(const char *hid, c > > #ifdef CONFIG_ACPI > > -#include > +struct proc_dir_entry; > > #define ACPI_BUS_FILE_ROOT "acpi" > extern struct proc_dir_entry *acpi_root_dir; > > -- With Best Regards, Andy Shevchenko