From mboxrd@z Thu Jan 1 00:00:00 1970 From: Andy Shevchenko Subject: Re: [PATCH 3/9] pinctrl: Combine five seq_printf() calls into one call in pinconf_dbg_config_print() Date: Wed, 3 May 2017 20:48:17 +0300 Message-ID: References:

Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Return-path: Received: from mail-qk0-f176.google.com ([209.85.220.176]:36124 "EHLO mail-qk0-f176.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753869AbdECRsS (ORCPT ); Wed, 3 May 2017 13:48:18 -0400 In-Reply-To: Sender: linux-gpio-owner@vger.kernel.org List-Id: linux-gpio@vger.kernel.org To: SF Markus Elfring Cc: "linux-gpio@vger.kernel.org" , Linus Walleij , LKML , kernel-janitors@vger.kernel.org On Tue, May 2, 2017 at 12:23 PM, SF Markus Elfring wrote: > From: Markus Elfring > Date: Mon, 1 May 2017 22:52:29 +0200 > > Some data were put into a sequence by five separate function calls. > Print the same data by a single function call instead. > - seq_printf(s, "No config found for dev/state/pin, expected:\n"); > - seq_printf(s, "Searched dev:%s\n", dbg->dev_name); > - seq_printf(s, "Searched state:%s\n", dbg->state_name); > - seq_printf(s, "Searched pin:%s\n", dbg->pin_name); > - seq_printf(s, "Use: modify config_pin "\ > - " \n"); > + seq_printf(s, > + "No config found for dev/state/pin, expected:\n" > + "Searched dev:%s\n" > + "Searched state:%s\n" > + "Searched pin:%s\n" > + "Use: modify config_pin \n", > + dbg->dev_name, > + dbg->state_name, > + dbg->pin_name); Please, no. -- With Best Regards, Andy Shevchenko From mboxrd@z Thu Jan 1 00:00:00 1970 From: Andy Shevchenko Date: Wed, 03 May 2017 17:48:17 +0000 Subject: Re: [PATCH 3/9] pinctrl: Combine five seq_printf() calls into one call in pinconf_dbg_config_print() Message-Id: List-Id: References:

In-Reply-To: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: SF Markus Elfring Cc: "linux-gpio@vger.kernel.org" , Linus Walleij , LKML , kernel-janitors@vger.kernel.org On Tue, May 2, 2017 at 12:23 PM, SF Markus Elfring wrote: > From: Markus Elfring > Date: Mon, 1 May 2017 22:52:29 +0200 > > Some data were put into a sequence by five separate function calls. > Print the same data by a single function call instead. > - seq_printf(s, "No config found for dev/state/pin, expected:\n"); > - seq_printf(s, "Searched dev:%s\n", dbg->dev_name); > - seq_printf(s, "Searched state:%s\n", dbg->state_name); > - seq_printf(s, "Searched pin:%s\n", dbg->pin_name); > - seq_printf(s, "Use: modify config_pin "\ > - " \n"); > + seq_printf(s, > + "No config found for dev/state/pin, expected:\n" > + "Searched dev:%s\n" > + "Searched state:%s\n" > + "Searched pin:%s\n" > + "Use: modify config_pin \n", > + dbg->dev_name, > + dbg->state_name, > + dbg->pin_name); Please, no. -- With Best Regards, Andy Shevchenko