From: Andy Shevchenko <andy.shevchenko@gmail.com>
To: Ritesh Raj Sarraf <rrs@debian.org>
Cc: Platform Driver <platform-driver-x86@vger.kernel.org>,
Darren Hart <dvhart@infradead.org>,
Ike Panhc <ike.pan@canonical.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v4] platform/x86: ideapad-laptop: Add sysfs interface for touchpad state
Date: Sun, 30 Apr 2017 15:54:43 +0300 [thread overview]
Message-ID: <CAHp75Vds7Vc3aJWpOO8uqo-y+PzUO+PNrhsjnHxGRs4WXt935A@mail.gmail.com> (raw)
In-Reply-To: <1493448775.9725.5.camel@debian.org>
On Sat, Apr 29, 2017 at 9:52 AM, Ritesh Raj Sarraf <rrs@debian.org> wrote:
> Hello,
>
> On Fri, 2017-04-28 at 22:17 +0300, Andy Shevchenko wrote:
>> On Wed, Feb 22, 2017 at 12:24 PM, Ritesh Raj Sarraf <rrs@debian.org> wrote:
>>
>> > Any further comment on this patch ? Will this be accepted ?
>> > Please give a N/ACK.
>>
>> Sorry for a long delay, but I can't go with this without clear
>> understanding that there is indeed no other ways available.
>> From what I read in the above link
>
> i am assuming you are referring to the launchpad bug report here.
Correct.
>> the main issue that driver doesn't
>> send SW_TABLET_MODE event through input device.
>
> Well. Yes. That is one part. If SW_TABLET_MODE is done in the driver, much
> better. My patch was simply in line with some of the other drivers (hp-wmi and
> thinkpad_acpi) to get it working for Lenovo Yoga series.
sysfs ABI for drivers that provide input interface is quite strong for
my opinion. It means I'm not totally objecting, but I would accept it
if and only if there is nothing else could be done.
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2017-04-30 12:54 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-02-17 18:47 [PATCH v4] platform/x86: ideapad-laptop: Add sysfs interface for touchpad state Ritesh Raj Sarraf
2017-02-22 10:24 ` Ritesh Raj Sarraf
2017-03-01 23:16 ` Andy Shevchenko
2017-04-28 19:17 ` Andy Shevchenko
2017-04-28 19:17 ` Andy Shevchenko
2017-04-29 6:52 ` Ritesh Raj Sarraf
2017-04-30 12:54 ` Andy Shevchenko [this message]
2017-05-01 16:05 ` Darren Hart
2017-05-01 18:27 ` Ritesh Raj Sarraf
2017-05-01 19:16 ` Darren Hart
2017-05-03 14:36 ` Ritesh Raj Sarraf
2017-05-03 14:42 ` Andy Shevchenko
2017-05-03 16:11 ` Darren Hart
2017-05-07 11:36 ` Andy Shevchenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAHp75Vds7Vc3aJWpOO8uqo-y+PzUO+PNrhsjnHxGRs4WXt935A@mail.gmail.com \
--to=andy.shevchenko@gmail.com \
--cc=dvhart@infradead.org \
--cc=ike.pan@canonical.com \
--cc=linux-kernel@vger.kernel.org \
--cc=platform-driver-x86@vger.kernel.org \
--cc=rrs@debian.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.