From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 700DAC4708E for ; Sat, 29 May 2021 09:41:54 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 3F61F6124B for ; Sat, 29 May 2021 09:41:54 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229560AbhE2Jn3 (ORCPT ); Sat, 29 May 2021 05:43:29 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:58644 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229620AbhE2Jn1 (ORCPT ); Sat, 29 May 2021 05:43:27 -0400 Received: from mail-pg1-x52f.google.com (mail-pg1-x52f.google.com [IPv6:2607:f8b0:4864:20::52f]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 25026C061574; Sat, 29 May 2021 02:41:49 -0700 (PDT) Received: by mail-pg1-x52f.google.com with SMTP id 6so4410052pgk.5; Sat, 29 May 2021 02:41:49 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=BhmzpOge1ugSk/b76qU2OK3P2aRPPQAhF5XEsVbHEOQ=; b=jWnNbjNCBpqvtp3i0o1QlrRtBsElXIXxM1qT5bC8x3ntyAXoAEgIuL2s39KnbAB6ty qqHNm7KQypc4KlHN5TYbIP8UHN3whNnVQRUqemJY7aXnDyBQAtNQNh4M4V8fgM9RqITy VYm0H7RJNITZ+Uv6iXIZNQfLIIEzF7pn2fsDmmTE2IOONX43Ji6/uVZ1scbO+NSQZuF0 2pjF74bycvRGviW6R8n4yKxQ3gPZ0uT/7f9M00X1QlJtkyJgfngB7i88jOVQumnot7+7 j+1t+F/CDvOilk+XuvTx445nbuyAXUAUd2lnOZcVaLtxgPl18LQT5EQU2Q/X25Jrg7Et RmIw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=BhmzpOge1ugSk/b76qU2OK3P2aRPPQAhF5XEsVbHEOQ=; b=F/VP2muPLP9fBqXO9V5iKzUcPzNV2g9ygfnKWcQenagEjNZv/q+EK+1oxY/uINvnh6 GLUgL2UHQbrGV7HL4u6VvIGrVSls+Ii5wDB4ICBmW3GVzbZlH5b8nqo9H6sx+Z559WRj GCmAO1rvAVxxai/oNxjgxlIZ+YoO6e/tFzOeoPPmxRBVcusxZK4vW1m09mCFfrkGkGhR uRppcDBQSDxU5o4MJA2NtTWq1Xz8fo6mm//UBGq0oO+YIgDObSWIaviV51rSIe+RzwCF 75WegRLWm21fTygH9ImqEq+oMYaxOdOOsWv9BhjeEs2BljDtRqPMJEIU72Lbtfj1cqAu krLQ== X-Gm-Message-State: AOAM532BS8iDEeAYgyFwktvrfuzGZqJ03rbvksMewN5mG0IHGsFhKSc9 599EusQtIWLzXOaEmalOOWRmpxDIW8ZSapdT3QE= X-Google-Smtp-Source: ABdhPJxTpV1q70CkKdVXMWLe4tI2MuhERQRSKAD+XRBe7QrLK75mlvD14i4mHmFzQcFX5iABSjA78FUoaf4ty7YBkBU= X-Received: by 2002:a63:4145:: with SMTP id o66mr13231146pga.4.1622281308767; Sat, 29 May 2021 02:41:48 -0700 (PDT) MIME-Version: 1.0 References: <20210510095045.3299382-1-andy.shevchenko@gmail.com> <20210510095045.3299382-4-andy.shevchenko@gmail.com> <20210528100440.GE2209@amd> In-Reply-To: From: Andy Shevchenko Date: Sat, 29 May 2021 12:41:32 +0300 Message-ID: Subject: Re: [PATCH v1 03/28] leds: el15203000: Give better margin for usleep_range() To: Pavel Machek Cc: Amireddy Mallikarjuna reddy , Linus Walleij , =?UTF-8?B?TWFyZWsgQmVow7pu?= , Abanoub Sameh , Dan Murphy , Krzysztof Kozlowski , linux-leds@vger.kernel.org, linux-kernel@vger.kernel.org Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-leds@vger.kernel.org On Fri, May 28, 2021 at 1:46 PM Andy Shevchenko wrote: > > On Fri, May 28, 2021 at 12:04:40PM +0200, Pavel Machek wrote: > > On Mon 2021-05-10 12:50:20, Andy Shevchenko wrote: > > > 1 microsecond with 20 millisecond parameter is too low margin for > > > usleep_range(). Give 100 to make scheduler happier. > > > > > > While at it, fix indentation in cases where EL_FW_DELAY_USEC is in use. > > > In the loop, move it to the end to avoid a conditional. > > > > Its not like unhappy schedulers are problem... > > Any hints then? To me it sounds like torturing scheduler is the real problem > and that's why scheduler is unhappy. Okay, I have rephrased the commit message. -- With Best Regards, Andy Shevchenko