From: Andy Shevchenko <andy.shevchenko@gmail.com>
To: David Box <david.e.box@linux.intel.com>
Cc: Andy Shevchenko <andy@infradead.org>,
Rajneesh Bhardwaj <rajneesh.bhardwaj@intel.com>,
Vishwanath Somayaji <vishwanath.somayaji@intel.com>,
Darren Hart <dvhart@infradead.org>,
kyle.d.pelton@linux.intel.com,
Platform Driver <platform-driver-x86@vger.kernel.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH V2] platform/x86: intel_pmc_core: Add CNP SLPS0 debug registers
Date: Fri, 1 Jun 2018 11:25:03 +0300 [thread overview]
Message-ID: <CAHp75Vdxz2h1N_bLQ4wxrYoo-kRAHQK=+36Db0BfK1QR4iwVPw@mail.gmail.com> (raw)
In-Reply-To: <1527807882.10176.11.camel@linux.intel.com>
On Fri, Jun 1, 2018 at 2:04 AM, David E. Box
<david.e.box@linux.intel.com> wrote:
> On Thu, 2018-05-31 at 21:38 +0300, Andy Shevchenko wrote:
>> On Fri, May 25, 2018 at 4:10 AM, David E. Box
>> <david.e.box@linux.intel.com> wrote:
>> > +struct slps0_dbg_map {
>> > + const struct pmc_bit_map *slps0_dbg_sts;
>> > + int size;
>> > +};
>>
>> Didn't pay attention to this earlier. Why do we have a separate size
>> member? What does it define?
>
> It holds the size of the pmc_bit_map array, assigned as shown here:
>
> +static const struct slps0_dbg_map cnp_slps0_dbg_maps[] = {
> + {cnp_slps0_dbg0_map, ARRAY_SIZE(cnp_slps0_dbg0_map)},
> + {cnp_slps0_dbg1_map, ARRAY_SIZE(cnp_slps0_dbg1_map)},
> + {cnp_slps0_dbg2_map, ARRAY_SIZE(cnp_slps0_dbg2_map)},
> +};
I see.
Please drop this and use a terminator instead like it's done for the
rest map tables.
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2018-06-01 8:25 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <CAHp75VfLqvjVPwhcsK4enhsvXSLggX9_pO9AozZT56DWDrkjPg@mail.gmail.com>
2018-05-25 1:10 ` [PATCH V2] platform/x86: intel_pmc_core: Add CNP SLPS0 debug registers David E. Box
2018-05-28 7:00 ` Rajneesh Bhardwaj
2018-05-30 10:53 ` David E. Box
2018-05-30 11:33 ` Rajneesh Bhardwaj
2018-06-02 1:47 ` David E. Box
2018-05-31 18:38 ` Andy Shevchenko
2018-05-31 23:04 ` David E. Box
2018-06-01 8:25 ` Andy Shevchenko [this message]
2018-06-09 0:02 ` [V3] " Box, David E
2018-06-13 14:07 ` Rajneesh Bhardwaj
2018-06-13 16:40 ` Andy Shevchenko
2018-06-14 22:13 ` [PATCH V4] " David E. Box
2018-06-15 11:27 ` Rajneesh Bhardwaj
2018-07-02 12:19 ` Andy Shevchenko
2018-07-02 18:21 ` Rajneesh Bhardwaj
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAHp75Vdxz2h1N_bLQ4wxrYoo-kRAHQK=+36Db0BfK1QR4iwVPw@mail.gmail.com' \
--to=andy.shevchenko@gmail.com \
--cc=andy@infradead.org \
--cc=david.e.box@linux.intel.com \
--cc=dvhart@infradead.org \
--cc=kyle.d.pelton@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=platform-driver-x86@vger.kernel.org \
--cc=rajneesh.bhardwaj@intel.com \
--cc=vishwanath.somayaji@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.