From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7C842C433EF for ; Fri, 15 Jul 2022 13:06:22 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234402AbiGONGU (ORCPT ); Fri, 15 Jul 2022 09:06:20 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:45844 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230055AbiGONGT (ORCPT ); Fri, 15 Jul 2022 09:06:19 -0400 Received: from mail-yb1-xb2d.google.com (mail-yb1-xb2d.google.com [IPv6:2607:f8b0:4864:20::b2d]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id A468B3D599; Fri, 15 Jul 2022 06:06:17 -0700 (PDT) Received: by mail-yb1-xb2d.google.com with SMTP id 6so8329824ybc.8; Fri, 15 Jul 2022 06:06:17 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=cjk0QcLK7Qj7+zbxyz81ybo9xTsZsUl/7XEcNiCSZlk=; b=I/KxJOarbkD3CTr6bI1+GX+R+0NK3NiJOovyOkNmpfsXSDv2vhcKk5NI+vZftnkbGg MwrvPAOczLpV/PzuzznMkxCSxJ+6WcBxz2SeXhuGLsY0hH+bxgIA+vAWaqy8gXKWAq2A uzFOe2j4x3jy2QIvV7SK11B49LyIqafJ56HKzoiej9S7S0ggTmMqLI8tQrHvAJsSRq/z rNeHJ2pSwMUMYzeC8dNaH6ecQWQOtzNB7/eDnb0GxvTouw5w6xHmU0P81MLtH8ioFMQA fU5zDFovh6s+bvTishJ0zl5v/l4nnJ809RZNoyuqT7PXEo9cUMjGqySfB+fn2ERJmoLs 3duw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=cjk0QcLK7Qj7+zbxyz81ybo9xTsZsUl/7XEcNiCSZlk=; b=H5ztsXgtdPdhxjNfLlDvNXD2n7pVUmxlic9bMcioNNnGL3iAxoY2mKgsTvcAti25n3 SG5BqjPUl3V9/wfI50Kicyhq0/Vy1srtnht3X2lU/Bat8u8O149jfW6YFJ55fx/2+YtJ BAC/zgY8yCPwTlhlwaSoCoHkI6sDz7Rgi3KnRrh28QPfWC9X/1iJlkmG1AJx02gXwauA Rz2Q6YqM9UMph9pNwlERWYB8pUDckUuzsZ4lJW7ndNuweU4Mexjip5nzsu271O10jk4q YBEIGJY30cEajjc9/FQh0akSfEcmWaSrcFgTtXWlRMpiibN/jqFSZCUpVwompp9S9NtE V+UQ== X-Gm-Message-State: AJIora/zfuY0767eC++6t2Mqy1l+2KqJvtQoxIr6SYyFjwt/IpwTJWZx IuxZHqnBPKbC0gpAC9ChtW3hTsIpQ+HqZg5l/tc= X-Google-Smtp-Source: AGRyM1u3gUyh808T1Pv3+nx4gv3OvZpiRmNXNk53IV5K4A6JGQG9S+KaILzgC03cdHtsws8VU8kBi0pySHUZ77kiRtY= X-Received: by 2002:a05:6902:1143:b0:66e:eb08:4c23 with SMTP id p3-20020a056902114300b0066eeb084c23mr14488436ybu.570.1657890376848; Fri, 15 Jul 2022 06:06:16 -0700 (PDT) MIME-Version: 1.0 References: <20220715112607.591-1-peterwu.pub@gmail.com> <20220715112607.591-12-peterwu.pub@gmail.com> In-Reply-To: From: Andy Shevchenko Date: Fri, 15 Jul 2022 15:05:40 +0200 Message-ID: Subject: Re: [PATCH v5 11/13] leds: mt6370: Add MediaTek MT6370 current sink type LED Indicator support To: AngeloGioacchino Del Regno Cc: ChiaEn Wu , Lee Jones , Daniel Thompson , Jingoo Han , Pavel Machek , Rob Herring , Krzysztof Kozlowski , Matthias Brugger , Sebastian Reichel , Chunfeng Yun , Greg Kroah-Hartman , Jonathan Cameron , Lars-Peter Clausen , Liam Girdwood , Mark Brown , Guenter Roeck , "Krogerus, Heikki" , Helge Deller , ChiaEn Wu , Alice Chen , cy_huang , dri-devel , Linux LED Subsystem , devicetree , linux-arm Mailing List , "moderated list:ARM/Mediatek SoC support" , Linux Kernel Mailing List , Linux PM , USB , linux-iio , "open list:FRAMEBUFFER LAYER" , szuni chen Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-leds@vger.kernel.org On Fri, Jul 15, 2022 at 2:40 PM AngeloGioacchino Del Regno wrote: > Il 15/07/22 13:26, ChiaEn Wu ha scritto: ... > > +#define STATE_OFF 0 > > +#define STATE_KEEP 1 > > +#define STATE_ON 2 > > I propose, instead: > > enum mt6370_state { > STATE_OFF = 0, > STATE_KEEP, > STATE_ON, > STATE_MAX, Usually we don't put commas at the terminator entries. > }; -- With Best Regards, Andy Shevchenko From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id ACD71C433EF for ; Fri, 15 Jul 2022 13:07:37 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:Cc:To:Subject:Message-ID:Date:From: In-Reply-To:References:MIME-Version:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=XyUM/SXlBXgnIaGOjyv9bEznbtdWbrk30xHIxGmJ1wI=; b=L3mQGO1vWwDGoz /OvFgR1VMDga8Gu/zlA/AAka/4OWjo6Zh83y8eBvz5XSjFNSGMP4hiyYupmhojPD4V8g+mTRHQ2Eq +I2/SXOv3xB4MzmI74kXFj8FDyVnWnUEaIyiJ0DqgLsAAQbjxn+RW07uLS3QZQpNbevz3omCvV8yq 9xL7IjvsLHm5do1Wy1gmMn3n7epQtg02rOR2vuXRO9fplNB066tPN5mRjL+v8EFqF5eaHx1nBD/hX dSp3aE29HKlgAr6ouUpqFXHVB886JlV33odaKrhIsakBOK0tMHKuYF3xHHbePP2KpEVMdWI2go3FR 4gFpHbw2BO9X/blIruHQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1oCL1S-0079YQ-Ce; Fri, 15 Jul 2022 13:06:22 +0000 Received: from mail-yb1-xb2f.google.com ([2607:f8b0:4864:20::b2f]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1oCL1P-0079XO-By; Fri, 15 Jul 2022 13:06:20 +0000 Received: by mail-yb1-xb2f.google.com with SMTP id l11so8285678ybu.13; Fri, 15 Jul 2022 06:06:17 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=cjk0QcLK7Qj7+zbxyz81ybo9xTsZsUl/7XEcNiCSZlk=; b=I/KxJOarbkD3CTr6bI1+GX+R+0NK3NiJOovyOkNmpfsXSDv2vhcKk5NI+vZftnkbGg MwrvPAOczLpV/PzuzznMkxCSxJ+6WcBxz2SeXhuGLsY0hH+bxgIA+vAWaqy8gXKWAq2A uzFOe2j4x3jy2QIvV7SK11B49LyIqafJ56HKzoiej9S7S0ggTmMqLI8tQrHvAJsSRq/z rNeHJ2pSwMUMYzeC8dNaH6ecQWQOtzNB7/eDnb0GxvTouw5w6xHmU0P81MLtH8ioFMQA fU5zDFovh6s+bvTishJ0zl5v/l4nnJ809RZNoyuqT7PXEo9cUMjGqySfB+fn2ERJmoLs 3duw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=cjk0QcLK7Qj7+zbxyz81ybo9xTsZsUl/7XEcNiCSZlk=; b=Nm/gewXvykNDZbGgHSB8GeV0IqnsHKyeUJnXbPPN/n1potgF7bmcSesLhE38gzHyWk +JYHSnt31QfBxIBTzX6WquUckW8sGI87fHoOkSKQHXpfCVvvdELEo2IDk9bS6/iNIBK8 36jfZx61KYJbXzJq9yhh5DwZjk8anRjzH4d+qNU/KtEuQs61C5tsSNRTs56EhSvl5GmM UZQuf1m0am3Ry5Ta9DvRAgq8rmWswHieiyhbJaYhlMoiG46kFK55b+RcQqjZng0EIcS5 gDWxFq3VtD5hcSKl2s950qJ8/u3I8QOMCMxEgu6RljYakgNGf2qxi5A1DeX2AEcwAB81 yDDg== X-Gm-Message-State: AJIora/LuDUgrjbuxBMUMZ6rXO8J725bIC68+Z9qkhk0VTZ6Lp1WPFUA sarvk7GuYVsvx9QxQtPLL7VayfYrNGC9/zTDcvg= X-Google-Smtp-Source: AGRyM1u3gUyh808T1Pv3+nx4gv3OvZpiRmNXNk53IV5K4A6JGQG9S+KaILzgC03cdHtsws8VU8kBi0pySHUZ77kiRtY= X-Received: by 2002:a05:6902:1143:b0:66e:eb08:4c23 with SMTP id p3-20020a056902114300b0066eeb084c23mr14488436ybu.570.1657890376848; Fri, 15 Jul 2022 06:06:16 -0700 (PDT) MIME-Version: 1.0 References: <20220715112607.591-1-peterwu.pub@gmail.com> <20220715112607.591-12-peterwu.pub@gmail.com> In-Reply-To: From: Andy Shevchenko Date: Fri, 15 Jul 2022 15:05:40 +0200 Message-ID: Subject: Re: [PATCH v5 11/13] leds: mt6370: Add MediaTek MT6370 current sink type LED Indicator support To: AngeloGioacchino Del Regno Cc: ChiaEn Wu , Lee Jones , Daniel Thompson , Jingoo Han , Pavel Machek , Rob Herring , Krzysztof Kozlowski , Matthias Brugger , Sebastian Reichel , Chunfeng Yun , Greg Kroah-Hartman , Jonathan Cameron , Lars-Peter Clausen , Liam Girdwood , Mark Brown , Guenter Roeck , "Krogerus, Heikki" , Helge Deller , ChiaEn Wu , Alice Chen , cy_huang , dri-devel , Linux LED Subsystem , devicetree , linux-arm Mailing List , "moderated list:ARM/Mediatek SoC support" , Linux Kernel Mailing List , Linux PM , USB , linux-iio , "open list:FRAMEBUFFER LAYER" , szuni chen X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220715_060619_425557_8CFFC07B X-CRM114-Status: GOOD ( 10.77 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Fri, Jul 15, 2022 at 2:40 PM AngeloGioacchino Del Regno wrote: > Il 15/07/22 13:26, ChiaEn Wu ha scritto: ... > > +#define STATE_OFF 0 > > +#define STATE_KEEP 1 > > +#define STATE_ON 2 > > I propose, instead: > > enum mt6370_state { > STATE_OFF = 0, > STATE_KEEP, > STATE_ON, > STATE_MAX, Usually we don't put commas at the terminator entries. > }; -- With Best Regards, Andy Shevchenko _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 864DAC43334 for ; Sat, 16 Jul 2022 14:38:09 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id D1E2510F2C4; Sat, 16 Jul 2022 14:35:37 +0000 (UTC) Received: from mail-yb1-xb32.google.com (mail-yb1-xb32.google.com [IPv6:2607:f8b0:4864:20::b32]) by gabe.freedesktop.org (Postfix) with ESMTPS id E99F610E06A for ; Fri, 15 Jul 2022 15:00:08 +0000 (UTC) Received: by mail-yb1-xb32.google.com with SMTP id i206so8859722ybc.5 for ; Fri, 15 Jul 2022 08:00:08 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=cjk0QcLK7Qj7+zbxyz81ybo9xTsZsUl/7XEcNiCSZlk=; b=I/KxJOarbkD3CTr6bI1+GX+R+0NK3NiJOovyOkNmpfsXSDv2vhcKk5NI+vZftnkbGg MwrvPAOczLpV/PzuzznMkxCSxJ+6WcBxz2SeXhuGLsY0hH+bxgIA+vAWaqy8gXKWAq2A uzFOe2j4x3jy2QIvV7SK11B49LyIqafJ56HKzoiej9S7S0ggTmMqLI8tQrHvAJsSRq/z rNeHJ2pSwMUMYzeC8dNaH6ecQWQOtzNB7/eDnb0GxvTouw5w6xHmU0P81MLtH8ioFMQA fU5zDFovh6s+bvTishJ0zl5v/l4nnJ809RZNoyuqT7PXEo9cUMjGqySfB+fn2ERJmoLs 3duw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=cjk0QcLK7Qj7+zbxyz81ybo9xTsZsUl/7XEcNiCSZlk=; b=Q12AzoTR6/siLj8XuCBoRh/Zip30Ks3OGnnYHMB7uMxDwFwZkwmWpkKE0lEraO0ONl 2rls7Er/a1joZuEiSmXPln/klbd1rEaswwkVtZW723JPTD77urpLxDfOzwuHZOLmOpMz EUDoB2XXJaKZZx0e7GS+VA/w49nzRs8bWuPl5DCcaED7D/SYoWYUX6vQa7glJ6qpKsks 6e2aUbltffZZ6qsFs4GukbHKLNFndo9rpLqEpsJTVZKUElsaB+vG/x6nuMq9S0iruRev oNG1wctQwwrtz0w3CTb65b3dnXFIiOYXArPpK67zLLnDybxKMiW2r0MBjq6d48rRHpoT 7+vQ== X-Gm-Message-State: AJIora+0VM/5qnv7kEnCDPn7BpEIriOyEOinHrCtdRULKN2kJjbpDHRJ QsZ3n3XgcEKM0F2erUsSgbFJigeAb3GDBhg7PtJVdTyfLEI= X-Google-Smtp-Source: AGRyM1u3gUyh808T1Pv3+nx4gv3OvZpiRmNXNk53IV5K4A6JGQG9S+KaILzgC03cdHtsws8VU8kBi0pySHUZ77kiRtY= X-Received: by 2002:a05:6902:1143:b0:66e:eb08:4c23 with SMTP id p3-20020a056902114300b0066eeb084c23mr14488436ybu.570.1657890376848; Fri, 15 Jul 2022 06:06:16 -0700 (PDT) MIME-Version: 1.0 References: <20220715112607.591-1-peterwu.pub@gmail.com> <20220715112607.591-12-peterwu.pub@gmail.com> In-Reply-To: From: Andy Shevchenko Date: Fri, 15 Jul 2022 15:05:40 +0200 Message-ID: Subject: Re: [PATCH v5 11/13] leds: mt6370: Add MediaTek MT6370 current sink type LED Indicator support To: AngeloGioacchino Del Regno Content-Type: text/plain; charset="UTF-8" X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: "open list:FRAMEBUFFER LAYER" , "Krogerus, Heikki" , Pavel Machek , Alice Chen , linux-iio , dri-devel , Liam Girdwood , cy_huang , Krzysztof Kozlowski , Lee Jones , Linux LED Subsystem , Daniel Thompson , Helge Deller , Rob Herring , Chunfeng Yun , Guenter Roeck , devicetree , Linux PM , szuni chen , Mark Brown , "moderated list:ARM/Mediatek SoC support" , Matthias Brugger , ChiaEn Wu , linux-arm Mailing List , Jingoo Han , USB , Sebastian Reichel , Linux Kernel Mailing List , ChiaEn Wu , Greg Kroah-Hartman , Jonathan Cameron Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" On Fri, Jul 15, 2022 at 2:40 PM AngeloGioacchino Del Regno wrote: > Il 15/07/22 13:26, ChiaEn Wu ha scritto: ... > > +#define STATE_OFF 0 > > +#define STATE_KEEP 1 > > +#define STATE_ON 2 > > I propose, instead: > > enum mt6370_state { > STATE_OFF = 0, > STATE_KEEP, > STATE_ON, > STATE_MAX, Usually we don't put commas at the terminator entries. > }; -- With Best Regards, Andy Shevchenko