From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-12.7 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8D9D4C433DB for ; Mon, 28 Dec 2020 23:56:12 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 55C512075E for ; Mon, 28 Dec 2020 23:56:12 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729604AbgL1Xz4 (ORCPT ); Mon, 28 Dec 2020 18:55:56 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:37094 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729580AbgL1Xz4 (ORCPT ); Mon, 28 Dec 2020 18:55:56 -0500 Received: from mail-pf1-x434.google.com (mail-pf1-x434.google.com [IPv6:2607:f8b0:4864:20::434]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 22063C061796; Mon, 28 Dec 2020 15:55:16 -0800 (PST) Received: by mail-pf1-x434.google.com with SMTP id w6so7121749pfu.1; Mon, 28 Dec 2020 15:55:16 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=vMXcPyqogv+uoJYzhVOVnDAaZJOmErDohwQ6l3V0Tbg=; b=RCwxzjHgHRywdIjnZhfHqWQT88k6zkvKX7/pgZLdGjNj/hqXpZSJxxHzpffIWF/YMP MsAk01fhCsjBD2lJKQN3JYTB0LhDDy8S7pzJgUJwoDB38B2a0/CXPDr+DQ0aZLNu8UAr SrF5DqcHUQIGz+0z99sqk8sp/Y/2dlCvdJKiVV+gGTkX4qkrLyykJ69L2WoZk/K7kwxb vpU9/c5vHcBp9iRzwduHRTwayvWriDXBf0Amif2B14KYNOTr/XAR0M1hwY5XMjJiLRP2 eOZyRQynCBNuXz1oXtWtXJqG90WDqHNpICCyiHzhNBeU4tSBHr9i0j337HXoxKzV3Gp3 /HEA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=vMXcPyqogv+uoJYzhVOVnDAaZJOmErDohwQ6l3V0Tbg=; b=QTMmWjjON/n78wUSikhwJ62cFunaKZCqKsuBrSVO4j1PPduMqi/1WWb8cW2nbaOclF 56p1Ki/kn9xxhBjTpdo/BO9Hw9tx0fJxBkQMnxxX5ReSbcN1oHfs6Mr9E+Le2Dbwxrh3 CskM8+sLGSTahkjnfdCJEwE02YyAYMSRTyrcpUVbAeKHPdHgbDHqH35qfxJxFU9oA7GJ PcRNPG78yOxZlFYpIOjZlAU5L943/3hgpYNM/Ml+xgOV4fcqGq/yjJG1wsP8kPgBo8q7 /cFmlBg6PZ5WO+CWkI8T7aMsI44lQbhdPe0Km1qzIijEVL0E4VEiKQ5vKR/UAaKL7bPe n0Vg== X-Gm-Message-State: AOAM533F/8H25IFV7lUAo8s8lfQFB5GqPnbnUa6a0bVO2pNJMLDIBeRB XBc1Fp2NljXBM9LrYsIEpQU+bv4N286qFsw2Rw8= X-Google-Smtp-Source: ABdhPJxcIpwrhXTCnpSHYMrG7oyN/71F7WSecxf2mRW4vD9HklVZpmkRH89e6+SPSny/u87BGg+x3d2aAuPAG0PAwpc= X-Received: by 2002:a05:6a00:170a:b029:19d:afca:4704 with SMTP id h10-20020a056a00170ab029019dafca4704mr21836791pfc.7.1609199715686; Mon, 28 Dec 2020 15:55:15 -0800 (PST) MIME-Version: 1.0 References: <20201224010907.263125-1-djrscally@gmail.com> <20201224010907.263125-15-djrscally@gmail.com> <20201228170521.GZ26370@paasikivi.fi.intel.com> <2d37df3d-f04c-6679-6e27-6c7f82e9b158@gmail.com> <20201228225544.GH4077@smile.fi.intel.com> In-Reply-To: From: Andy Shevchenko Date: Tue, 29 Dec 2020 01:54:59 +0200 Message-ID: Subject: Re: [PATCH v3 14/14] ipu3-cio2: Add cio2-bridge to ipu3-cio2 driver To: Laurent Pinchart Cc: Daniel Scally , Sakari Ailus , Linux Kernel Mailing List , ACPI Devel Maling List , Linux Media Mailing List , devel@acpica.org, "Rafael J. Wysocki" , Len Brown , Greg Kroah-Hartman , Yong Zhi , Bingbu Cao , Tian Shu Qiu , Mauro Carvalho Chehab , Robert Moore , Erik Kaneda , Petr Mladek , Steven Rostedt , Sergey Senozhatsky , Rasmus Villemoes , Laurent Pinchart , Jacopo Mondi , kieran.bingham+renesas@ideasonboard.com, Hans Verkuil , Marco Felsch , niklas.soderlund+renesas@ragnatech.se, Steve Longerbeam , "Krogerus, Heikki" , Linus Walleij , Jordan Hand Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-acpi@vger.kernel.org On Tue, Dec 29, 2020 at 1:08 AM Laurent Pinchart wrote: > > On Tue, Dec 29, 2020 at 12:55:44AM +0200, Andy Shevchenko wrote: > > On Mon, Dec 28, 2020 at 10:37:38PM +0000, Daniel Scally wrote: > > > On 28/12/2020 17:05, Sakari Ailus wrote: ... > > > Which do you prefer? > > > > Actually ipu3-cio2.h misses a lot of inclusions (like mutex.h which I > > immediately noticed when scrolled over data types). > > Then ipu3-cio2.h should be fixed :-) Below is a draft patch (it is possible mangled, due to Gmail). Can you look at it and tell me what you think? I believe some headers can be removed, but I have no idea about header inclusion guarantees that v4l2 provides. >From 10fa6c7ff66ded35a246677ffe20c677e8453f5b3 Mon Sep 17 00:00:00 2001 From: Andy Shevchenko Date: Tue, 29 Dec 2020 01:42:03 +0200 Subject: [PATCH 1/1] media: ipu3-cio2: Add headers that ipu3-cio2.h is direct user of Add headers that ipu3-cio2.h is direct user of. Signed-off-by: Andy Shevchenko --- drivers/media/pci/intel/ipu3/ipu3-cio2.h | 21 +++++++++++++++++++++ 1 file changed, 21 insertions(+) diff --git a/drivers/media/pci/intel/ipu3/ipu3-cio2.h b/drivers/media/pci/intel/ipu3/ipu3-cio2.h index ccf0b85ae36f..9ea154c50ba1 100644 --- a/drivers/media/pci/intel/ipu3/ipu3-cio2.h +++ b/drivers/media/pci/intel/ipu3/ipu3-cio2.h @@ -4,8 +4,25 @@ #ifndef __IPU3_CIO2_H #define __IPU3_CIO2_H +#include +#include +#include +#include #include +#include + +#include + +#include +#include +#include +#include +#include +#include +#include +#include + #define CIO2_NAME "ipu3-cio2" #define CIO2_DEVICE_NAME "Intel IPU3 CIO2" #define CIO2_ENTITY_NAME "ipu3-csi2" @@ -325,6 +342,8 @@ struct csi2_bus_info { u32 lanes; }; +struct cio2_fbpt_entry; + struct cio2_queue { /* mutex to be used by vb2_queue */ struct mutex lock; @@ -355,6 +374,8 @@ struct cio2_queue { atomic_t bufs_queued; }; +struct pci_dev; + struct cio2_device { struct pci_dev *pci_dev; void __iomem *base; -- 2.29.2 -- With Best Regards, Andy Shevchenko From mboxrd@z Thu Jan 1 00:00:00 1970 Content-Type: multipart/mixed; boundary="===============5741618639821896545==" MIME-Version: 1.0 From: Andy Shevchenko Subject: [Devel] Re: [PATCH v3 14/14] ipu3-cio2: Add cio2-bridge to ipu3-cio2 driver Date: Mon, 28 Dec 2020 23:55:16 +0000 Message-ID: In-Reply-To: X+plTyUFhfHi7eIE@pendragon.ideasonboard.com List-ID: To: devel@acpica.org --===============5741618639821896545== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable On Tue, Dec 29, 2020 at 1:08 AM Laurent Pinchart wrote: > > On Tue, Dec 29, 2020 at 12:55:44AM +0200, Andy Shevchenko wrote: > > On Mon, Dec 28, 2020 at 10:37:38PM +0000, Daniel Scally wrote: > > > On 28/12/2020 17:05, Sakari Ailus wrote: ... > > > Which do you prefer? > > > > Actually ipu3-cio2.h misses a lot of inclusions (like mutex.h which I > > immediately noticed when scrolled over data types). > > Then ipu3-cio2.h should be fixed :-) Below is a draft patch (it is possible mangled, due to Gmail). Can you look at it and tell me what you think? I believe some headers can be removed, but I have no idea about header inclusion guarantees that v4l2 provides. >From 10fa6c7ff66ded35a246677ffe20c677e8453f5b3 Mon Sep 17 00:00:00 2001 From: Andy Shevchenko Date: Tue, 29 Dec 2020 01:42:03 +0200 Subject: [PATCH 1/1] media: ipu3-cio2: Add headers that ipu3-cio2.h is dire= ct user of Add headers that ipu3-cio2.h is direct user of. Signed-off-by: Andy Shevchenko --- drivers/media/pci/intel/ipu3/ipu3-cio2.h | 21 +++++++++++++++++++++ 1 file changed, 21 insertions(+) diff --git a/drivers/media/pci/intel/ipu3/ipu3-cio2.h b/drivers/media/pci/intel/ipu3/ipu3-cio2.h index ccf0b85ae36f..9ea154c50ba1 100644 --- a/drivers/media/pci/intel/ipu3/ipu3-cio2.h +++ b/drivers/media/pci/intel/ipu3/ipu3-cio2.h @@ -4,8 +4,25 @@ #ifndef __IPU3_CIO2_H #define __IPU3_CIO2_H +#include +#include +#include +#include #include +#include + +#include + +#include +#include +#include +#include +#include +#include +#include +#include + #define CIO2_NAME "ipu3-cio2" #define CIO2_DEVICE_NAME "Intel IPU3 CIO2" #define CIO2_ENTITY_NAME "ipu3-csi2" @@ -325,6 +342,8 @@ struct csi2_bus_info { u32 lanes; }; +struct cio2_fbpt_entry; + struct cio2_queue { /* mutex to be used by vb2_queue */ struct mutex lock; @@ -355,6 +374,8 @@ struct cio2_queue { atomic_t bufs_queued; }; +struct pci_dev; + struct cio2_device { struct pci_dev *pci_dev; void __iomem *base; -- = 2.29.2 -- = With Best Regards, Andy Shevchenko --===============5741618639821896545==--