From mboxrd@z Thu Jan 1 00:00:00 1970 From: Andy Shevchenko Subject: Re: [PATCH v5 08/15] clockevents/drivers: Add STM32 Timer driver Date: Sat, 4 Apr 2015 01:14:04 +0300 Message-ID: References: <1428080481-18591-1-git-send-email-mcoquelin.stm32@gmail.com> <1428080481-18591-9-git-send-email-mcoquelin.stm32@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Return-path: In-Reply-To: Sender: linux-api-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Maxime Coquelin Cc: =?UTF-8?Q?Uwe_Kleine=2DK=C3=B6nig?= , =?UTF-8?Q?Andreas_F=C3=A4rber?= , Geert Uytterhoeven , Rob Herring , Philipp Zabel , Linus Walleij , Arnd Bergmann , Stefan Agner , Peter Meerwald , Paul Bolle , Peter Hurley , cw00.choi-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org, Russell King , Daniel Lezcano , Jonathan Corbet , Pawel Moll , Mark Rutland , Ian Campbell , Kumar Gala , Thomas Gleixner , Greg Kroah-Hartman , Jiri Slaby , Andrew List-Id: linux-gpio@vger.kernel.org On Sat, Apr 4, 2015 at 1:09 AM, Andy Shevchenko wrote: > On Fri, Apr 3, 2015 at 8:01 PM, Maxime Coquelin > wrote: >> STM32 MCUs feature 16 and 32 bits general purpose timers with prescalers. >> The drivers detects whether the time is 16 or 32 bits, and applies a >> 1024 prescaler value if it is 16 bits. [] >> + pr_err("failed to get clock for clockevent (%d)\n", ret); > > Why not dev_err(); ? Understood, because it's device tree with lack of something like of_err(); -- With Best Regards, Andy Shevchenko From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752896AbbDCWOP (ORCPT ); Fri, 3 Apr 2015 18:14:15 -0400 Received: from mail-lb0-f173.google.com ([209.85.217.173]:35878 "EHLO mail-lb0-f173.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751730AbbDCWOH (ORCPT ); Fri, 3 Apr 2015 18:14:07 -0400 MIME-Version: 1.0 In-Reply-To: References: <1428080481-18591-1-git-send-email-mcoquelin.stm32@gmail.com> <1428080481-18591-9-git-send-email-mcoquelin.stm32@gmail.com> Date: Sat, 4 Apr 2015 01:14:04 +0300 Message-ID: Subject: Re: [PATCH v5 08/15] clockevents/drivers: Add STM32 Timer driver From: Andy Shevchenko To: Maxime Coquelin Cc: =?UTF-8?Q?Uwe_Kleine=2DK=C3=B6nig?= , =?UTF-8?Q?Andreas_F=C3=A4rber?= , Geert Uytterhoeven , Rob Herring , Philipp Zabel , Linus Walleij , Arnd Bergmann , Stefan Agner , Peter Meerwald , Paul Bolle , Peter Hurley , cw00.choi@samsung.com, Russell King , Daniel Lezcano , Jonathan Corbet , Pawel Moll , Mark Rutland , Ian Campbell , Kumar Gala , Thomas Gleixner , Greg Kroah-Hartman , Jiri Slaby , Andrew Morton , "David S. Miller" , Mauro Carvalho Chehab , Joe Perches , Antti Palosaari , Tejun Heo , Will Deacon , Nikolay Borisov , Rusty Russell , Kees Cook , Michal Marek , Linux Documentation List , linux-arm Mailing List , "linux-kernel@vger.kernel.org" , devicetree , "linux-gpio@vger.kernel.org" , "linux-serial@vger.kernel.org" , Linux-Arch , "linux-api@vger.kernel.org" Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sat, Apr 4, 2015 at 1:09 AM, Andy Shevchenko wrote: > On Fri, Apr 3, 2015 at 8:01 PM, Maxime Coquelin > wrote: >> STM32 MCUs feature 16 and 32 bits general purpose timers with prescalers. >> The drivers detects whether the time is 16 or 32 bits, and applies a >> 1024 prescaler value if it is 16 bits. [] >> + pr_err("failed to get clock for clockevent (%d)\n", ret); > > Why not dev_err(); ? Understood, because it's device tree with lack of something like of_err(); -- With Best Regards, Andy Shevchenko From mboxrd@z Thu Jan 1 00:00:00 1970 From: andy.shevchenko@gmail.com (Andy Shevchenko) Date: Sat, 4 Apr 2015 01:14:04 +0300 Subject: [PATCH v5 08/15] clockevents/drivers: Add STM32 Timer driver In-Reply-To: References: <1428080481-18591-1-git-send-email-mcoquelin.stm32@gmail.com> <1428080481-18591-9-git-send-email-mcoquelin.stm32@gmail.com> Message-ID: To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On Sat, Apr 4, 2015 at 1:09 AM, Andy Shevchenko wrote: > On Fri, Apr 3, 2015 at 8:01 PM, Maxime Coquelin > wrote: >> STM32 MCUs feature 16 and 32 bits general purpose timers with prescalers. >> The drivers detects whether the time is 16 or 32 bits, and applies a >> 1024 prescaler value if it is 16 bits. [] >> + pr_err("failed to get clock for clockevent (%d)\n", ret); > > Why not dev_err(); ? Understood, because it's device tree with lack of something like of_err(); -- With Best Regards, Andy Shevchenko