From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id DF31DC433EF for ; Wed, 6 Jul 2022 17:49:50 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234156AbiGFRtt (ORCPT ); Wed, 6 Jul 2022 13:49:49 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:38688 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234149AbiGFRtp (ORCPT ); Wed, 6 Jul 2022 13:49:45 -0400 Received: from mail-yw1-x112b.google.com (mail-yw1-x112b.google.com [IPv6:2607:f8b0:4864:20::112b]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 409602AC40; Wed, 6 Jul 2022 10:49:42 -0700 (PDT) Received: by mail-yw1-x112b.google.com with SMTP id 00721157ae682-31c89111f23so97464557b3.0; Wed, 06 Jul 2022 10:49:42 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc:content-transfer-encoding; bh=hxTslvLVwC01aY6geFBuJCKUK0+HS1strSnRpGPxitU=; b=WTAVi865N4c5hRg+l+I3ZgdaYss3RCuA4gG02qSw2FCnZ/qB0L+Rerz3CzYxdKNtmR N8JIy42JnvVtsYbBJEwbwGBq+mmyOBgKh3x74Z/35AA816/VuDL4Z1GIQp/a4GAfUWn+ SqZmfACsY6R1u3pg0dTPbm34yCI3t1NzixXuF28feZ4s0FcCrVtqFnFPRN/igXiITfmt Fy2spcEDuIt30Slyowh/RZV7pSA5MzxKM3utTvNKgC/USWoPaAB7+iARz3UaR22uoT69 1YrSQJc40l1o0ENH3LNuor1sEo2Z/FmzjWkrhqHR1MtUg1EqQ7R60qeSLi7tTmQRRWp7 p6aA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=hxTslvLVwC01aY6geFBuJCKUK0+HS1strSnRpGPxitU=; b=x4BgUXKGjrZAAZCiISMgJJkFxX1Wp0tofCv1iTdfEUekHDFHpKNFFRSP2jq2RXOZea ccHV8lkUOpcBTBkJISrnDG1BOoEBm24nbhuSgClC3LrLKRB38SvIGldwtnmWl8bkrnQ4 zZ4+UFXPpHtfWpnOYkS76P4la5N09xDsktgEzkou/8FnmyjqO2Jmgiz5NN6HYL71ZbbZ Lq/NlhKuZfF48vlK33nkvw3cwexaQoSQay2pKU9fuwFeFtUpyqZZEWVq69wzJYJbA2cI c+vaaWhEFnqm/2dRVxl4zLz0XguDwhy1W0N1yGHFIlsJgkMUlnWzbH0OAouQmHwgz1DD jfXg== X-Gm-Message-State: AJIora8NmIKFRK8ZiUPSbL/5jGkdVtgSNDlnlVR+AZfRQXn4hwDITsze hJS1QGg3AfpU7/aEyxqQy3ry/8CysT/6fs/wyfY= X-Google-Smtp-Source: AGRyM1tR3KVZvvsZqpTS+caFqZHgncqVJoW9H8eSG4Xhs43JoeL3dasG+VJDVV+kd0K7qOXvPFt3mAX8DCpe/G+dh5M= X-Received: by 2002:a81:13cc:0:b0:31c:ad64:352c with SMTP id 195-20020a8113cc000000b0031cad64352cmr16022413ywt.185.1657129781362; Wed, 06 Jul 2022 10:49:41 -0700 (PDT) MIME-Version: 1.0 References: <20220704003337.208696-1-ang.iglesiasg@gmail.com> In-Reply-To: From: Andy Shevchenko Date: Wed, 6 Jul 2022 19:49:04 +0200 Message-ID: Subject: Re: [PATCH v2 5/5] iio: pressure: bmp280: Adds more tunable config parameters for BMP380 To: Angel Iglesias Cc: Jonathan Cameron , Lars-Peter Clausen , "Rafael J. Wysocki" , Paul Cercueil , Ulf Hansson , linux-iio , Linux Kernel Mailing List Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Jul 6, 2022 at 4:39 PM Angel Iglesias wro= te: > On mi=C3=A9, 2022-07-06 at 14:42 +0200, Andy Shevchenko wrote: > > On Wed, Jul 6, 2022 at 12:51 AM Angel Iglesias > > wrote: > > > On Mon, 2022-07-04 at 22:08 +0200, Andy Shevchenko wrote: > > > > On Mon, Jul 4, 2022 at 2:41 AM Angel Iglesias > > > > wrote: ... > > > > Why do you need to copy'n'paste dozens of the very same comment? > > > > Wouldn't it be enough to explain it somewhere at the top of the fil= e > > > > or in the respective documentation (if it exists)? > > > > No answer? > > Apologies, I'll fix the duplicated comments. Would be a good place for th= e > comment before the function "bmp280_write_raw" or at the start of the swi= tch > block? I believe you may find the best place yourself. My point is to see no duplication, that's it. --=20 With Best Regards, Andy Shevchenko