From mboxrd@z Thu Jan 1 00:00:00 1970 From: Andy Shevchenko Subject: Re: [PATCH v2 2/2] platform/x86: silead_dmi: Add silead,home-button property to some tablets Date: Fri, 27 Oct 2017 18:36:34 +0300 Message-ID: References: <20171017154512.30524-1-hdegoede@redhat.com> <20171017154512.30524-2-hdegoede@redhat.com> <2e5b4fd2-5445-a1f6-c509-5de2bb96c491@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Return-path: Received: from mail-qk0-f169.google.com ([209.85.220.169]:52086 "EHLO mail-qk0-f169.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750851AbdJ0Pgf (ORCPT ); Fri, 27 Oct 2017 11:36:35 -0400 In-Reply-To: <2e5b4fd2-5445-a1f6-c509-5de2bb96c491@redhat.com> Sender: platform-driver-x86-owner@vger.kernel.org List-ID: To: Hans de Goede Cc: Dmitry Torokhov , Benjamin Tissoires , Darren Hart , Andy Shevchenko , linux-input , Platform Driver On Fri, Oct 27, 2017 at 6:26 PM, Hans de Goede wrote: > On 27-10-17 16:39, Andy Shevchenko wrote: >> On Tue, Oct 17, 2017 at 6:45 PM, Hans de Goede >> wrote: >>> >>> Add "silead,home-button" property to entries for tablets which have >>> a capacitive home button (typically a windows logo on the front). >>> >>> This new property is checked for by the new capacitive home button >>> support in the silead touchscreen driver. >> Acked-by: Andy Shevchenko >> >> I suppose it's going through input subsystem as dependent patch? > Since silead_dmi tends to see several patches each cycle I don't > think that is a good idea, both patches can be merged independently. > > Either patch will not do anything until the other one is merged, > having just one or the other present will not cause any problems, > so IMHO merging each patch separately is best. Fine. > It is probably a good idea to wait for an ack from RobH on the > property name before merging this though. Yes, this is good advice. Let's wait for Rob's Ack. -- With Best Regards, Andy Shevchenko