From: Andy Shevchenko <andy.shevchenko@gmail.com>
To: "Rafael J. Wysocki" <rafael@kernel.org>
Cc: egranata@google.com,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Enric Balletbo i Serra <enric.balletbo@collabora.com>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Gwendal Grignou <gwendal@chromium.org>,
Dmitry Torokhov <dtor@chromium.org>,
ACPI Devel Maling List <linux-acpi@vger.kernel.org>,
Brian Norris <briannorris@chromium.org>,
Enrico Granata <egranata@chromium.org>,
Mika Westerberg <mika.westerberg@linux.intel.com>,
Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
Hans de Goede <hdegoede@redhat.com>
Subject: Re: [PATCH] driver: platform: Add support for GpioInt() ACPI to platform_get_irq()
Date: Thu, 7 Feb 2019 21:39:25 +0200 [thread overview]
Message-ID: <CAHp75Ve5nw-TD0MqFq6Rzbuhqz2SjyqmOCst1-U3QV=U7k3cbg@mail.gmail.com> (raw)
In-Reply-To: <CAJZ5v0jFqkTS__oOfPNvatHOa6OA++uRNLx1-PhiPvS1VnPVXg@mail.gmail.com>
On Thu, Feb 7, 2019 at 9:04 PM Rafael J. Wysocki <rafael@kernel.org> wrote:
>
> +Mika Westerberg
> +Andy Shevchenko
> +Hans de Goede
Thanks, Rafael.
My comments below.
> On Thu, Feb 7, 2019 at 7:59 PM <egranata@google.com> wrote:
> >
> > From: Enrico Granata <egranata@chromium.org>
> >
> > ACPI 5 added support for GpioInt resources as a way to provide
> > information about interrupts mediated via a GPIO controller.
> >
> > Several device buses (e.g. SPI, I2C) have support for retrieving
> > an IRQ specified via this type of resource, and providing it
> > directly to the driver as an IRQ number.
> > This is not currently done for the platform drivers, as platform_get_irq()
> > does not try to parse GpioInt() resources.
And why is this a problem?
> > This commit adds that functionality.
How that can override the configuration / BIOS flavour when driver
needs to register an interrupt out of GpioIo() resource?
P.S. Have you looked at drivers/platform/x86/i2c-multi-instantiate.c
and intel_cht_int33fe.c?
They are the only drivers which needs something like this for now and
I would rather say it's a bad BIOS decision to write a table like
that.
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2019-02-07 19:39 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-02-07 18:59 [PATCH] driver: platform: Add support for GpioInt() ACPI to platform_get_irq() egranata
2019-02-07 19:02 ` Rafael J. Wysocki
2019-02-07 19:39 ` Andy Shevchenko [this message]
2019-02-07 19:45 ` Andy Shevchenko
2019-02-07 19:55 ` Enrico Granata
[not found] ` <CAPR809vnpuh8nOjU3QMCh6YJUKmtX92+bnHSUKGiAXAp6NwCHQ@mail.gmail.com>
2019-02-07 20:18 ` Andy Shevchenko
2019-02-07 20:29 ` Dmitry Torokhov
2019-02-11 10:30 ` Mika Westerberg
2019-02-11 15:42 ` Hans de Goede
2019-02-11 19:01 ` [PATCH v2] driver: platform: Support parsing GpioInt 0 in platform_get_irq() egranata
2019-02-11 19:25 ` Dmitry Torokhov
2019-02-12 7:29 ` Hans de Goede
2019-02-12 9:08 ` Mika Westerberg
2019-02-12 9:18 ` Rafael J. Wysocki
2019-02-12 12:46 ` Andy Shevchenko
2019-02-20 18:05 ` Brian Norris
2019-02-21 18:58 ` Enrico Granata
2019-02-21 19:34 ` [PATCH v3] " egranata
2019-02-22 9:03 ` Rafael J. Wysocki
2019-02-22 17:06 ` Brian Norris
2019-02-24 19:34 ` [PATCH v2] " Rafael J. Wysocki
-- strict thread matches above, loose matches on Subject: below --
2019-02-07 18:50 [PATCH] driver: platform: Add support for GpioInt() ACPI to platform_get_irq() egranata
2019-02-07 18:57 ` Rafael J. Wysocki
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAHp75Ve5nw-TD0MqFq6Rzbuhqz2SjyqmOCst1-U3QV=U7k3cbg@mail.gmail.com' \
--to=andy.shevchenko@gmail.com \
--cc=andriy.shevchenko@linux.intel.com \
--cc=briannorris@chromium.org \
--cc=dtor@chromium.org \
--cc=egranata@chromium.org \
--cc=egranata@google.com \
--cc=enric.balletbo@collabora.com \
--cc=gregkh@linuxfoundation.org \
--cc=gwendal@chromium.org \
--cc=hdegoede@redhat.com \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mika.westerberg@linux.intel.com \
--cc=rafael@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.