From: Andy Shevchenko <andy.shevchenko@gmail.com>
To: Rajmohan Mani <rajmohan.mani@intel.com>
Cc: "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"linux-gpio@vger.kernel.org" <linux-gpio@vger.kernel.org>,
"linux-acpi@vger.kernel.org" <linux-acpi@vger.kernel.org>,
Lee Jones <lee.jones@linaro.org>,
Linus Walleij <linus.walleij@linaro.org>,
Alexandre Courbot <gnurou@gmail.com>,
"Rafael J. Wysocki" <rjw@rjwysocki.net>,
Len Brown <lenb@kernel.org>
Subject: Re: [PATCH v2 2/3] gpio: Add support for TPS68470 GPIOs
Date: Sun, 11 Jun 2017 16:43:55 +0300 [thread overview]
Message-ID: <CAHp75Ve5zabpmRoAYbg7ONcp8WM_cCB=xiSLhSnU6QzC0CnJ3g@mail.gmail.com> (raw)
In-Reply-To: <1497161395-36504-3-git-send-email-rajmohan.mani@intel.com>
On Sun, Jun 11, 2017 at 9:09 AM, Rajmohan Mani <rajmohan.mani@intel.com> wrote:
> This patch adds support for TPS68470 GPIOs.
> There are 7 GPIOs and a few sensor related GPIOs.
> These GPIOs can be requested and configured as
> appropriate.
Main points (some I already told in an answer to Sakari's mail):
1. Consider 2 GPIO chips over 1.
2. Fix FIXME(s).
3. If there is hardware bug we should work around it must be clarified.
4. You missed Linus' comments here (switch to the data pointer inside
GPIO chip and remove platform driver data stuff from the driver).
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2017-06-11 13:50 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-06-11 6:09 [PATCH v2 0/3] TPS68470 PMIC drivers Rajmohan Mani
2017-06-11 6:09 ` [PATCH v2 1/3] mfd: Add new mfd device TPS68470 Rajmohan Mani
2017-06-11 13:17 ` Andy Shevchenko
2017-06-12 9:12 ` Mani, Rajmohan
2017-06-12 9:16 ` Andy Shevchenko
2017-06-11 6:09 ` [PATCH v2 2/3] gpio: Add support for TPS68470 GPIOs Rajmohan Mani
2017-06-11 13:43 ` Andy Shevchenko [this message]
2017-06-12 9:14 ` Mani, Rajmohan
2017-07-06 1:49 ` Mani, Rajmohan
2017-06-11 6:09 ` [PATCH v2 3/3] ACPI / PMIC: Add TI PMIC TPS68470 operation region driver Rajmohan Mani
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAHp75Ve5zabpmRoAYbg7ONcp8WM_cCB=xiSLhSnU6QzC0CnJ3g@mail.gmail.com' \
--to=andy.shevchenko@gmail.com \
--cc=gnurou@gmail.com \
--cc=lee.jones@linaro.org \
--cc=lenb@kernel.org \
--cc=linus.walleij@linaro.org \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=rajmohan.mani@intel.com \
--cc=rjw@rjwysocki.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.