From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.1 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D547DC433ED for ; Mon, 27 Jul 2020 19:44:38 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id AFFB320738 for ; Mon, 27 Jul 2020 19:44:38 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="HLOh+BHL" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728833AbgG0Toh (ORCPT ); Mon, 27 Jul 2020 15:44:37 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:59340 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726196AbgG0Tog (ORCPT ); Mon, 27 Jul 2020 15:44:36 -0400 Received: from mail-pf1-x443.google.com (mail-pf1-x443.google.com [IPv6:2607:f8b0:4864:20::443]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 60D54C061794; Mon, 27 Jul 2020 12:44:36 -0700 (PDT) Received: by mail-pf1-x443.google.com with SMTP id m8so2800927pfh.3; Mon, 27 Jul 2020 12:44:36 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=qzzZKFqE1nfVRb0bTdQAza1honJ2T0+1vW2BFXwTzqA=; b=HLOh+BHLV83GvCy5qUxFSaZI0+nJP44EMKDBWsLY8Ovleoz0qJzz9U/WHyEcv8UmBR K6dzaNevQflsp7u1+vL5BpA3XgDFl66RzHvFTsbEJAoMUxj8tAYHWQ5e2pNuo8db9gJe PJegFSJz/dE71vnOhQ4JE8F7CAkptW/6IiGqB18TtsZS+FvQ+fpDtHyKSpGeyycOmDGk +61FWMMRgSO3dsJRPTJYfH7iezRNM7LIchSAZBCfb8kF4+kXRublXv+myOcu6UNAEBgi rLsNTbH1/YK8y3dO6mBN28vzkIqqhsJwgLugHq2jPJAK7F4CjOjeLidnlm6kM8JEwKL4 gi1w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=qzzZKFqE1nfVRb0bTdQAza1honJ2T0+1vW2BFXwTzqA=; b=PyK+AxFqwavXoNnGZH2qOAPdlhoHmp60s5BR2CP+a/jJl/tNxTcXwnwplDAaM7nS6t w9fZU1WMECHpmbd3ANQPVuY6wb01YNDPPufTiPV06dZJNZMOwWaXc+OY0ZvJQOKArfCp exGVr3BdG2/HAauiWMydt3Gc6xKXy9tj6+M3eH/kW7zSEa+OayoesKkT5fnjxOKCOXD6 fREiuCyjEBr8QSCr6RkvB4aDtKsS4Gh82ZfIUJIWIaNtjy2uMAesscs6KocB7k05VbKy DgGXMgKcQDB+LM1f1Ng8+6GVFkzEN9JFGkcleSEnhIs51BQbcocEzR7ZWq/9ffMltvtF gYJA== X-Gm-Message-State: AOAM530mzj6zkTZJ8MZIo+e9eT/gFSkgTAVCA1+TYmqP192/S3esU6VD cCpH4sWV7HpZ2j2TGP054GJJ6u9Xl+ZFZGgqFigzjVwPTQ0= X-Google-Smtp-Source: ABdhPJzEd9N2EW8275FRzfeT1fNAW9ksND1FAyY1KyG0A8DkhI41cM9sG0GJE6Li/KdL/CE30l9gi3zTMIRToWH2OsA= X-Received: by 2002:a62:758f:: with SMTP id q137mr3064389pfc.170.1595879075906; Mon, 27 Jul 2020 12:44:35 -0700 (PDT) MIME-Version: 1.0 References: <20200727092346.19780-1-amelie.delaunay@st.com> <20200727092346.19780-4-amelie.delaunay@st.com> In-Reply-To: From: Andy Shevchenko Date: Mon, 27 Jul 2020 22:44:19 +0300 Message-ID: Subject: Re: [PATCH v4 3/3] usb: dwc2: don't use ID/Vbus detection if usb-role-switch on STM32MP15 SoCs To: Martin Blumenstingl Cc: Amelie Delaunay , Minas Harutyunyan , Felipe Balbi , Greg Kroah-Hartman , Rob Herring , Maxime Coquelin , Alexandre Torgue , USB , devicetree , Linux Kernel Mailing List , linux-arm Mailing List , linux-stm32@st-md-mailman.stormreply.com, Fabrice Gasnier Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Jul 27, 2020 at 10:04 PM Martin Blumenstingl wrote: > On Mon, Jul 27, 2020 at 11:23 AM Amelie Delaunay wrote: > > - p->activate_stm_id_vb_detection = true; > > + p->activate_stm_id_vb_detection = > > + !of_property_read_bool(np, "usb-role-switch"); > the rest of params.c uses device_property_read_* instead of of_read_property_* > I thought I'd mention it so you can decide yourself whether this is > fine or needs to be changed Better to change and leave all on one line. -- With Best Regards, Andy Shevchenko From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.0 required=3.0 tests=BAYES_00,DKIM_ADSP_CUSTOM_MED, DKIM_SIGNED,DKIM_VALID,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 997BFC433E8 for ; Mon, 27 Jul 2020 19:46:18 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 6582A206E7 for ; Mon, 27 Jul 2020 19:46:18 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="N1OUVcL8"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="HLOh+BHL" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 6582A206E7 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:To:Subject:Message-ID:Date:From:In-Reply-To: References:MIME-Version:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=y1EPlwwnmmf/4788u+thhFN2DqI83vf2Baw//22NPSE=; b=N1OUVcL8C0DF9K4P6oVag92LY G3E8WcfqMm3Pm+n/sBFxzfhpsIBcEYS8HTniRjtnvm1t7I8v+YNStfd2QTT9PoPhwvi08NhmLjvfT ha+vv7wq44/v06pzWJxXi5cAEbF8pv1M8xFd9qjSajUeeQBKGW+wa/GwVxxrGzGlbL3K0DjY38IcJ 8P0ByDY/7K0SfpL+d+Vv7Yqa94o93s5n5wQqobbJ2O3Iv4TH1WsMS9gcwv9ej1sA6gV1JS/OFdTCO syTkOn9+9iJ3UH0Jn4DSKdv1TXtYnPky3o3PeSZqB9LUE36x6/qg/2X0So+ghlIFaiNRa5KwI8cl4 ulY7GpIMw==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1k0939-0007up-NO; Mon, 27 Jul 2020 19:44:39 +0000 Received: from mail-pf1-x443.google.com ([2607:f8b0:4864:20::443]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1k0938-0007tn-1i for linux-arm-kernel@lists.infradead.org; Mon, 27 Jul 2020 19:44:38 +0000 Received: by mail-pf1-x443.google.com with SMTP id z188so1817675pfc.6 for ; Mon, 27 Jul 2020 12:44:37 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=qzzZKFqE1nfVRb0bTdQAza1honJ2T0+1vW2BFXwTzqA=; b=HLOh+BHLV83GvCy5qUxFSaZI0+nJP44EMKDBWsLY8Ovleoz0qJzz9U/WHyEcv8UmBR K6dzaNevQflsp7u1+vL5BpA3XgDFl66RzHvFTsbEJAoMUxj8tAYHWQ5e2pNuo8db9gJe PJegFSJz/dE71vnOhQ4JE8F7CAkptW/6IiGqB18TtsZS+FvQ+fpDtHyKSpGeyycOmDGk +61FWMMRgSO3dsJRPTJYfH7iezRNM7LIchSAZBCfb8kF4+kXRublXv+myOcu6UNAEBgi rLsNTbH1/YK8y3dO6mBN28vzkIqqhsJwgLugHq2jPJAK7F4CjOjeLidnlm6kM8JEwKL4 gi1w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=qzzZKFqE1nfVRb0bTdQAza1honJ2T0+1vW2BFXwTzqA=; b=PEJsZwqd++H4VhvaeJ3YdDxbSdoYeHdqnbwieYAbn0QezsvTkkExN093FpP9jKkyhT ZUsfIKo8KZf8VBb+BgSJtSaKEAVSSS/TRGwb3gWSVpSb2NZsXidZtNBosdqJPbX52Yuu WEfEzdsdI/AGXtMeUvy8aZqKu5nRYoDNch3rKevopKH9V0Y9X+jkW13lQOoZmVfsjcCY la0P1yhhx4WSdhhOBYx8xbX4iGKCdGwpqi8lVcTFwBNWkkykTXg5ANmgPViD2SDJ/7cb MzXRUuzFUXQSQajVGh/+H8mR104xfYvuAfYQgYgdW52ojTQa/kEOKJ4dfGRScCa61Jn+ jBvQ== X-Gm-Message-State: AOAM531sXvxw/cod180z+lwUXm3ThX0nYAQ4zvSsUkmLR5bwA54TmbFB PwlXjEyVSOFvRx3zd51X2oUFketsAEqtXVh+2Wc= X-Google-Smtp-Source: ABdhPJzEd9N2EW8275FRzfeT1fNAW9ksND1FAyY1KyG0A8DkhI41cM9sG0GJE6Li/KdL/CE30l9gi3zTMIRToWH2OsA= X-Received: by 2002:a62:758f:: with SMTP id q137mr3064389pfc.170.1595879075906; Mon, 27 Jul 2020 12:44:35 -0700 (PDT) MIME-Version: 1.0 References: <20200727092346.19780-1-amelie.delaunay@st.com> <20200727092346.19780-4-amelie.delaunay@st.com> In-Reply-To: From: Andy Shevchenko Date: Mon, 27 Jul 2020 22:44:19 +0300 Message-ID: Subject: Re: [PATCH v4 3/3] usb: dwc2: don't use ID/Vbus detection if usb-role-switch on STM32MP15 SoCs To: Martin Blumenstingl X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200727_154438_130493_4533159F X-CRM114-Status: GOOD ( 13.35 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Felipe Balbi , Amelie Delaunay , Alexandre Torgue , devicetree , Greg Kroah-Hartman , USB , Linux Kernel Mailing List , Rob Herring , Maxime Coquelin , Minas Harutyunyan , Fabrice Gasnier , linux-stm32@st-md-mailman.stormreply.com, linux-arm Mailing List Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Mon, Jul 27, 2020 at 10:04 PM Martin Blumenstingl wrote: > On Mon, Jul 27, 2020 at 11:23 AM Amelie Delaunay wrote: > > - p->activate_stm_id_vb_detection = true; > > + p->activate_stm_id_vb_detection = > > + !of_property_read_bool(np, "usb-role-switch"); > the rest of params.c uses device_property_read_* instead of of_read_property_* > I thought I'd mention it so you can decide yourself whether this is > fine or needs to be changed Better to change and leave all on one line. -- With Best Regards, Andy Shevchenko _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel