From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.3 required=3.0 tests=DKIM_ADSP_CUSTOM_MED, DKIM_INVALID,DKIM_SIGNED,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id CB4B4C433DF for ; Fri, 5 Jun 2020 19:40:51 +0000 (UTC) Received: from ml01.01.org (ml01.01.org [198.145.21.10]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id A0C90207D8 for ; Fri, 5 Jun 2020 19:40:51 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="bnJxDETT" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org A0C90207D8 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-nvdimm-bounces@lists.01.org Received: from ml01.vlan13.01.org (localhost [IPv6:::1]) by ml01.01.org (Postfix) with ESMTP id 5B5A91009F03F; Fri, 5 Jun 2020 12:35:38 -0700 (PDT) Received-SPF: Pass (mailfrom) identity=mailfrom; client-ip=2607:f8b0:4864:20::1043; helo=mail-pj1-x1043.google.com; envelope-from=andy.shevchenko@gmail.com; receiver= Received: from mail-pj1-x1043.google.com (mail-pj1-x1043.google.com [IPv6:2607:f8b0:4864:20::1043]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 8A7CC1009F039 for ; Fri, 5 Jun 2020 12:35:36 -0700 (PDT) Received: by mail-pj1-x1043.google.com with SMTP id m2so3264511pjv.2 for ; Fri, 05 Jun 2020 12:40:49 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=XD9SvQZCXqBYsn01rJ4+6okeD2WJfdjImO5gHn5OfAs=; b=bnJxDETTne1L69aD8HMa3+kqe0sCzIsfxsY/YGV+blK3BmwxALlVA3u7SAzSgUmOnl Z6vkaXeq1Oll41yzGDjLdhJrjYykohJ9ZMVm+8VJp0451xMrw2obIW8B2NJ81JC9UN43 eOpQFIYIHQF3Yq7Eh2EfJZjwrtAN20rvfknSbj69OMBiMyO+vYv5t8et8k/frbSnKym1 jsPzZ9m2bhn9aBApE58LENVDX+Zwt3H5Z87CV5kPJZs6oqAPNJTx8XZoa//yWYIIyKpC rbIlTj4JXsNRWc7BjOhLFA3/i09wwxHjH/kdv+KAdrs6i6oon9gYXXYxgg1T1BsmFC6B 5UrA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=XD9SvQZCXqBYsn01rJ4+6okeD2WJfdjImO5gHn5OfAs=; b=JIwqjywtqDOZCTUqFCGkMnxgfBhGu01xrTH4iBhKKL3lgDgM+dY5O8WbolytY73VzV JbsxcU84yn8Ja7bnAzIL9yn0HCPe46BzuJU3tTkjr78LSrdV0YEba0QwGT39+7sJfMju cDdK37++qBoCFN+REdScx253pxgfAoKBTuXrWfG+CkAqVQwdsrhuAr37m2e2RD43AoWB ++vKfoE+tjQJASYJdt1OFA5yN7u7ZNhxI04lESG9OvyIMfDI8qjuhcXD0AVSjRSytM/z FlrDkQBUDXMjpqeWlNn4p+Skqolrnkgkow1PllETKjuGulOexPcWCcCdeO+4ENdFE9BH +8PQ== X-Gm-Message-State: AOAM532q1bFOUEhOQv9BeAvayQsdky28lfX2kwDh4wQ8/YOp3WmLBCDH hMDVhQU0DBsuZ9v9XRGpBOxMo0+UPOWdM+6jxiw= X-Google-Smtp-Source: ABdhPJzxhdZq+OzZcXHaxB72UvfeXpj8EszRzS+I9vY2btE/7JjVwZ1hJGP0sRNO0nUDIIdnYcwulI8NIwFOPnICVV8= X-Received: by 2002:a17:90a:1704:: with SMTP id z4mr4668507pjd.181.1591386048635; Fri, 05 Jun 2020 12:40:48 -0700 (PDT) MIME-Version: 1.0 References: <158889473309.2292982.18007035454673387731.stgit@dwillia2-desk3.amr.corp.intel.com> <2643462.teTRrieJB7@kreacher> In-Reply-To: <2643462.teTRrieJB7@kreacher> From: Andy Shevchenko Date: Fri, 5 Jun 2020 22:40:36 +0300 Message-ID: Subject: Re: [RFT][PATCH] ACPI: OSL: Use rwlock instead of RCU for memory management To: "Rafael J. Wysocki" Message-ID-Hash: GQBCEP3PYHG6TPVFOIQOBGVX3DT6LPJR X-Message-ID-Hash: GQBCEP3PYHG6TPVFOIQOBGVX3DT6LPJR X-MailFrom: andy.shevchenko@gmail.com X-Mailman-Rule-Hits: nonmember-moderation X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation CC: "Rafael J. Wysocki" , Stable , Len Brown , Borislav Petkov , James Morse , Erik Kaneda , Myron Stowe , Andy Shevchenko , Linux Kernel Mailing List , ACPI Devel Maling List , linux-nvdimm@lists.01.org X-Mailman-Version: 3.1.1 Precedence: list List-Id: "Linux-nvdimm developer list." Archived-At: List-Archive: List-Help: List-Post: List-Subscribe: List-Unsubscribe: Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit On Fri, Jun 5, 2020 at 5:11 PM Rafael J. Wysocki wrote: ... > + if (!refcount) { > + write_lock_irq(&acpi_ioremaps_list_lock); > + > + list_del(&map->list); > + > + write_unlock_irq(&acpi_ioremaps_list_lock); > + } > return refcount; It seems we can decrease indentation level at the same time: if (refcount) return refcount; ... return 0; -- With Best Regards, Andy Shevchenko _______________________________________________ Linux-nvdimm mailing list -- linux-nvdimm@lists.01.org To unsubscribe send an email to linux-nvdimm-leave@lists.01.org From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.6 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6788CC433E0 for ; Fri, 5 Jun 2020 19:40:50 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 3084F207D3 for ; Fri, 5 Jun 2020 19:40:50 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="bnJxDETT" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727105AbgFETkt (ORCPT ); Fri, 5 Jun 2020 15:40:49 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:43102 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727087AbgFETkt (ORCPT ); Fri, 5 Jun 2020 15:40:49 -0400 Received: from mail-pl1-x644.google.com (mail-pl1-x644.google.com [IPv6:2607:f8b0:4864:20::644]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 62ADFC08C5C2; Fri, 5 Jun 2020 12:40:49 -0700 (PDT) Received: by mail-pl1-x644.google.com with SMTP id d8so934642plo.12; Fri, 05 Jun 2020 12:40:49 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=XD9SvQZCXqBYsn01rJ4+6okeD2WJfdjImO5gHn5OfAs=; b=bnJxDETTne1L69aD8HMa3+kqe0sCzIsfxsY/YGV+blK3BmwxALlVA3u7SAzSgUmOnl Z6vkaXeq1Oll41yzGDjLdhJrjYykohJ9ZMVm+8VJp0451xMrw2obIW8B2NJ81JC9UN43 eOpQFIYIHQF3Yq7Eh2EfJZjwrtAN20rvfknSbj69OMBiMyO+vYv5t8et8k/frbSnKym1 jsPzZ9m2bhn9aBApE58LENVDX+Zwt3H5Z87CV5kPJZs6oqAPNJTx8XZoa//yWYIIyKpC rbIlTj4JXsNRWc7BjOhLFA3/i09wwxHjH/kdv+KAdrs6i6oon9gYXXYxgg1T1BsmFC6B 5UrA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=XD9SvQZCXqBYsn01rJ4+6okeD2WJfdjImO5gHn5OfAs=; b=SoUyl28PU2DKb6Y12jEFbpaxM9OB/vt1u1hU67SCooDyJo8nFYlQbLQ0jcBj/E6kFr A8FKOvVU5epw0rA/1PGbCyNCyRgI9p1x/UFWgJJmrrDEqcpynt2QuPLz9WdCUwXt5TjK ZtisQ5vmPjuyaSGM7JJ+jvLcxKejhNNL7K1L5MyOsoY6QAnae2Tnl52QnruiZ2TsKpCm suBnfQjq8qaD5wNwvwSxP/MNfzDoo9c0flObwwNbkTwcyhCXYBRB+rgGIy8BYFuX7lcF /uIuukoolGx1xJECeTvsm2d9uO6qc+g5rSLj/M10dCrPMcYaFsYG63gL7zXDTiOgoPHH jMBA== X-Gm-Message-State: AOAM531fy9YWyz8pRgpmbdsz7MQxLJ03bs9firWO0e6wy+dwV3vO9uZS YhTWiyf17p7wEKbEN7SAFNClHan6D4wCoBZuwf0= X-Google-Smtp-Source: ABdhPJzxhdZq+OzZcXHaxB72UvfeXpj8EszRzS+I9vY2btE/7JjVwZ1hJGP0sRNO0nUDIIdnYcwulI8NIwFOPnICVV8= X-Received: by 2002:a17:90a:1704:: with SMTP id z4mr4668507pjd.181.1591386048635; Fri, 05 Jun 2020 12:40:48 -0700 (PDT) MIME-Version: 1.0 References: <158889473309.2292982.18007035454673387731.stgit@dwillia2-desk3.amr.corp.intel.com> <2643462.teTRrieJB7@kreacher> In-Reply-To: <2643462.teTRrieJB7@kreacher> From: Andy Shevchenko Date: Fri, 5 Jun 2020 22:40:36 +0300 Message-ID: Subject: Re: [RFT][PATCH] ACPI: OSL: Use rwlock instead of RCU for memory management To: "Rafael J. Wysocki" Cc: Dan Williams , "Rafael J. Wysocki" , Stable , Len Brown , Borislav Petkov , Ira Weiny , James Morse , Erik Kaneda , Myron Stowe , Andy Shevchenko , Linux Kernel Mailing List , ACPI Devel Maling List , linux-nvdimm@lists.01.org Content-Type: text/plain; charset="UTF-8" Sender: linux-acpi-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-acpi@vger.kernel.org On Fri, Jun 5, 2020 at 5:11 PM Rafael J. Wysocki wrote: ... > + if (!refcount) { > + write_lock_irq(&acpi_ioremaps_list_lock); > + > + list_del(&map->list); > + > + write_unlock_irq(&acpi_ioremaps_list_lock); > + } > return refcount; It seems we can decrease indentation level at the same time: if (refcount) return refcount; ... return 0; -- With Best Regards, Andy Shevchenko