From: Andy Shevchenko <andy.shevchenko@gmail.com>
To: Sam Protsenko <semen.protsenko@linaro.org>
Cc: USB <linux-usb@vger.kernel.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Felipe Balbi <balbi@kernel.org>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
John Stultz <john.stultz@linaro.org>,
Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Subject: Re: [PATCH v3 2/2] usb: dwc3: drd: Improve dwc3_get_extcon() style
Date: Sun, 13 Dec 2020 13:30:09 +0200 [thread overview]
Message-ID: <CAHp75Ve9Yuyi4vqs3rLSA=Vtn6gBqyEyLsz7FDQ3SBbp_WxC8g@mail.gmail.com> (raw)
In-Reply-To: <20201211211916.6259-3-semen.protsenko@linaro.org>
On Sun, Dec 13, 2020 at 5:27 AM Sam Protsenko
<semen.protsenko@linaro.org> wrote:
>
> Commit c73b41955ee4 ("usb: dwc3: drd: Avoid error when extcon is
The previous change ("...
(because we don't know the actual commit id)
> missing") changed the code flow in dwc3_get_extcon() function, leading
> to unnecessary if-branch. This patch does housekeeping by reworking the
> code for obtaining extcon device from the "port" node. While at it, add
an extcon
> the comment from mentioned code block, explaining how checking the port
> availability helps to avoid the misleading error.
...
> + /*
> + * Try to get extcon device from USB PHY controller's "port" node.
an extcon
the USB
> + * Check if it has the "port" node first, to avoid printing the error
> + * message from underlying code, as it's a valid case: extcon device
> + * (and "port" node) may be missing in case of "usb-role-switch" or OTG
> + * mode.
> + */
To me it sounds like this should be in the previous patch.
--
With Best Regards,
Andy Shevchenko
prev parent reply other threads:[~2020-12-13 11:31 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-12-11 21:19 [PATCH v3 0/2] usb: dwc3: drd: Check graph presence for extcon Sam Protsenko
2020-12-11 21:19 ` [PATCH v3 1/2] usb: dwc3: drd: Avoid error when extcon is missing Sam Protsenko
2020-12-13 11:26 ` Andy Shevchenko
2020-12-11 21:19 ` [PATCH v3 2/2] usb: dwc3: drd: Improve dwc3_get_extcon() style Sam Protsenko
2020-12-13 11:30 ` Andy Shevchenko [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAHp75Ve9Yuyi4vqs3rLSA=Vtn6gBqyEyLsz7FDQ3SBbp_WxC8g@mail.gmail.com' \
--to=andy.shevchenko@gmail.com \
--cc=andriy.shevchenko@linux.intel.com \
--cc=balbi@kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=john.stultz@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=semen.protsenko@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.