From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.7 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7E6A0C636C9 for ; Mon, 19 Jul 2021 12:47:50 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 6B4EA6113E for ; Mon, 19 Jul 2021 12:47:50 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S237080AbhGSMHJ (ORCPT ); Mon, 19 Jul 2021 08:07:09 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:55716 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S237048AbhGSMHH (ORCPT ); Mon, 19 Jul 2021 08:07:07 -0400 Received: from mail-pl1-x62f.google.com (mail-pl1-x62f.google.com [IPv6:2607:f8b0:4864:20::62f]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 7598BC061574; Mon, 19 Jul 2021 05:05:42 -0700 (PDT) Received: by mail-pl1-x62f.google.com with SMTP id h1so9512779plf.6; Mon, 19 Jul 2021 05:47:47 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc:content-transfer-encoding; bh=BOHLfhVl4IX0jBgxq0tnyQp2G2EwOVwQ6QtIbNjmVL4=; b=BwBOE9uM1AY+Uh+eIMJgcSjFDrxGQiYieHqE8DHsDxmjfTTLSEJhMBRJ0Na6LOjCTx ynnbyDPNdbL5i/xGIauqPd6AKgFtjisEzf/km17aZPQSrYI9yxzF8aLYB54afng34ZZd EVna5SzPnhPbukw+rG6HIZ2mzZULX90AFnJ2kFTRRRoMDb92UlMDzz1csUhhG7KjRVvH R44ZzSqbg187NzBCz5oG+SRc25G7x9G+Q6bZSNUR80VwKc3C9lGOfAyXE/luKXx+xbNW T1QdFWiEQWE2I7QkQ5V+da6d8bOa74aaSjRKSiG+mItXjZ9UwNGhGFugX6vS18MS+wTy LfFA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=BOHLfhVl4IX0jBgxq0tnyQp2G2EwOVwQ6QtIbNjmVL4=; b=gn9KSH/QVYdlOCCHB/xnI7QySCQokYxEmyvYT8pwRuGYskdfzEj+BAL46Atm/iAoJs lSvYmfjSXWH9V1TF1Y9cTH5lECC6wxd4mKGRkA3xEKseELIR7nEpfB4plGljSHntJcZB C6bgcoqu0oKK2U1vAEeGwR3cBLaTuELCLBX4M/Cv5sU5jwrWKyYjCFGTSB4irVD9x51x p0BpxjKJjqKRXAgBRU1HmIl0WaIZ7mI+RnAicDQmn7YkOz1O0qgdpPNSabWUuZnjKgKf 6fCad5Hrnw7WXxaD+q9LLKvkeAYxzvK4E4uDZKtklrsfqq1k02PT6dHWwthc6Roa2R3a hqvg== X-Gm-Message-State: AOAM5322uX/+GYoexcIJiUgEuyEU8BRcHIFLikISpz3N4Q56JBEYrAfV xBxt3SKUwxAZAnq5untKfqnQBnlTT/Nhn/WTVkg= X-Google-Smtp-Source: ABdhPJxwcacipucz4PoseENZgZjBWKi1SW7dWOKNKkP4F/S4fGWnSOCuFP9GvjxQ6z7ZIZbfaIdloSyeopenMQXRneo= X-Received: by 2002:a17:90b:3647:: with SMTP id nh7mr24796132pjb.228.1626698866913; Mon, 19 Jul 2021 05:47:46 -0700 (PDT) MIME-Version: 1.0 References: <20210624224909.6350-1-pali@kernel.org> <20210717123829.5201-1-pali@kernel.org> <20210717123829.5201-2-pali@kernel.org> In-Reply-To: <20210717123829.5201-2-pali@kernel.org> From: Andy Shevchenko Date: Mon, 19 Jul 2021 15:47:07 +0300 Message-ID: Subject: Re: [PATCH v3 1/5] math64: New DIV_U64_ROUND_CLOSEST helper To: =?UTF-8?Q?Pali_Roh=C3=A1r?= Cc: Michael Turquette , Stephen Boyd , Rob Herring , Greg Kroah-Hartman , Andrew Lunn , Gregory Clement , Sebastian Hesselbarth , Vladimir Vid , =?UTF-8?B?TWFyZWsgQmVow7pu?= , Geert Uytterhoeven , linux-clk@vger.kernel.org, linux-serial@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sat, Jul 17, 2021 at 3:39 PM Pali Roh=C3=A1r wrote: > > Provide DIV_U64_ROUND_CLOSEST helper which uses div_u64 to perform > division rounded to the closest integer using unsigned 64bit > dividend and unsigned 32bit divisor. ... > +/* > + * DIV_U64_ROUND_CLOSEST - unsigned 64bit divide with 32bit divisor roun= ded to nearest integer > + * @dividend: unsigned 64bit dividend Here you insist users to provide a u64 (or compatible) type. > + * @divisor: unsigned 32bit divisor > + * > + * Divide unsigned 64bit dividend by unsigned 32bit divisor > + * and round to closest integer. > + * > + * Return: dividend / divisor rounded to nearest integer > + */ > +#define DIV_U64_ROUND_CLOSEST(dividend, divisor) \ > + ({ u32 _tmp =3D (divisor); div_u64((u64)(dividend) + _tmp / 2, _t= mp); }) Here is the casting to u64. Why? (Yes, I have read v1 discussion and I just want to continue it here). --=20 With Best Regards, Andy Shevchenko From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.7 required=3.0 tests=BAYES_00,DKIM_ADSP_CUSTOM_MED, DKIM_SIGNED,DKIM_VALID,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id AF18DC07E9B for ; Mon, 19 Jul 2021 12:49:58 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 7EE1460FF3 for ; Mon, 19 Jul 2021 12:49:58 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 7EE1460FF3 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:Cc:To:Subject:Message-ID:Date:From: In-Reply-To:References:MIME-Version:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=Cvil89WWVyFlq77pEfmQ/Z5I1vN9X4myhx1eiBIkQ84=; b=wvS61wCAjj1vis 13UoLhrO0qrB2bimlWEb4LyPTOEQpnsTsQRyoTbvwWlFqZoVopTBhS4PbhUqMdEHn44JU98F9H38I /8/BKnSE2+uVWzHr+Fh9kx5FDDvCYDsWpEAwp1kr/4NiRuwRXuC6Pd3E/QLAm2k371UqLMNb79t32 JCfx/lIaD8eDWlGcGzd6A5YDdLbw3m7hTuoKHP8W1LZrvtjvmT56JLhULbarJ6C5xYlm9DONfQoio 8RuLGEcBnCLs2V3D3Tqt0bcJJ2ioOQGD/7qs4N3sUMc0bAF+GbUS12mt2C6GhReoif5+APLtL9cfY TQ0WuqNqWtOG57qz24bA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1m5SgZ-009fev-Sf; Mon, 19 Jul 2021 12:47:52 +0000 Received: from mail-pj1-x102c.google.com ([2607:f8b0:4864:20::102c]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1m5SgV-009fdi-MI for linux-arm-kernel@lists.infradead.org; Mon, 19 Jul 2021 12:47:48 +0000 Received: by mail-pj1-x102c.google.com with SMTP id g24so11368488pji.4 for ; Mon, 19 Jul 2021 05:47:47 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc:content-transfer-encoding; bh=BOHLfhVl4IX0jBgxq0tnyQp2G2EwOVwQ6QtIbNjmVL4=; b=BwBOE9uM1AY+Uh+eIMJgcSjFDrxGQiYieHqE8DHsDxmjfTTLSEJhMBRJ0Na6LOjCTx ynnbyDPNdbL5i/xGIauqPd6AKgFtjisEzf/km17aZPQSrYI9yxzF8aLYB54afng34ZZd EVna5SzPnhPbukw+rG6HIZ2mzZULX90AFnJ2kFTRRRoMDb92UlMDzz1csUhhG7KjRVvH R44ZzSqbg187NzBCz5oG+SRc25G7x9G+Q6bZSNUR80VwKc3C9lGOfAyXE/luKXx+xbNW T1QdFWiEQWE2I7QkQ5V+da6d8bOa74aaSjRKSiG+mItXjZ9UwNGhGFugX6vS18MS+wTy LfFA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=BOHLfhVl4IX0jBgxq0tnyQp2G2EwOVwQ6QtIbNjmVL4=; b=sgzFgKJrKFMB55CYbRXrzoe2IrNHze448mjeq7Vqnegtj7i6Tot7Al6kvYkQTMKAgW /01bhl0oFKx1yRmU68Lg32UCvTvq6Gj7o2ZoLsO+HrYoIiP+HNoYLDlZO5FXXOQEzJIf pHcKoLMOjpXf2f07GCYzbUu91VZ47mvOeVXBuyUMIZTkPHPPTEFG8LuAUj/XU5PcP/iP kwngOW/ctN7MCDJyZ0jySi3p/x88Jpt414hgMcBNgBIoU9n0YIzDo5lw+OkHBkd9jmGJ Y6IzEaZEhW2ylVqK8lKsP3FRSsax6FEeHutbkr2wz+AKfBTPwe5nlsfrK/R7zzBhRawm EpDQ== X-Gm-Message-State: AOAM530EW7ikgcwKpFeDAgKcI6VC51UfQfSQOzdN3CXTdm3OaAByDX97 AaF65WSHCQu0vfhxZ1910ZubyCIYzu3dU81OriY= X-Google-Smtp-Source: ABdhPJxwcacipucz4PoseENZgZjBWKi1SW7dWOKNKkP4F/S4fGWnSOCuFP9GvjxQ6z7ZIZbfaIdloSyeopenMQXRneo= X-Received: by 2002:a17:90b:3647:: with SMTP id nh7mr24796132pjb.228.1626698866913; Mon, 19 Jul 2021 05:47:46 -0700 (PDT) MIME-Version: 1.0 References: <20210624224909.6350-1-pali@kernel.org> <20210717123829.5201-1-pali@kernel.org> <20210717123829.5201-2-pali@kernel.org> In-Reply-To: <20210717123829.5201-2-pali@kernel.org> From: Andy Shevchenko Date: Mon, 19 Jul 2021 15:47:07 +0300 Message-ID: Subject: Re: [PATCH v3 1/5] math64: New DIV_U64_ROUND_CLOSEST helper To: =?UTF-8?Q?Pali_Roh=C3=A1r?= Cc: Michael Turquette , Stephen Boyd , Rob Herring , Greg Kroah-Hartman , Andrew Lunn , Gregory Clement , Sebastian Hesselbarth , Vladimir Vid , =?UTF-8?B?TWFyZWsgQmVow7pu?= , Geert Uytterhoeven , linux-clk@vger.kernel.org, linux-serial@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210719_054747_750143_FA0EE591 X-CRM114-Status: GOOD ( 10.57 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org T24gU2F0LCBKdWwgMTcsIDIwMjEgYXQgMzozOSBQTSBQYWxpIFJvaMOhciA8cGFsaUBrZXJuZWwu b3JnPiB3cm90ZToKPgo+IFByb3ZpZGUgRElWX1U2NF9ST1VORF9DTE9TRVNUIGhlbHBlciB3aGlj aCB1c2VzIGRpdl91NjQgdG8gcGVyZm9ybQo+IGRpdmlzaW9uIHJvdW5kZWQgdG8gdGhlIGNsb3Nl c3QgaW50ZWdlciB1c2luZyB1bnNpZ25lZCA2NGJpdAo+IGRpdmlkZW5kIGFuZCB1bnNpZ25lZCAz MmJpdCBkaXZpc29yLgoKLi4uCgo+ICsvKgo+ICsgKiBESVZfVTY0X1JPVU5EX0NMT1NFU1QgLSB1 bnNpZ25lZCA2NGJpdCBkaXZpZGUgd2l0aCAzMmJpdCBkaXZpc29yIHJvdW5kZWQgdG8gbmVhcmVz dCBpbnRlZ2VyCgo+ICsgKiBAZGl2aWRlbmQ6IHVuc2lnbmVkIDY0Yml0IGRpdmlkZW5kCgpIZXJl IHlvdSBpbnNpc3QgdXNlcnMgdG8gcHJvdmlkZSBhIHU2NCAob3IgY29tcGF0aWJsZSkgdHlwZS4K Cj4gKyAqIEBkaXZpc29yOiB1bnNpZ25lZCAzMmJpdCBkaXZpc29yCj4gKyAqCj4gKyAqIERpdmlk ZSB1bnNpZ25lZCA2NGJpdCBkaXZpZGVuZCBieSB1bnNpZ25lZCAzMmJpdCBkaXZpc29yCj4gKyAq IGFuZCByb3VuZCB0byBjbG9zZXN0IGludGVnZXIuCj4gKyAqCj4gKyAqIFJldHVybjogZGl2aWRl bmQgLyBkaXZpc29yIHJvdW5kZWQgdG8gbmVhcmVzdCBpbnRlZ2VyCj4gKyAqLwo+ICsjZGVmaW5l IERJVl9VNjRfUk9VTkRfQ0xPU0VTVChkaXZpZGVuZCwgZGl2aXNvcikgICAgICAgXAoKPiArICAg ICAgICh7IHUzMiBfdG1wID0gKGRpdmlzb3IpOyBkaXZfdTY0KCh1NjQpKGRpdmlkZW5kKSArIF90 bXAgLyAyLCBfdG1wKTsgfSkKCkhlcmUgaXMgdGhlIGNhc3RpbmcgdG8gdTY0LiBXaHk/IChZZXMs IEkgaGF2ZSByZWFkIHYxIGRpc2N1c3Npb24gYW5kIEkKanVzdCB3YW50IHRvIGNvbnRpbnVlIGl0 IGhlcmUpLgoKLS0gCldpdGggQmVzdCBSZWdhcmRzLApBbmR5IFNoZXZjaGVua28KCl9fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fCmxpbnV4LWFybS1rZXJuZWwg bWFpbGluZyBsaXN0CmxpbnV4LWFybS1rZXJuZWxAbGlzdHMuaW5mcmFkZWFkLm9yZwpodHRwOi8v bGlzdHMuaW5mcmFkZWFkLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2xpbnV4LWFybS1rZXJuZWwK