All of lore.kernel.org
 help / color / mirror / Atom feed
From: Andy Shevchenko <andy.shevchenko@gmail.com>
To: John Garry <john.garry@huawei.com>
Cc: "xuwei (O)" <xuwei5@hisilicon.com>,
	Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
	Linuxarm <linuxarm@huawei.com>,
	"Rafael J. Wysocki" <rafael.j.wysocki@intel.com>,
	Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
	SoC Team <soc@kernel.org>,
	Yang Yingliang <yangyingliang@huawei.com>
Subject: Re: [PATCH v2 5/5] bus: hisi_lpc: Use platform_device_register_full()
Date: Fri, 2 Sep 2022 12:21:53 +0300	[thread overview]
Message-ID: <CAHp75VeE2OZHzwG-KbTHYks+G=sLfyx9Yy1W=RxORTtet-vDnQ@mail.gmail.com> (raw)
In-Reply-To: <CAHp75VdfwGCUpZN3b1AD1kARc=FhyA4EDWDuZ8+1DKN3u73DeA@mail.gmail.com>

On Fri, Sep 2, 2022 at 12:18 PM Andy Shevchenko
<andy.shevchenko@gmail.com> wrote:
>
> On Fri, Sep 2, 2022 at 11:10 AM John Garry <john.garry@huawei.com> wrote:
> >
> > The code to create the child platform device is essentially the same as
> > what platform_device_register_full() does, so change over to use
> > that same function to reduce duplication.
>
> Now statistics plays for you and not against.
> Reviewed-by: Andy Shevchenko <andy.shevchenko@gmail.com>

Too fast to give a tag, see below (keep tag if addressing it)

...

> > -       pdev = platform_device_alloc(cell->name, PLATFORM_DEVID_AUTO);
> > +       pdev = platform_device_register_full(cell->pdevinfo);

> >         if (!pdev)
> >                 return -ENOMEM;

As per kernel doc:
 * Returns &struct platform_device pointer on success, or ERR_PTR() on error.

-- 
With Best Regards,
Andy Shevchenko

  reply	other threads:[~2022-09-02  9:22 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-09-02  7:47 [PATCH v2 0/5] Misc hisi_lpc changes John Garry
2022-09-02  7:47 ` [PATCH v2 1/5] bus: hisi_lpc: Don't dereference fwnode handle John Garry
2022-09-02  7:47 ` [PATCH v2 2/5] bus: hisi_lpc: Use devm_platform_ioremap_resource John Garry
2022-09-02  7:47 ` [PATCH v2 3/5] bus: hisi_lpc: Correct error code for timeout John Garry
2022-09-02  7:47 ` [PATCH v2 4/5] bus: hisi_lpc: Don't guard ACPI IDs with ACPI_PTR() John Garry
2022-09-02  7:47 ` [PATCH v2 5/5] bus: hisi_lpc: Use platform_device_register_full() John Garry
2022-09-02  9:18   ` Andy Shevchenko
2022-09-02  9:21     ` Andy Shevchenko [this message]
2022-09-02  9:35       ` John Garry

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAHp75VeE2OZHzwG-KbTHYks+G=sLfyx9Yy1W=RxORTtet-vDnQ@mail.gmail.com' \
    --to=andy.shevchenko@gmail.com \
    --cc=andriy.shevchenko@linux.intel.com \
    --cc=john.garry@huawei.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linuxarm@huawei.com \
    --cc=rafael.j.wysocki@intel.com \
    --cc=soc@kernel.org \
    --cc=xuwei5@hisilicon.com \
    --cc=yangyingliang@huawei.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.