From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.6 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2512BC38A24 for ; Thu, 7 May 2020 09:11:06 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 06BCF208E4 for ; Thu, 7 May 2020 09:11:05 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="kVxUpNAU" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1725900AbgEGJLB (ORCPT ); Thu, 7 May 2020 05:11:01 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:55694 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725848AbgEGJLA (ORCPT ); Thu, 7 May 2020 05:11:00 -0400 Received: from mail-pl1-x643.google.com (mail-pl1-x643.google.com [IPv6:2607:f8b0:4864:20::643]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id AFE05C061A10; Thu, 7 May 2020 02:11:00 -0700 (PDT) Received: by mail-pl1-x643.google.com with SMTP id u10so1830978pls.8; Thu, 07 May 2020 02:11:00 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=JBT6KrKPDV5CjqbR8NDCy7mpTcDdeEp7C5NBrNvcrDY=; b=kVxUpNAU2X5gF8L0wi+DyBySR80rdREgOTCndFcxAxZ5o1/ZAGVfUqtsWKwLF0Pa/u 5VlziewE/8fe6NnCkGc3Ph2U6L2/oSl/f8uR72qd3yHNwaqdpv2dvNMAW1V6ZK6GmZpF XufJCfMyHxhC43y07FPPo6k6b4e6UWM1L9UIseHpeJakHL2EDV8nuqNy1lOlb7/Lvovx +Qr8DuTQ62XSzBiO9K+0Sy9zPbrwHFV3jEPKUwqIHxZfJQ6mIwmROmv/B8yYWXUa1+Hd afZ9rgolKYC6b4dwrtUFVeaOonYWK/bbkkYwAxSkHn4eQ5RuvJlmrbmxTSe3vpUhlwXO i/9g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=JBT6KrKPDV5CjqbR8NDCy7mpTcDdeEp7C5NBrNvcrDY=; b=mKk58xCj7IrgyFPzlX4HP0/1UQ6jAl4gS3mGosze9G5sR1uZeD1PUBQnBF2WwnQEqO ohTdy693f95D52qms3rIreJhdaml6/nLBabmw7IbHCGJyYV8CI1RFCLllXRnMOfp6q5s 9XBIHF31rQxYMCypBjcxUJlAT5QUmTRG6CKCSxfXD2HJi50kgHR/3sDr81dsc3rO96YM Qi9cAodITc1BqfNmcWElFvgAHzlV/NT0PSgaJZEwLNi4UsEqAmQVNiHZ+MGqpH/yQwUU 5AEArHZJ9QPll3uy7mfhIhAxT8mHMU4y5VwY3CjkYZodgDnXbEnC5741KUeFcxPLyf8g jr4g== X-Gm-Message-State: AGi0Pubt88k8/P26Bs2QGLaij4qRkB0W5jV4afOfG+rn+dI0oiShJZN4 6HdH2pYkC/06F0iaZWrFOPCScPBZe6cEkGdT88g= X-Google-Smtp-Source: APiQypLSmUDlB8+hESCKFexeV6yOLtQ3+jQd1hZaeXg3Qh7fHvakmbggZLIgn4AzvrXWYYT9Q3xQHb/UA6E5FX3UzOE= X-Received: by 2002:a17:90a:340c:: with SMTP id o12mr13739254pjb.22.1588842660053; Thu, 07 May 2020 02:11:00 -0700 (PDT) MIME-Version: 1.0 References: <20200505132905.10276-1-calvin.johnson@oss.nxp.com> <20200505132905.10276-6-calvin.johnson@oss.nxp.com> <20200507074435.GA10296@lsv03152.swis.in-blr01.nxp.com> In-Reply-To: <20200507074435.GA10296@lsv03152.swis.in-blr01.nxp.com> From: Andy Shevchenko Date: Thu, 7 May 2020 12:10:48 +0300 Message-ID: Subject: Re: [net-next PATCH v3 5/5] net: mdiobus: Introduce fwnode_mdiobus_register_phy() To: Calvin Johnson Cc: "Rafael J . Wysocki" , Russell King - ARM Linux admin , linux.cj@gmail.com, Jeremy Linton , Andrew Lunn , Florian Fainelli , Cristi Sovaiala , Florin Laurentiu Chiculita , Ioana Ciornei , Madalin Bucur , Greg Kroah-Hartman , Heikki Krogerus , Varun Sethi , "Rajesh V . Bikkina" , ACPI Devel Maling List , Linux Kernel Mailing List , Diana Madalina Craciun , netdev , Marcin Wojtas , Laurentiu Tudor , Makarand Pawagi , linux-arm Mailing List , Pankaj Bansal , "David S. Miller" , Heiner Kallweit Content-Type: text/plain; charset="UTF-8" Sender: linux-acpi-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-acpi@vger.kernel.org On Thu, May 7, 2020 at 10:44 AM Calvin Johnson wrote: > > On Tue, May 05, 2020 at 05:22:00PM +0300, Andy Shevchenko wrote: > > On Tue, May 5, 2020 at 4:30 PM Calvin Johnson > > wrote: ... > > > + bool is_c45 = false; > > > > Redundant assignment, see below. > > > > > + const char *cp; > > > + u32 phy_id; > > > + int rc; > > > + fwnode_property_read_string(child, "compatible", &cp); > > > > Consider rc = ...; otherwise you will have UB below. > > > > > + if (!strcmp(cp, "ethernet-phy-ieee802.3-c45")) > > > > UB! > > Thanks for the comments! I've considered all of them. > What is UB, by the way? :)- Undefined Behaviour. -- With Best Regards, Andy Shevchenko From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.5 required=3.0 tests=DKIM_ADSP_CUSTOM_MED, DKIM_SIGNED,DKIM_VALID,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 00501C38A2A for ; Thu, 7 May 2020 09:11:07 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id CBA0E2075E for ; Thu, 7 May 2020 09:11:06 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="YIn+LcYE"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="kVxUpNAU" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org CBA0E2075E Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:To:Subject:Message-ID:Date:From: In-Reply-To:References:MIME-Version:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=H4H9kl2nyXytyqv161cLKHYM4nrrNpEP/tSdF3JUhXU=; b=YIn+LcYEUm19kL iQH9G1zICv8lpazu8oZpjWtXAcqBGaAtHvCy9Mh5g/3r0D6Gtu0A4oTNMKXYPmbKloAcYdeKrbro7 y31hDgLQTo+oQyg+k/WRV838xeR+MAnZBCF0+MyjRKWdGSzY2D562YCzxn8TBzdN1XVJR1DCsMUGD UpEgKRlC5bf15Vea04OcgOSwSHN2ytlBPZyqvFIxgXmCUHDjoYtd3rgOdBvw1dnmyRWDMmpcKJJs4 vlUvUe7755BATD1yDdaTrah0rP5YvIJ0/1J/Twrt9B3fBh5TfuRbDp0gIQ9X0AMI+lv2Af42O+qkB rcZh3EFaG/OWPaQY6Pww==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1jWcYa-0003ZQ-D1; Thu, 07 May 2020 09:11:04 +0000 Received: from mail-pl1-x644.google.com ([2607:f8b0:4864:20::644]) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1jWcYX-0003Yz-EE for linux-arm-kernel@lists.infradead.org; Thu, 07 May 2020 09:11:02 +0000 Received: by mail-pl1-x644.google.com with SMTP id u22so1822329plq.12 for ; Thu, 07 May 2020 02:11:00 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=JBT6KrKPDV5CjqbR8NDCy7mpTcDdeEp7C5NBrNvcrDY=; b=kVxUpNAU2X5gF8L0wi+DyBySR80rdREgOTCndFcxAxZ5o1/ZAGVfUqtsWKwLF0Pa/u 5VlziewE/8fe6NnCkGc3Ph2U6L2/oSl/f8uR72qd3yHNwaqdpv2dvNMAW1V6ZK6GmZpF XufJCfMyHxhC43y07FPPo6k6b4e6UWM1L9UIseHpeJakHL2EDV8nuqNy1lOlb7/Lvovx +Qr8DuTQ62XSzBiO9K+0Sy9zPbrwHFV3jEPKUwqIHxZfJQ6mIwmROmv/B8yYWXUa1+Hd afZ9rgolKYC6b4dwrtUFVeaOonYWK/bbkkYwAxSkHn4eQ5RuvJlmrbmxTSe3vpUhlwXO i/9g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=JBT6KrKPDV5CjqbR8NDCy7mpTcDdeEp7C5NBrNvcrDY=; b=sGWFZVXvN09sHbUDRd0r8iUxuDQMFXyHHx8pKzy55+Gbks/spda5+YDZLQoBjuRNAc jY4bhkyfEpFptQvhp7mlOdjEeAZZlw//B2eDhEJ9KhLMhct6NKEcO7fZEDnBmNzoWZ3X YhC0/ypiF/vU5PPAI1L5St681u12yKx8HSVWknem/FKvWoTeqY5EMG/PgCdvEuF0lQTs UK4ODyY+1vKG2i8Rdho1RHAikA2t+5/Y4lJO/yQoUoDm80qAqTg/W9bEa9rWGfvfrpuD FxQLxlMo/8CtQ7a+6CswXUJuOrKmOAck1r8eqTJCVrfnlYi5GLW3QNmUlEotLV9bPS5K dwTg== X-Gm-Message-State: AGi0PubSde5bRgAjEsPI9+Kvdtw6kVTv4JISBk8rOF9N7dMssM35AWfa EjRl77SX0tejlpNa4IY1fCy/BRGHPsXLMQzdmgDmsSJQ X-Google-Smtp-Source: APiQypLSmUDlB8+hESCKFexeV6yOLtQ3+jQd1hZaeXg3Qh7fHvakmbggZLIgn4AzvrXWYYT9Q3xQHb/UA6E5FX3UzOE= X-Received: by 2002:a17:90a:340c:: with SMTP id o12mr13739254pjb.22.1588842660053; Thu, 07 May 2020 02:11:00 -0700 (PDT) MIME-Version: 1.0 References: <20200505132905.10276-1-calvin.johnson@oss.nxp.com> <20200505132905.10276-6-calvin.johnson@oss.nxp.com> <20200507074435.GA10296@lsv03152.swis.in-blr01.nxp.com> In-Reply-To: <20200507074435.GA10296@lsv03152.swis.in-blr01.nxp.com> From: Andy Shevchenko Date: Thu, 7 May 2020 12:10:48 +0300 Message-ID: Subject: Re: [net-next PATCH v3 5/5] net: mdiobus: Introduce fwnode_mdiobus_register_phy() To: Calvin Johnson X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200507_021101_500811_655D4CE3 X-CRM114-Status: GOOD ( 11.30 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Andrew Lunn , Heikki Krogerus , "Rafael J . Wysocki" , Cristi Sovaiala , Ioana Ciornei , Florian Fainelli , "Rajesh V . Bikkina" , Pankaj Bansal , Russell King - ARM Linux admin , Diana Madalina Craciun , ACPI Devel Maling List , Florin Laurentiu Chiculita , Madalin Bucur , Makarand Pawagi , Varun Sethi , Marcin Wojtas , linux-arm Mailing List , Laurentiu Tudor , Greg Kroah-Hartman , Linux Kernel Mailing List , Jeremy Linton , linux.cj@gmail.com, netdev , "David S. Miller" , Heiner Kallweit Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Thu, May 7, 2020 at 10:44 AM Calvin Johnson wrote: > > On Tue, May 05, 2020 at 05:22:00PM +0300, Andy Shevchenko wrote: > > On Tue, May 5, 2020 at 4:30 PM Calvin Johnson > > wrote: ... > > > + bool is_c45 = false; > > > > Redundant assignment, see below. > > > > > + const char *cp; > > > + u32 phy_id; > > > + int rc; > > > + fwnode_property_read_string(child, "compatible", &cp); > > > > Consider rc = ...; otherwise you will have UB below. > > > > > + if (!strcmp(cp, "ethernet-phy-ieee802.3-c45")) > > > > UB! > > Thanks for the comments! I've considered all of them. > What is UB, by the way? :)- Undefined Behaviour. -- With Best Regards, Andy Shevchenko _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel