From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 56FB0C4363D for ; Sat, 3 Oct 2020 08:18:22 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 1487A206DB for ; Sat, 3 Oct 2020 08:18:21 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="MKgL9seM" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1725772AbgJCISQ (ORCPT ); Sat, 3 Oct 2020 04:18:16 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:49772 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725601AbgJCISQ (ORCPT ); Sat, 3 Oct 2020 04:18:16 -0400 Received: from mail-pj1-x1042.google.com (mail-pj1-x1042.google.com [IPv6:2607:f8b0:4864:20::1042]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 0D070C0613D0; Sat, 3 Oct 2020 01:18:16 -0700 (PDT) Received: by mail-pj1-x1042.google.com with SMTP id b17so2390576pji.1; Sat, 03 Oct 2020 01:18:15 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc:content-transfer-encoding; bh=+BYI0/u6OpMKyw3gjay+S2BO3oSX5QDwS4LJbDTNE+0=; b=MKgL9seMPv5Xnyriytx9J/qyyRCDv2PJfCoEFgTjWbSksEOeFbBffkBa/WpD1oB1r7 xCerWCditb25c/6DdUc5pJt8z79TB3ojEvNDSs99M6Jom+NsmByO8xW0iNMLJiwurBwt mfDTfL2xASh5zpm9mBgG9wM1NmdAf6ZC+IIjYLai+nz5YO2zmR2jWemMXSUwWbSGmtSg kK2EDni/h0qbZWohVEb4CDHyoEBJhwUmR3VyCDTGVxVVfz7CQwDx34WCJo2pxi4xsCKK UBOY+1GWrj90IiUX655XMwlQgLr39jT/SbQmn/InoPRsuB9oVNGH9NfOH3HsZHPUwjjr N9dA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=+BYI0/u6OpMKyw3gjay+S2BO3oSX5QDwS4LJbDTNE+0=; b=dxe/ueZsMwXL28qV/jO8FcKhjK08rf5907FSemby0aGjFsr++2pq9uTS+0pXn6weQP kF1tAmtL7sBC7uW3Qy/w3Xhy6gpUawryFHO5TYT4IK22USq7wWk+z+6dMXqk4/16fAc2 Ofr2gNtEPAcpGoyRv9zogc5JBTFNmNcebq/WPKDxN9HroBXjAW2MaTtv5Ls892pxfYEy NKS4hmDVpKn38YCpy7NnVk6Ehb6ZJZKX5+n2E+QK8dNPOqt2Pb8q2jOTsq44d10Cjgft jGdRv4QyzFNAypUXg8OKdhfzpjvxkwAtUavLKcRDKL/CCZNU7o5F+uHcNlZO/XK05KYY K3+A== X-Gm-Message-State: AOAM533EXkh1cD7cgmkKs8RIzeQWbLpfZPiCCX/kg3XQCKQ2poNFnAgB i0WxekKiM1dlRDm40/aNIb12v5Y6iEJKC/CSbK0= X-Google-Smtp-Source: ABdhPJywj3WBJFKaEItRt4k8MI0LfRZi8eXCe2NuFYGEk4FbyHWblbBuqNEFRs63V6ZVeA12FGaXPyYhwrKDMBchlv4= X-Received: by 2002:a17:90a:b387:: with SMTP id e7mr6734978pjr.228.1601713095383; Sat, 03 Oct 2020 01:18:15 -0700 (PDT) MIME-Version: 1.0 References: <20200924192455.2484005-1-j.neuschaefer@gmx.net> <20200924192455.2484005-5-j.neuschaefer@gmx.net> <20200925063037.fcrmqvpe5noi3ef4@pengutronix.de> <20200927211044.GC2510@latitude> <20200928083546.gwu7ucx7os5yc5bn@pengutronix.de> <20201002233630.GB500800@latitude> In-Reply-To: <20201002233630.GB500800@latitude> From: Andy Shevchenko Date: Sat, 3 Oct 2020 11:17:58 +0300 Message-ID: Subject: Re: [PATCH v3 4/7] pwm: ntxec: Add driver for PWM function in Netronix EC To: =?UTF-8?Q?Jonathan_Neusch=C3=A4fer?= Cc: =?UTF-8?Q?Uwe_Kleine=2DK=C3=B6nig?= , Alexandre Belloni , Heiko Stuebner , devicetree , Linus Walleij , Thierry Reding , Sam Ravnborg , "open list:REAL TIME CLOCK (RTC) SUBSYSTEM" , Arnd Bergmann , Mauro Carvalho Chehab , Fabio Estevam , Daniel Palmer , Andreas Kemnade , NXP Linux Team , linux-pwm@vger.kernel.org, Stephan Gerhold , allen , Sascha Hauer , Lubomir Rintel , Rob Herring , Lee Jones , linux-arm Mailing List , Alessandro Zummo , Linux Kernel Mailing List , Mark Brown , Pengutronix Kernel Team , Heiko Stuebner , Josua Mayer , Shawn Guo , "David S. Miller" Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sat, Oct 3, 2020 at 2:36 AM Jonathan Neusch=C3=A4fer wrote: > On Mon, Sep 28, 2020 at 10:35:46AM +0200, Uwe Kleine-K=C3=B6nig wrote: > > On Sun, Sep 27, 2020 at 11:10:44PM +0200, Jonathan Neusch=C3=A4fer wrot= e: ... > > You can even check this with an LED using something like: > > > > pwm_apply(mypwm, {.enabled =3D true, .duty_cycle =3D $big, .perio= d =3D $big}); > > pwm_apply(mypwm, {.enabled =3D false, ... }); > > > > . If the period is completed the LED is on for $big ns, if not the LED > > is on for a timespan that is probably hardly noticable with the human > > eye. > > The longest configurable period is about 8ms, so it's not long enough to > see anything. However, after writing enable=3D0, it can take about a > second for the PWM signal to turn off... this hardware is a bit weird. Sounds like you have 1/128 divisor and off/on is done on lower frequency. (We saw PWMs with an additional 7-bit counter, reminds me Crystal Cove PMIC PWM). --=20 With Best Regards, Andy Shevchenko From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.7 required=3.0 tests=BAYES_00,DKIM_ADSP_CUSTOM_MED, DKIM_SIGNED,DKIM_VALID,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 59554C4363D for ; Sat, 3 Oct 2020 08:20:12 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id ED24E206DB for ; Sat, 3 Oct 2020 08:20:11 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="GU4cCAGT"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="MKgL9seM" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org ED24E206DB Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:To:Subject:Message-ID:Date:From:In-Reply-To: References:MIME-Version:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=fF7szTf+86dt10++SB4xWrvIf5rAvr7DXqVEx/C5nOE=; b=GU4cCAGTeBEwGlOo5N8qhd4u3 mC62YYVL/V79hR/W7rKie8VvqhcaVRrYnTEyyYdQgJO+oxq5P11Li7b91lmGmrwhycGMSKGwqnSIA tymi9rttXtv8ufOgzcMrQqTZBjncTbWMHjnJWgoFcSZIWADI3WDPk6sEZXGmJtxzgBvJPsST5T/sP QxUmnQkD6FlLuMkRE1oIJkpvCE7S8Q4Ms5ia2gh1D+pvma6zQJMoKMY6QtFjxzhXcSq/KvoDX/QhE pr3zGD5Z0PvlaIFAxWpLQvU4RZARjRJYIFJE4oESL3Ssf+sjIiTCgx1R2E0rXWkkrzwEmF452bq6n MUh3RGS8w==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1kOckH-0004F6-K2; Sat, 03 Oct 2020 08:18:21 +0000 Received: from mail-pj1-x1042.google.com ([2607:f8b0:4864:20::1042]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1kOckE-0004EV-Cg for linux-arm-kernel@lists.infradead.org; Sat, 03 Oct 2020 08:18:19 +0000 Received: by mail-pj1-x1042.google.com with SMTP id gm14so2578427pjb.2 for ; Sat, 03 Oct 2020 01:18:17 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc:content-transfer-encoding; bh=+BYI0/u6OpMKyw3gjay+S2BO3oSX5QDwS4LJbDTNE+0=; b=MKgL9seMPv5Xnyriytx9J/qyyRCDv2PJfCoEFgTjWbSksEOeFbBffkBa/WpD1oB1r7 xCerWCditb25c/6DdUc5pJt8z79TB3ojEvNDSs99M6Jom+NsmByO8xW0iNMLJiwurBwt mfDTfL2xASh5zpm9mBgG9wM1NmdAf6ZC+IIjYLai+nz5YO2zmR2jWemMXSUwWbSGmtSg kK2EDni/h0qbZWohVEb4CDHyoEBJhwUmR3VyCDTGVxVVfz7CQwDx34WCJo2pxi4xsCKK UBOY+1GWrj90IiUX655XMwlQgLr39jT/SbQmn/InoPRsuB9oVNGH9NfOH3HsZHPUwjjr N9dA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=+BYI0/u6OpMKyw3gjay+S2BO3oSX5QDwS4LJbDTNE+0=; b=lftNMK8bvtU4bll9ZgCJnk88V2LLtfloUjIxtIbJOrkZs5TWkY55v6SGbHr01cRr4c HcfocuAxn3zbPDPMU+wHspfhx2kklcAvv524o+p5s7d0tsOMNgYA/h/xtAHhLhZtth9w InuG6Wx6jV9ANf0D65gbiOrelkNlcU3xi3WdebTTWkC9aQotPkmHbqnajinAs1rnkdbF lV+IvUwE7PrtU1JeJoyVNUnKBPhgdwim8dWc2SP16nonG7xo7yGdRHXvXiGX4K6cRY9M y/gaAWGbvIBsXZzSAXbNN93lgLq4Srt7ObDZGF5J8/uKUx29xevmrA+6chFe/H1i8ngn 1rGg== X-Gm-Message-State: AOAM531Q15NFlVcPMrmTThLXnbDk1IFFmAagy12+wAfB3A2PH6SPXPxI /B9517R+czG0+B0iBkny9pZIlwPQQ5bKcu34Hks= X-Google-Smtp-Source: ABdhPJywj3WBJFKaEItRt4k8MI0LfRZi8eXCe2NuFYGEk4FbyHWblbBuqNEFRs63V6ZVeA12FGaXPyYhwrKDMBchlv4= X-Received: by 2002:a17:90a:b387:: with SMTP id e7mr6734978pjr.228.1601713095383; Sat, 03 Oct 2020 01:18:15 -0700 (PDT) MIME-Version: 1.0 References: <20200924192455.2484005-1-j.neuschaefer@gmx.net> <20200924192455.2484005-5-j.neuschaefer@gmx.net> <20200925063037.fcrmqvpe5noi3ef4@pengutronix.de> <20200927211044.GC2510@latitude> <20200928083546.gwu7ucx7os5yc5bn@pengutronix.de> <20201002233630.GB500800@latitude> In-Reply-To: <20201002233630.GB500800@latitude> From: Andy Shevchenko Date: Sat, 3 Oct 2020 11:17:58 +0300 Message-ID: Subject: Re: [PATCH v3 4/7] pwm: ntxec: Add driver for PWM function in Netronix EC To: =?UTF-8?Q?Jonathan_Neusch=C3=A4fer?= X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20201003_041818_462467_F2C72355 X-CRM114-Status: GOOD ( 19.53 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Alexandre Belloni , Heiko Stuebner , Sam Ravnborg , linux-pwm@vger.kernel.org, Linus Walleij , Thierry Reding , Fabio Estevam , "open list:REAL TIME CLOCK \(RTC\) SUBSYSTEM" , Arnd Bergmann , Mauro Carvalho Chehab , Lee Jones , Daniel Palmer , Andreas Kemnade , NXP Linux Team , =?UTF-8?Q?Uwe_Kleine=2DK=C3=B6nig?= , devicetree , Stephan Gerhold , allen , Sascha Hauer , Lubomir Rintel , Rob Herring , linux-arm Mailing List , Alessandro Zummo , Linux Kernel Mailing List , Mark Brown , Pengutronix Kernel Team , Heiko Stuebner , Josua Mayer , Shawn Guo , "David S. Miller" Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org T24gU2F0LCBPY3QgMywgMjAyMCBhdCAyOjM2IEFNIEpvbmF0aGFuIE5ldXNjaMOkZmVyCjxqLm5l dXNjaGFlZmVyQGdteC5uZXQ+IHdyb3RlOgo+IE9uIE1vbiwgU2VwIDI4LCAyMDIwIGF0IDEwOjM1 OjQ2QU0gKzAyMDAsIFV3ZSBLbGVpbmUtS8O2bmlnIHdyb3RlOgo+ID4gT24gU3VuLCBTZXAgMjcs IDIwMjAgYXQgMTE6MTA6NDRQTSArMDIwMCwgSm9uYXRoYW4gTmV1c2Now6RmZXIgd3JvdGU6Cgou Li4KCj4gPiBZb3UgY2FuIGV2ZW4gY2hlY2sgdGhpcyB3aXRoIGFuIExFRCB1c2luZyBzb21ldGhp bmcgbGlrZToKPiA+Cj4gPiAgICAgICBwd21fYXBwbHkobXlwd20sIHsuZW5hYmxlZCA9IHRydWUs IC5kdXR5X2N5Y2xlID0gJGJpZywgLnBlcmlvZCA9ICRiaWd9KTsKPiA+ICAgICAgIHB3bV9hcHBs eShteXB3bSwgey5lbmFibGVkID0gZmFsc2UsIC4uLiB9KTsKPiA+Cj4gPiAuIElmIHRoZSBwZXJp b2QgaXMgY29tcGxldGVkIHRoZSBMRUQgaXMgb24gZm9yICRiaWcgbnMsIGlmIG5vdCB0aGUgTEVE Cj4gPiBpcyBvbiBmb3IgYSB0aW1lc3BhbiB0aGF0IGlzIHByb2JhYmx5IGhhcmRseSBub3RpY2Fi bGUgd2l0aCB0aGUgaHVtYW4KPiA+IGV5ZS4KPgo+IFRoZSBsb25nZXN0IGNvbmZpZ3VyYWJsZSBw ZXJpb2QgaXMgYWJvdXQgOG1zLCBzbyBpdCdzIG5vdCBsb25nIGVub3VnaCB0bwo+IHNlZSBhbnl0 aGluZy4gSG93ZXZlciwgYWZ0ZXIgd3JpdGluZyBlbmFibGU9MCwgaXQgY2FuIHRha2UgYWJvdXQg YQo+IHNlY29uZCBmb3IgdGhlIFBXTSBzaWduYWwgdG8gdHVybiBvZmYuLi4gdGhpcyBoYXJkd2Fy ZSBpcyBhIGJpdCB3ZWlyZC4KClNvdW5kcyBsaWtlIHlvdSBoYXZlIDEvMTI4IGRpdmlzb3IgYW5k IG9mZi9vbiBpcyBkb25lIG9uIGxvd2VyCmZyZXF1ZW5jeS4gKFdlIHNhdyBQV01zIHdpdGggYW4g YWRkaXRpb25hbCA3LWJpdCBjb3VudGVyLCByZW1pbmRzIG1lCkNyeXN0YWwgQ292ZSBQTUlDIFBX TSkuCgotLSAKV2l0aCBCZXN0IFJlZ2FyZHMsCkFuZHkgU2hldmNoZW5rbwoKX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KbGludXgtYXJtLWtlcm5lbCBtYWls aW5nIGxpc3QKbGludXgtYXJtLWtlcm5lbEBsaXN0cy5pbmZyYWRlYWQub3JnCmh0dHA6Ly9saXN0 cy5pbmZyYWRlYWQub3JnL21haWxtYW4vbGlzdGluZm8vbGludXgtYXJtLWtlcm5lbAo=