From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8A373C433EF for ; Tue, 7 Jun 2022 10:02:30 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S240509AbiFGKC3 (ORCPT ); Tue, 7 Jun 2022 06:02:29 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:57026 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231598AbiFGKCY (ORCPT ); Tue, 7 Jun 2022 06:02:24 -0400 Received: from mail-ed1-x530.google.com (mail-ed1-x530.google.com [IPv6:2a00:1450:4864:20::530]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 012065F8A; Tue, 7 Jun 2022 03:02:21 -0700 (PDT) Received: by mail-ed1-x530.google.com with SMTP id b8so5598211edj.11; Tue, 07 Jun 2022 03:02:21 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=22+arTrvo1OVycmSNW1K2UlJf5Gwa3d1qjbfOB+SNko=; b=cV86jW/RsJl2yp7PQbKCu9MZT5W0tt917FmbE7LQFsCFYKR/+6cET4Vpqo+25wnjgH Ci5V7Bp8Up8EuYPAHO3jjHCFOBeJI7/y0JtD40tZDk70n9SRsYlWwMacFdyJcej3MuYn YHa1NFtpw1UpHqmRDJa3JE3i5kgVJ3QHciWa5nTAtSXl7gRaFiBHwF4eWIhTJgRiGA/C +ZBOFxeyZcCWx0n9g9uJaPaZdkng+08RtBfYgdDS8e0bch4RuB5Fzy4RQ99dxKSxDKtE SknIlasik/AwzDThv+THmwyXu9IDv6Z71IpqojJstsxoNAnln7n4A1fBPYwV1yj/pa2q Qz6Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=22+arTrvo1OVycmSNW1K2UlJf5Gwa3d1qjbfOB+SNko=; b=kF7fF8IrGnRruTDbxjpLctGz+sZFD/aWXX17GwwpcexadwC28p7xWcJbvhgR7lGF3o yENTQPosTkjt1eW/LZSkAEFIwHVXDRk7PuDpfQdgYJYrXPrD4jegnuIFGBkCqcjwEVdT sdhmUjCfbxQ7Qwf5EwOKA12phvfxq7EA6IVwabEleFEbY6F0/fI/gci28iEbhM2ldU6J f5U3phExocZ2ZcpdXyThtozeyWq+YxiBouVs5dQwnAiywprw4dUOE4P/V9ccqGekc6d/ N+ccrhRjP0Sz3BbJyIM5E+rduUHCClgggUjeoSlIvhLH19WjuOp1OyenB9J8oLaVx+vY xf0Q== X-Gm-Message-State: AOAM531DpHL4HnR19lCSpaFwhn9E9Eyi074nLzZmPg0530JQl98BA6UB eyOlnZo/aDSJ7Tb+Ixei5kgql6lfZKq3m7VVJEDw9dOykjwIVQ== X-Google-Smtp-Source: ABdhPJxS6upelYsko+7tcj8nHvCDiiy+DHldiJIy/Cp1PC5H7P/jz3xowxK1vVGqmmk/JXNwgtJXZ91S87U3T6RKsbE= X-Received: by 2002:aa7:d481:0:b0:42d:d5fd:f963 with SMTP id b1-20020aa7d481000000b0042dd5fdf963mr32390900edr.209.1654596140504; Tue, 07 Jun 2022 03:02:20 -0700 (PDT) MIME-Version: 1.0 References: <20220602083128.22540-1-jslaby@suse.cz> <20220602083128.22540-2-jslaby@suse.cz> <4d4549ef-f8f8-d0cb-6d27-e6200aa14048@kernel.org> In-Reply-To: From: Andy Shevchenko Date: Tue, 7 Jun 2022 12:01:44 +0200 Message-ID: Subject: Re: [PATCH 2/2] tty/vt: Makefile, add --unicode for loadkeys invocation To: Jiri Slaby Cc: Greg Kroah-Hartman , "open list:SERIAL DRIVERS" , Linux Kernel Mailing List Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Jun 7, 2022 at 11:58 AM Andy Shevchenko wrote: > > On Tue, Jun 7, 2022 at 7:42 AM Jiri Slaby wrote: > > On 06. 06. 22, 16:35, Andy Shevchenko wrote: > > > On Thu, Jun 2, 2022 at 12:30 PM Jiri Slaby wrote: > > >> > > >> For a long time, we generate unicode tables using loadkeys. So fix > > >> Makefile to use that flag too. > > > > > > generated > > > > We still do, but I didn't even know there is even a rule for that ;). > > I understand, but here is English stylistics like this. You need to > use past ind. or present perfect ("for a long time" dictates that). Okay, now even more explanation, present perfect should be used here. we have generated -- With Best Regards, Andy Shevchenko