From: Andy Shevchenko <andy.shevchenko@gmail.com>
To: u-boot@lists.denx.de
Subject: [PATCH v1] x86: acpi: Refactor XSDT handling in acpi_add_table()
Date: Fri, 28 Feb 2020 10:46:53 +0200 [thread overview]
Message-ID: <CAHp75VeUfKnrpc4KqA4=8SQpcnwTKYK3esrdR8w5R-2qYP6eTQ@mail.gmail.com> (raw)
In-Reply-To: <CAPnjgZ1ykn8aq4hpzhvPv5rfjWVpV2k-Pvnn5Uh45gx1jFzM1g@mail.gmail.com>
On Fri, Feb 28, 2020 at 1:41 AM Simon Glass <sjg@chromium.org> wrote:
> On Thu, 27 Feb 2020 at 06:00, Andy Shevchenko
> <andriy.shevchenko@linux.intel.com> wrote:
> Could you take a look at the ACPI series?
>
> It was sent out about a month ago and has a refactor to this function.
>
> u-boot-dm/coral-working
There are tons of changes. Care to point what changes are more
important (generic to all x86)?
P.S. Briefly looking at the last ~30 patches I can say that the idea
looks good, implementation needs more work. For example, there is
'linux,name' property. Shouldn't be referred at all. Linux names and
other type of enumerations is utterly opaque to the outside world.
On top of that, I think we rather need to have a conversion layer than
putting some names inside DT, like \_SB_.GPO0 should be generated
automatically from DT node. That said, I don't like DT being polluted
with non-DT stuff.
Also, I'm not sure how your rework helps ARM (or any other
architecture) people with their approach to ACPI enabling (most of the
files are under x86).
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2020-02-28 8:46 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-27 14:00 [PATCH v1] x86: acpi: Refactor XSDT handling in acpi_add_table() Andy Shevchenko
2020-02-27 23:40 ` Simon Glass
2020-02-28 8:46 ` Andy Shevchenko [this message]
2020-03-02 19:47 ` Simon Glass
2020-03-02 20:47 ` Andy Shevchenko
2020-03-02 23:36 ` Simon Glass
2020-03-03 2:54 ` Bin Meng
2020-03-03 9:22 ` Andy Shevchenko
2020-03-04 2:47 ` Simon Glass
2020-03-05 12:17 ` Andy Shevchenko
2020-03-29 2:13 ` Simon Glass
2020-03-29 21:00 ` Andy Shevchenko
2020-04-08 2:57 ` Simon Glass
2020-03-03 10:00 ` Antwort: " Wolfgang Wallner
2020-03-03 14:56 ` Andy Shevchenko
2020-03-25 6:48 ` Bin Meng
2020-03-25 6:54 ` Bin Meng
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAHp75VeUfKnrpc4KqA4=8SQpcnwTKYK3esrdR8w5R-2qYP6eTQ@mail.gmail.com' \
--to=andy.shevchenko@gmail.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.