From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.7 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 13FDAC64E8A for ; Wed, 2 Dec 2020 13:10:15 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id B660822240 for ; Wed, 2 Dec 2020 13:10:13 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730257AbgLBNJ7 (ORCPT ); Wed, 2 Dec 2020 08:09:59 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:58552 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729953AbgLBNJ5 (ORCPT ); Wed, 2 Dec 2020 08:09:57 -0500 Received: from mail-pf1-x444.google.com (mail-pf1-x444.google.com [IPv6:2607:f8b0:4864:20::444]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 07D5CC0613CF; Wed, 2 Dec 2020 05:09:17 -0800 (PST) Received: by mail-pf1-x444.google.com with SMTP id x24so1215504pfn.6; Wed, 02 Dec 2020 05:09:17 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=1z5RghUm6yb3JSWWMIkAtmUbvFsrsgFkS/6j5bM5Nz0=; b=cQc1Nna3s2K66qgZ0MEK53kPZT2w5huQsS3t5h1U1UW0Y+xL4rYxDIqVHOoqene60z uUpwdu4quEdrmBE8pCdyNyHkQ2bo8ka9TPYZk7Wfzc5eI0VEgVcol9owDkUu3WISbQKv EAfTy1l2FiD7myllfEG8r3zCFfBlQbtFAu+F/VTj0rxSaNHc5ukw71qmbe7GjUwm1e/W cpWNNOoGQ4HbT/tHMJojeQrR5VkXAAHpbXV5EZAljduJa0gPvSPJy9NOE8ZN3Gr0I8Zc uWkJEPI4rBNM2oEkXiFisfn1Re44dThXrA6F/IqGcej3dfrOAjYTYPV1Plu636suXADn ksTA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=1z5RghUm6yb3JSWWMIkAtmUbvFsrsgFkS/6j5bM5Nz0=; b=oGyIQaoUdQ7Kzh9mhNTcJ6s1PrbgfEqT/lLnocESasjrivAwowgbkgRNxKqLmu2qrT geNGnaytv3ceNG2aA6TSBSBDatif8Gj8HMZZLwH8ay9qBetlNMKA0Qszdg7Bx0rBpT8V iD3AmIsER24IRgcil7D2Knq7pjw7Rde84ZS53z0s4CciTiM5xITNRpzSYIWbSCSLZp/C hmH87PqvI0fAqXexq4iQ2Cv3XAP6nC7nZO0tQiFy7WLQKXByBiPlvBR6dfZ+j6DG+8H7 BHVSZXPhH3W5yUBhUkXszVp28Ks6RE7ZhNMQEqSqYJ0Wx5eIXchraYDwvf9SD/fvihkL Qywg== X-Gm-Message-State: AOAM533FH1zOMsSOUL9kd80aEJLzkUPcfvvywAWHp/IqCE0nTMXkmatA ftPTIzOG1nLdGan895GD5YAHHELnt5XJqYYmrNPSbcAgwI4= X-Google-Smtp-Source: ABdhPJx1w9uaqNh+tnBMkkXkuAfuVJPg0wYvh4NwfQg9ye3H+qABWR4bjKvRYKRJwe7+OwYdEebWsNm/vIq7sbGK52I= X-Received: by 2002:a62:ae0e:0:b029:198:11b4:6b6b with SMTP id q14-20020a62ae0e0000b029019811b46b6bmr2508125pff.73.1606914556601; Wed, 02 Dec 2020 05:09:16 -0800 (PST) MIME-Version: 1.0 References: <20201202150205.20150-1-muhammad.husaini.zulkifli@intel.com> <20201202122520.GD4077@smile.fi.intel.com> In-Reply-To: From: Andy Shevchenko Date: Wed, 2 Dec 2020 15:10:05 +0200 Message-ID: Subject: Re: [PATCH v6 0/4] mmc: sdhci-of-arasan: Enable UHS-1 support for Keem Bay SOC To: Ulf Hansson Cc: "Shevchenko, Andriy" , Linus Walleij , "Zulkifli, Muhammad Husaini" , Adrian Hunter , Michal Simek , "linux-mmc@vger.kernel.org" , Linux ARM , Linux Kernel Mailing List , "Raja Subramanian, Lakshmi Bai" , Wan Ahmad Zainie , Mark Gross Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Dec 2, 2020 at 2:44 PM Ulf Hansson wrote: > On Wed, 2 Dec 2020 at 13:24, Shevchenko, Andriy > wrote: > > On Wed, Dec 02, 2020 at 11:53:42AM +0100, Ulf Hansson wrote: > > > On Wed, 2 Dec 2020 at 08:02, wrote: > > > > ... > > > > > > Kindly help to review this patch set. > > > > > > This version looks a lot better to me, but I am still requesting you > > > to model the pinctrl correctly. I don't see a reason not to, but I may > > > have overlooked some things. > > > > I'm wondering why we need to mock up a pin control from something which has no > > pin control interface. It's rather communication with firmware that does pin > > control under the hood, but it also may be different hardware in the other / > > future generations. Would you accept mocking up the same calls over the kernel > > as pin control, as something else? > > Well, my point is that modeling this a pinctrl would keep the mmc > driver portable. Additionally, it's very common to manage pinctrls in > mmc drivers, so it's not like this is an entirely new thing that I > propose. > > If/when it turns out that there is a new HW having a different pinctrl > interface, it would just mean that we need a new pinctrl driver, but > can leave the mmc driver as is. My point is that it may be *not* a pin control at all. And in that case you will need to mock up (what exactly?) and update the MMC driver. -- With Best Regards, Andy Shevchenko From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.7 required=3.0 tests=BAYES_00,DKIM_ADSP_CUSTOM_MED, DKIM_SIGNED,DKIM_VALID,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 755AAC64E7C for ; Wed, 2 Dec 2020 13:10:37 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id E79182222F for ; Wed, 2 Dec 2020 13:10:36 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org E79182222F Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:To:Subject:Message-ID:Date:From:In-Reply-To: References:MIME-Version:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=Tmr3aSYeX1ff8BDGdBS+d+9wZSTXvt2biKiorlH1dEM=; b=rojhPyhi2p3hwGiM1Jqbr6Dle fn3wwe1Gv9fwCx/J038x14TSt/rKxKaouSb9fZT32WfG0RDAPBt8SyDmvpL/M8azm+/W/n7rlwFFF RH5rbry+ylwn50risIBu/EKx/tC0pP9cOD7pSEKx3eV6YbJ02KXd4GwMVa3ggWZFNRIel60BGYjwe 92oGVRh9JBgFmSaRKWzJv55nsLRl13893DhN+NVuKacZYt9Ix5ECDrt+zLm70bEnYodwY6VwB352v q3Nr5h7KFjblmTQmIoqzSrqS4gYEt/AcWwZAjR1TvqNhy5yhMNtUtZ37ODHOOr29fTfR5ZetGyU2l 7c26l3PSg==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1kkRso-0004MF-LP; Wed, 02 Dec 2020 13:09:22 +0000 Received: from mail-pf1-x443.google.com ([2607:f8b0:4864:20::443]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1kkRsm-0004KI-JV for linux-arm-kernel@lists.infradead.org; Wed, 02 Dec 2020 13:09:21 +0000 Received: by mail-pf1-x443.google.com with SMTP id t7so730630pfh.7 for ; Wed, 02 Dec 2020 05:09:18 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=1z5RghUm6yb3JSWWMIkAtmUbvFsrsgFkS/6j5bM5Nz0=; b=cQc1Nna3s2K66qgZ0MEK53kPZT2w5huQsS3t5h1U1UW0Y+xL4rYxDIqVHOoqene60z uUpwdu4quEdrmBE8pCdyNyHkQ2bo8ka9TPYZk7Wfzc5eI0VEgVcol9owDkUu3WISbQKv EAfTy1l2FiD7myllfEG8r3zCFfBlQbtFAu+F/VTj0rxSaNHc5ukw71qmbe7GjUwm1e/W cpWNNOoGQ4HbT/tHMJojeQrR5VkXAAHpbXV5EZAljduJa0gPvSPJy9NOE8ZN3Gr0I8Zc uWkJEPI4rBNM2oEkXiFisfn1Re44dThXrA6F/IqGcej3dfrOAjYTYPV1Plu636suXADn ksTA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=1z5RghUm6yb3JSWWMIkAtmUbvFsrsgFkS/6j5bM5Nz0=; b=Nbvl94yjZoFCOJEgAbvU8x3W6P8NK4TeT176PnkyNsMrnj5Pb6I/e01aq4DKiHmGq9 H59W5FIZuXWwcAabInTQ2McwF9z6qH8tBRoWyINxYHHIdWNQRWXrdKi1sPu/cMxkr9x1 Fn4kuHkRolFHnCmNYBaFT03YymXct4kamTZvG1btm2JKLoS/I7lFZsKxLNOL2p4i8YWZ CDRo1LwfKE05lHXP+K3GtYJxB3N82cXNmQzyhps18yM6YSct7eVoZHOEpd2IQOOtn9zd sKBn2xgJieTiJ1BBq7gpeg+dYRYIM4+CKto6dZJ/ok4fD5g20wT7n/tWM+H5fFKfQSV+ B0EA== X-Gm-Message-State: AOAM530DOBo2Y7BKqifAXMBUDWEMGH/t9c3mhcXew8MLtDWvNEnkclrM XpZs3Vna3EffAHE9a0g14R2RuhwdfQWIFaEtP+Y= X-Google-Smtp-Source: ABdhPJx1w9uaqNh+tnBMkkXkuAfuVJPg0wYvh4NwfQg9ye3H+qABWR4bjKvRYKRJwe7+OwYdEebWsNm/vIq7sbGK52I= X-Received: by 2002:a62:ae0e:0:b029:198:11b4:6b6b with SMTP id q14-20020a62ae0e0000b029019811b46b6bmr2508125pff.73.1606914556601; Wed, 02 Dec 2020 05:09:16 -0800 (PST) MIME-Version: 1.0 References: <20201202150205.20150-1-muhammad.husaini.zulkifli@intel.com> <20201202122520.GD4077@smile.fi.intel.com> In-Reply-To: From: Andy Shevchenko Date: Wed, 2 Dec 2020 15:10:05 +0200 Message-ID: Subject: Re: [PATCH v6 0/4] mmc: sdhci-of-arasan: Enable UHS-1 support for Keem Bay SOC To: Ulf Hansson X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20201202_080920_685412_B5BDEB5A X-CRM114-Status: GOOD ( 24.13 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Mark Gross , "Shevchenko, Andriy" , Linux Kernel Mailing List , Linus Walleij , "linux-mmc@vger.kernel.org" , Michal Simek , Adrian Hunter , Wan Ahmad Zainie , "Raja Subramanian, Lakshmi Bai" , "Zulkifli, Muhammad Husaini" , Linux ARM Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Wed, Dec 2, 2020 at 2:44 PM Ulf Hansson wrote: > On Wed, 2 Dec 2020 at 13:24, Shevchenko, Andriy > wrote: > > On Wed, Dec 02, 2020 at 11:53:42AM +0100, Ulf Hansson wrote: > > > On Wed, 2 Dec 2020 at 08:02, wrote: > > > > ... > > > > > > Kindly help to review this patch set. > > > > > > This version looks a lot better to me, but I am still requesting you > > > to model the pinctrl correctly. I don't see a reason not to, but I may > > > have overlooked some things. > > > > I'm wondering why we need to mock up a pin control from something which has no > > pin control interface. It's rather communication with firmware that does pin > > control under the hood, but it also may be different hardware in the other / > > future generations. Would you accept mocking up the same calls over the kernel > > as pin control, as something else? > > Well, my point is that modeling this a pinctrl would keep the mmc > driver portable. Additionally, it's very common to manage pinctrls in > mmc drivers, so it's not like this is an entirely new thing that I > propose. > > If/when it turns out that there is a new HW having a different pinctrl > interface, it would just mean that we need a new pinctrl driver, but > can leave the mmc driver as is. My point is that it may be *not* a pin control at all. And in that case you will need to mock up (what exactly?) and update the MMC driver. -- With Best Regards, Andy Shevchenko _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel