Re: [PATCH v4 09/10] iio: magnetometer: yas530: Introduce "chip_info" structure

From: Andy Shevchenko <andy.shevchenko@gmail.com>
To: Jakob Hauser <jahau@rocketmail.com>
Cc: Jonathan Cameron <jic23@kernel.org>,
	Lars-Peter Clausen <lars@metafoo.de>,
	Linus Walleij <linus.walleij@linaro.org>,
	Hans de Goede <hdegoede@redhat.com>,
	linux-iio <linux-iio@vger.kernel.org>,
	devicetree <devicetree@vger.kernel.org>,
	phone-devel@vger.kernel.org,
	~postmarketos/upstreaming@lists.sr.ht
Subject: Re: [PATCH v4 09/10] iio: magnetometer: yas530: Introduce "chip_info" structure
Date: Fri, 29 Jul 2022 18:13:14 +0200	[thread overview]
Message-ID: <CAHp75Ve_0srfZbvKJ4z8dW3Mp_a8CHSTqASSAY_SOJiD20K0eA@mail.gmail.com> (raw)
In-Reply-To: <c52e34f1-1cc3-4351-e03b-6b9bf83481b6@rocketmail.com>

On Fri, Jul 29, 2022 at 1:06 AM Jakob Hauser <jahau@rocketmail.com> wrote:
> On 27.07.22 19:39, Andy Shevchenko wrote:

...

Just a couple of remarks.

> Indeed, to my own surprise I found a solution with the 2D array:
>
>         static const char * const yas5xx_product_name[] = {
>                 "YAS530 MS-3E",
>                 "YAS532 MS-3R",
>                 "YAS533 MS-3F",
>         };
>
>         static const char * const yas5xx_version_name[][2] = {

yas5xx_version_names (note S at the end)

>                 [yas530] = { "A", "B" },
>                 [yas532] = { "AB", "AC" },
>                 [yas533] = { "AB", "AC" },
>         };
>
>         ...
>
>         struct yas5xx_chip_info {
>                 ...
>                 const char *product_name;
>                 const char * const *version_name;
>                 ...
>         };
>
>         static const struct yas5xx_chip_info yas5xx_chip_info_tbl[] = {
>                 [yas530] = {
>                         ...
>                         .product_name = yas5xx_product_name[0],
>                         .version_name = yas5xx_version_name[0],

Also 0 --> yas530 (use enum:ed indices)

>                 },
>         };
>

-- 
With Best Regards,
Andy Shevchenko