From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 20AAFC43334 for ; Fri, 15 Jul 2022 16:52:08 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232170AbiGOQwH (ORCPT ); Fri, 15 Jul 2022 12:52:07 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:36430 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229771AbiGOQwG (ORCPT ); Fri, 15 Jul 2022 12:52:06 -0400 Received: from mail-yw1-x112b.google.com (mail-yw1-x112b.google.com [IPv6:2607:f8b0:4864:20::112b]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 958684AD40; Fri, 15 Jul 2022 09:52:04 -0700 (PDT) Received: by mail-yw1-x112b.google.com with SMTP id 00721157ae682-31c9b70c382so52578327b3.6; Fri, 15 Jul 2022 09:52:04 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=Y3fEn7k6DEbC0BSZl5T1cKqr6t4t3jgvkJEo6o2VWJg=; b=MXGzp2L91pEJL+AcTAycFNXQ1RlDsP6v+gpGIgwODuesPa+p9Vkg4kB7S9nocynJGw Z6eSLqvXs18KQxUaf2JoIzf80wNgEBx5lb8hmQls/pYl5cmqKU6ZV2U293CPRD7pHPxN oVoCyNl0NZggmwruE29B+fIK5bXDrw9tjgIG3C8Nq+6m6OWBSRplWoiH96JI+OT2GKU0 e+tCPQwL8IYMCW95SAqKMM4ZmBlz4myO2waTWwKa21CY9s4W7s12O0mKU6NbZpFIBwjv WQndJpk7ul+2kIlNcx4SEPMyoKdY46YyQ2MP3qjPVvRdKZ8R3yH3WQfj2xLINnsHUnDO ZohA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=Y3fEn7k6DEbC0BSZl5T1cKqr6t4t3jgvkJEo6o2VWJg=; b=S8bBgDCaTx7vYdVu0Yek0FMny4kKKl+WrwSl5TTRd2XKbCkeygR8pl/TDjO1YjF8AG 4Z1aGufvqgTM35RWcjWnc5n5EY6OIe1Rnr0UzEbRL0JNpmX4jrDjHZLv0gK/H6d7GHXa Vy5Q69AfmUylfx/bILXyy4N6lU/zWToat/amV+aXqQRkHQjheDt747SAFibf1JmkBaf7 /Btl3we1bhiVeeuzFtrD2Ix3i6YgWuQ0+W1T+ZRHn9u39P7fZBr7ReQP1SzfmSe5uM19 3q56cYFxZBKDIQZSNQiXVKM/icdnVtgjRR4MkU37fRBFixED1tFTnfqIh4CQGlJDuRC+ EB+g== X-Gm-Message-State: AJIora/z0DRec7AclL7m7KjlxLTV9vQI201wOsVYKCzi8pBbzuaHubgN U7d39gjiA8yqx5HRvpiTr7KIvmn31RuS/QU+B1A= X-Google-Smtp-Source: AGRyM1sCY24F2pEPhG1uDrQQmbeNKcxn2P0g2UtmOwj7faRUDuEi5O71VSZCHL0+DLUg4GOwi/Ey7mykcBwsz36AuRU= X-Received: by 2002:a81:54c1:0:b0:31d:ec18:fd5d with SMTP id i184-20020a8154c1000000b0031dec18fd5dmr7130568ywb.277.1657903923745; Fri, 15 Jul 2022 09:52:03 -0700 (PDT) MIME-Version: 1.0 References: <20220715112607.591-1-peterwu.pub@gmail.com> <20220715112607.591-11-peterwu.pub@gmail.com> In-Reply-To: <20220715112607.591-11-peterwu.pub@gmail.com> From: Andy Shevchenko Date: Fri, 15 Jul 2022 18:51:27 +0200 Message-ID: Subject: Re: [PATCH v5 10/13] power: supply: mt6370: Add MediaTek MT6370 charger driver To: ChiaEn Wu Cc: Lee Jones , Daniel Thompson , Jingoo Han , Pavel Machek , Rob Herring , Krzysztof Kozlowski , Matthias Brugger , Sebastian Reichel , Chunfeng Yun , Greg Kroah-Hartman , Jonathan Cameron , Lars-Peter Clausen , Liam Girdwood , Mark Brown , Guenter Roeck , "Krogerus, Heikki" , Helge Deller , ChiaEn Wu , Alice Chen , cy_huang , dri-devel , Linux LED Subsystem , devicetree , linux-arm Mailing List , "moderated list:ARM/Mediatek SoC support" , Linux Kernel Mailing List , Linux PM , USB , linux-iio , "open list:FRAMEBUFFER LAYER" , szuni chen Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-leds@vger.kernel.org On Fri, Jul 15, 2022 at 1:29 PM ChiaEn Wu wrote: > > From: ChiaEn Wu > > MediaTek MT6370 is a SubPMIC consisting of a single cell battery charger > with ADC monitoring, RGB LEDs, dual channel flashlight, WLED backlight > driver, display bias voltage supply, one general purpose LDO, and the > USB Type-C & PD controller complies with the latest USB Type-C and PD > standards. > > This adds MediaTek MT6370 Charger driver support. The charger module > of MT6370 supports High-Accuracy Voltage/Current Regulation, > Average Input Current Regulation, Battery Temperature Sensing, > Over-Temperature Protection, DPDM Detection for BC1.2. ... > +static int mt6370_chg_probe(struct platform_device *pdev) > +{ > + int ret; > + struct mt6370_priv *priv; > + > + priv = devm_kzalloc(&pdev->dev, sizeof(*priv), GFP_KERNEL); > + if (!priv) > + return -ENOMEM; > + > + priv->dev = &pdev->dev; > + > + priv->regmap = dev_get_regmap(pdev->dev.parent, NULL); > + if (!priv->regmap) > + return dev_err_probe(&pdev->dev, -ENODEV, > + "Failed to get regmap\n"); > + > + ret = mt6370_chg_init_rmap_fields(priv); > + if (ret) > + return dev_err_probe(&pdev->dev, ret, > + "Failed to init regmap fields\n"); > + > + platform_set_drvdata(pdev, priv); > + > + priv->iio_adcs = devm_iio_channel_get_all(priv->dev); > + if (IS_ERR(priv->iio_adcs)) > + return dev_err_probe(&pdev->dev, PTR_ERR(priv->iio_adcs), > + "Failed to get iio adc\n"); > + > + ret = mt6370_chg_init_otg_regulator(priv); > + if (ret) > + return dev_err_probe(&pdev->dev, ret, > + "Failed to init otg regulator\n"); > + > + ret = mt6370_chg_init_psy(priv); > + if (ret) > + return dev_err_probe(&pdev->dev, ret, "Failed to init psy\n"); > + > + mutex_init(&priv->attach_lock); > + priv->attach = MT6370_ATTACH_STAT_DETACH; > + > + priv->wq = create_singlethread_workqueue(dev_name(priv->dev)); > + if (IS_ERR(priv->wq)) > + return dev_err_probe(priv->dev, PTR_ERR(priv->wq), > + "Failed to create workqueue\n"); You need either wrap mutex to be deallocated by devm or don't use dev_err_probe() here. > + INIT_WORK(&priv->bc12_work, mt6370_chg_bc12_work_func); > + INIT_DELAYED_WORK(&priv->mivr_dwork, mt6370_chg_mivr_dwork_func); > + > + ret = mt6370_chg_init_setting(priv); > + if (ret) { > + dev_err(&pdev->dev, "Failed to init mt6370 charger setting\n"); > + goto probe_out; > + } > + > + ret = mt6370_chg_init_irq(priv); > + if (ret) > + goto probe_out; > + > + mt6370_chg_pwr_rdy_check(priv); > + > + return 0; > + > +probe_out: > + cancel_delayed_work_sync(&priv->mivr_dwork); > + flush_workqueue(priv->wq); > + destroy_workqueue(priv->wq); > + mutex_destroy(&priv->attach_lock); > + > + return ret; > +} > + > +static int mt6370_chg_remove(struct platform_device *pdev) > +{ > + struct mt6370_priv *priv = platform_get_drvdata(pdev); > + > + cancel_delayed_work_sync(&priv->mivr_dwork); > + flush_workqueue(priv->wq); > + destroy_workqueue(priv->wq); > + mutex_destroy(&priv->attach_lock); > + > + return 0; > +} -- With Best Regards, Andy Shevchenko From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 7C34AC433EF for ; Fri, 15 Jul 2022 16:57:18 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:Cc:To:Subject:Message-ID:Date:From: In-Reply-To:References:MIME-Version:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=NdRp8OgjeiMl4SiGiGudm9mrFmf26RpfzGou1OZxjvg=; b=wGqm7JPKJOxEHB cDOJ34zD1IT4BIu76YOSpyo4dVBGS2FLENkd/PfeSAtlZrdZzFfAmsjfM9hH3UVZK9GEUXtJxH/48 s6NhN65uaJS6ywbbeLT+whMOUTrOMNlIE3AM1xrvyVLLBBQbXQZtyIMBSBueywEN6W1qnhiiUpOKk qWU1krKD4Vod78bfWA89GLNoC7bn24J6KFbQqr11gowJ88piRe++b1TCwmgLwrNrCHV0gYPDVGHwQ RdfsP+VkL9lNjDNW2N7K7dbnKPAmYbYDmolZHf+oX5Hdh8AksqwfvJkVHMtX8f/96QU+h11TQGzw1 g4QZ0NoNvEJbRCTglQ8Q==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1oCOXy-008wu5-RZ; Fri, 15 Jul 2022 16:52:10 +0000 Received: from mail-yw1-x1136.google.com ([2607:f8b0:4864:20::1136]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1oCOXv-008wtC-Ra; Fri, 15 Jul 2022 16:52:09 +0000 Received: by mail-yw1-x1136.google.com with SMTP id 00721157ae682-31cf1adbf92so52659257b3.4; Fri, 15 Jul 2022 09:52:04 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=Y3fEn7k6DEbC0BSZl5T1cKqr6t4t3jgvkJEo6o2VWJg=; b=MXGzp2L91pEJL+AcTAycFNXQ1RlDsP6v+gpGIgwODuesPa+p9Vkg4kB7S9nocynJGw Z6eSLqvXs18KQxUaf2JoIzf80wNgEBx5lb8hmQls/pYl5cmqKU6ZV2U293CPRD7pHPxN oVoCyNl0NZggmwruE29B+fIK5bXDrw9tjgIG3C8Nq+6m6OWBSRplWoiH96JI+OT2GKU0 e+tCPQwL8IYMCW95SAqKMM4ZmBlz4myO2waTWwKa21CY9s4W7s12O0mKU6NbZpFIBwjv WQndJpk7ul+2kIlNcx4SEPMyoKdY46YyQ2MP3qjPVvRdKZ8R3yH3WQfj2xLINnsHUnDO ZohA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=Y3fEn7k6DEbC0BSZl5T1cKqr6t4t3jgvkJEo6o2VWJg=; b=okyHFHqcBMnw+IsttZFttM33goR3+NHYU+yjyK62O7BlA1g+vOyuqcao+oIuYWI3dU 2sSqpxCn558F45jDkBb0Lzn1Oq0M91vXN7XzEyt+NH7RQUzUsc+x9r2HSDQEHQIflJRp egzww0/KABMqcEqc8u3y/ON3GCrB1G9bIh76GJwgJpr6CBJC30gqxF7i9ZdER9Q0oCIR i1On4V8K2rXjg6bTL/wMM7x7MwKtGygzDGIYqbNTbwRSZNJpa7g50NzXVoLgxWXr3mSv WZVoTzvA1KsSzdnKy6Co1dFI5tvp/DQT7XRGPd22027Q0CzaNc4EP9atukkR5TzaQVIQ l1Jg== X-Gm-Message-State: AJIora+PMsV7fB3q5vPgL1IiZStflBMiwDEDdCHlmk4h2g7LtyJ0RxSG z4/XCvXa3r7xTmCC9BRTREi8pS3oH06oiMtov/w= X-Google-Smtp-Source: AGRyM1sCY24F2pEPhG1uDrQQmbeNKcxn2P0g2UtmOwj7faRUDuEi5O71VSZCHL0+DLUg4GOwi/Ey7mykcBwsz36AuRU= X-Received: by 2002:a81:54c1:0:b0:31d:ec18:fd5d with SMTP id i184-20020a8154c1000000b0031dec18fd5dmr7130568ywb.277.1657903923745; Fri, 15 Jul 2022 09:52:03 -0700 (PDT) MIME-Version: 1.0 References: <20220715112607.591-1-peterwu.pub@gmail.com> <20220715112607.591-11-peterwu.pub@gmail.com> In-Reply-To: <20220715112607.591-11-peterwu.pub@gmail.com> From: Andy Shevchenko Date: Fri, 15 Jul 2022 18:51:27 +0200 Message-ID: Subject: Re: [PATCH v5 10/13] power: supply: mt6370: Add MediaTek MT6370 charger driver To: ChiaEn Wu Cc: Lee Jones , Daniel Thompson , Jingoo Han , Pavel Machek , Rob Herring , Krzysztof Kozlowski , Matthias Brugger , Sebastian Reichel , Chunfeng Yun , Greg Kroah-Hartman , Jonathan Cameron , Lars-Peter Clausen , Liam Girdwood , Mark Brown , Guenter Roeck , "Krogerus, Heikki" , Helge Deller , ChiaEn Wu , Alice Chen , cy_huang , dri-devel , Linux LED Subsystem , devicetree , linux-arm Mailing List , "moderated list:ARM/Mediatek SoC support" , Linux Kernel Mailing List , Linux PM , USB , linux-iio , "open list:FRAMEBUFFER LAYER" , szuni chen X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220715_095207_953796_19AEA84B X-CRM114-Status: GOOD ( 17.29 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Fri, Jul 15, 2022 at 1:29 PM ChiaEn Wu wrote: > > From: ChiaEn Wu > > MediaTek MT6370 is a SubPMIC consisting of a single cell battery charger > with ADC monitoring, RGB LEDs, dual channel flashlight, WLED backlight > driver, display bias voltage supply, one general purpose LDO, and the > USB Type-C & PD controller complies with the latest USB Type-C and PD > standards. > > This adds MediaTek MT6370 Charger driver support. The charger module > of MT6370 supports High-Accuracy Voltage/Current Regulation, > Average Input Current Regulation, Battery Temperature Sensing, > Over-Temperature Protection, DPDM Detection for BC1.2. ... > +static int mt6370_chg_probe(struct platform_device *pdev) > +{ > + int ret; > + struct mt6370_priv *priv; > + > + priv = devm_kzalloc(&pdev->dev, sizeof(*priv), GFP_KERNEL); > + if (!priv) > + return -ENOMEM; > + > + priv->dev = &pdev->dev; > + > + priv->regmap = dev_get_regmap(pdev->dev.parent, NULL); > + if (!priv->regmap) > + return dev_err_probe(&pdev->dev, -ENODEV, > + "Failed to get regmap\n"); > + > + ret = mt6370_chg_init_rmap_fields(priv); > + if (ret) > + return dev_err_probe(&pdev->dev, ret, > + "Failed to init regmap fields\n"); > + > + platform_set_drvdata(pdev, priv); > + > + priv->iio_adcs = devm_iio_channel_get_all(priv->dev); > + if (IS_ERR(priv->iio_adcs)) > + return dev_err_probe(&pdev->dev, PTR_ERR(priv->iio_adcs), > + "Failed to get iio adc\n"); > + > + ret = mt6370_chg_init_otg_regulator(priv); > + if (ret) > + return dev_err_probe(&pdev->dev, ret, > + "Failed to init otg regulator\n"); > + > + ret = mt6370_chg_init_psy(priv); > + if (ret) > + return dev_err_probe(&pdev->dev, ret, "Failed to init psy\n"); > + > + mutex_init(&priv->attach_lock); > + priv->attach = MT6370_ATTACH_STAT_DETACH; > + > + priv->wq = create_singlethread_workqueue(dev_name(priv->dev)); > + if (IS_ERR(priv->wq)) > + return dev_err_probe(priv->dev, PTR_ERR(priv->wq), > + "Failed to create workqueue\n"); You need either wrap mutex to be deallocated by devm or don't use dev_err_probe() here. > + INIT_WORK(&priv->bc12_work, mt6370_chg_bc12_work_func); > + INIT_DELAYED_WORK(&priv->mivr_dwork, mt6370_chg_mivr_dwork_func); > + > + ret = mt6370_chg_init_setting(priv); > + if (ret) { > + dev_err(&pdev->dev, "Failed to init mt6370 charger setting\n"); > + goto probe_out; > + } > + > + ret = mt6370_chg_init_irq(priv); > + if (ret) > + goto probe_out; > + > + mt6370_chg_pwr_rdy_check(priv); > + > + return 0; > + > +probe_out: > + cancel_delayed_work_sync(&priv->mivr_dwork); > + flush_workqueue(priv->wq); > + destroy_workqueue(priv->wq); > + mutex_destroy(&priv->attach_lock); > + > + return ret; > +} > + > +static int mt6370_chg_remove(struct platform_device *pdev) > +{ > + struct mt6370_priv *priv = platform_get_drvdata(pdev); > + > + cancel_delayed_work_sync(&priv->mivr_dwork); > + flush_workqueue(priv->wq); > + destroy_workqueue(priv->wq); > + mutex_destroy(&priv->attach_lock); > + > + return 0; > +} -- With Best Regards, Andy Shevchenko _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id D9197C433EF for ; Sat, 16 Jul 2022 14:39:17 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 6786E10F8CB; Sat, 16 Jul 2022 14:35:57 +0000 (UTC) Received: from mail-yw1-x112d.google.com (mail-yw1-x112d.google.com [IPv6:2607:f8b0:4864:20::112d]) by gabe.freedesktop.org (Postfix) with ESMTPS id 9D80810E028 for ; Fri, 15 Jul 2022 16:52:04 +0000 (UTC) Received: by mail-yw1-x112d.google.com with SMTP id 00721157ae682-31c8a1e9e33so52552727b3.5 for ; Fri, 15 Jul 2022 09:52:04 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=Y3fEn7k6DEbC0BSZl5T1cKqr6t4t3jgvkJEo6o2VWJg=; b=MXGzp2L91pEJL+AcTAycFNXQ1RlDsP6v+gpGIgwODuesPa+p9Vkg4kB7S9nocynJGw Z6eSLqvXs18KQxUaf2JoIzf80wNgEBx5lb8hmQls/pYl5cmqKU6ZV2U293CPRD7pHPxN oVoCyNl0NZggmwruE29B+fIK5bXDrw9tjgIG3C8Nq+6m6OWBSRplWoiH96JI+OT2GKU0 e+tCPQwL8IYMCW95SAqKMM4ZmBlz4myO2waTWwKa21CY9s4W7s12O0mKU6NbZpFIBwjv WQndJpk7ul+2kIlNcx4SEPMyoKdY46YyQ2MP3qjPVvRdKZ8R3yH3WQfj2xLINnsHUnDO ZohA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=Y3fEn7k6DEbC0BSZl5T1cKqr6t4t3jgvkJEo6o2VWJg=; b=UC0fZiraObbdEI4sghO8Ljr1Rp62rdUCY61/P0fQ6hwJ+IskUMMtqtmuzx8OQHeH+O qZEiFK0+GAoGnmTwJuayfqG2GuiQ49jaoC0U/x1l63I9ZyZNsz9p1j3Nzpx+w8G5Tbmq QCSwZgjj2xcIxVmFzskqFHz6ycx7l8qaMYtXRwBp5eRc2KFZ9ki0zViMqhBp46u16ftr u+u9dxMZi/L3gocx9xa2Bn8Na1321lv5PeppRj0fLl7SuZwwPqdG913TpxoiG1yak3ET ot9dUT1/JP5CdzGPYQTI/eC8XvlAsc2bMU0qsu0X0of48nshPmBTFkfxWqHaczQCcoP/ cDCw== X-Gm-Message-State: AJIora++sCrmrPGDovZtuNfI2qm4o33V2MXwsRQzAZSyXoOt5k4mZv29 jTB6Lio7m9nFT8h0OScaXsCwts96iU92vWAqShs= X-Google-Smtp-Source: AGRyM1sCY24F2pEPhG1uDrQQmbeNKcxn2P0g2UtmOwj7faRUDuEi5O71VSZCHL0+DLUg4GOwi/Ey7mykcBwsz36AuRU= X-Received: by 2002:a81:54c1:0:b0:31d:ec18:fd5d with SMTP id i184-20020a8154c1000000b0031dec18fd5dmr7130568ywb.277.1657903923745; Fri, 15 Jul 2022 09:52:03 -0700 (PDT) MIME-Version: 1.0 References: <20220715112607.591-1-peterwu.pub@gmail.com> <20220715112607.591-11-peterwu.pub@gmail.com> In-Reply-To: <20220715112607.591-11-peterwu.pub@gmail.com> From: Andy Shevchenko Date: Fri, 15 Jul 2022 18:51:27 +0200 Message-ID: Subject: Re: [PATCH v5 10/13] power: supply: mt6370: Add MediaTek MT6370 charger driver To: ChiaEn Wu Content-Type: text/plain; charset="UTF-8" X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: "open list:FRAMEBUFFER LAYER" , "Krogerus, Heikki" , Krzysztof Kozlowski , Alice Chen , linux-iio , dri-devel , Liam Girdwood , cy_huang , Pavel Machek , Lee Jones , Linux LED Subsystem , Daniel Thompson , Helge Deller , Rob Herring , Chunfeng Yun , Guenter Roeck , devicetree , Linux PM , szuni chen , Mark Brown , "moderated list:ARM/Mediatek SoC support" , Matthias Brugger , linux-arm Mailing List , Jingoo Han , USB , Sebastian Reichel , Linux Kernel Mailing List , ChiaEn Wu , Greg Kroah-Hartman , Jonathan Cameron Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" On Fri, Jul 15, 2022 at 1:29 PM ChiaEn Wu wrote: > > From: ChiaEn Wu > > MediaTek MT6370 is a SubPMIC consisting of a single cell battery charger > with ADC monitoring, RGB LEDs, dual channel flashlight, WLED backlight > driver, display bias voltage supply, one general purpose LDO, and the > USB Type-C & PD controller complies with the latest USB Type-C and PD > standards. > > This adds MediaTek MT6370 Charger driver support. The charger module > of MT6370 supports High-Accuracy Voltage/Current Regulation, > Average Input Current Regulation, Battery Temperature Sensing, > Over-Temperature Protection, DPDM Detection for BC1.2. ... > +static int mt6370_chg_probe(struct platform_device *pdev) > +{ > + int ret; > + struct mt6370_priv *priv; > + > + priv = devm_kzalloc(&pdev->dev, sizeof(*priv), GFP_KERNEL); > + if (!priv) > + return -ENOMEM; > + > + priv->dev = &pdev->dev; > + > + priv->regmap = dev_get_regmap(pdev->dev.parent, NULL); > + if (!priv->regmap) > + return dev_err_probe(&pdev->dev, -ENODEV, > + "Failed to get regmap\n"); > + > + ret = mt6370_chg_init_rmap_fields(priv); > + if (ret) > + return dev_err_probe(&pdev->dev, ret, > + "Failed to init regmap fields\n"); > + > + platform_set_drvdata(pdev, priv); > + > + priv->iio_adcs = devm_iio_channel_get_all(priv->dev); > + if (IS_ERR(priv->iio_adcs)) > + return dev_err_probe(&pdev->dev, PTR_ERR(priv->iio_adcs), > + "Failed to get iio adc\n"); > + > + ret = mt6370_chg_init_otg_regulator(priv); > + if (ret) > + return dev_err_probe(&pdev->dev, ret, > + "Failed to init otg regulator\n"); > + > + ret = mt6370_chg_init_psy(priv); > + if (ret) > + return dev_err_probe(&pdev->dev, ret, "Failed to init psy\n"); > + > + mutex_init(&priv->attach_lock); > + priv->attach = MT6370_ATTACH_STAT_DETACH; > + > + priv->wq = create_singlethread_workqueue(dev_name(priv->dev)); > + if (IS_ERR(priv->wq)) > + return dev_err_probe(priv->dev, PTR_ERR(priv->wq), > + "Failed to create workqueue\n"); You need either wrap mutex to be deallocated by devm or don't use dev_err_probe() here. > + INIT_WORK(&priv->bc12_work, mt6370_chg_bc12_work_func); > + INIT_DELAYED_WORK(&priv->mivr_dwork, mt6370_chg_mivr_dwork_func); > + > + ret = mt6370_chg_init_setting(priv); > + if (ret) { > + dev_err(&pdev->dev, "Failed to init mt6370 charger setting\n"); > + goto probe_out; > + } > + > + ret = mt6370_chg_init_irq(priv); > + if (ret) > + goto probe_out; > + > + mt6370_chg_pwr_rdy_check(priv); > + > + return 0; > + > +probe_out: > + cancel_delayed_work_sync(&priv->mivr_dwork); > + flush_workqueue(priv->wq); > + destroy_workqueue(priv->wq); > + mutex_destroy(&priv->attach_lock); > + > + return ret; > +} > + > +static int mt6370_chg_remove(struct platform_device *pdev) > +{ > + struct mt6370_priv *priv = platform_get_drvdata(pdev); > + > + cancel_delayed_work_sync(&priv->mivr_dwork); > + flush_workqueue(priv->wq); > + destroy_workqueue(priv->wq); > + mutex_destroy(&priv->attach_lock); > + > + return 0; > +} -- With Best Regards, Andy Shevchenko