From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 74F90C43334 for ; Mon, 25 Jul 2022 08:25:48 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231527AbiGYIZr (ORCPT ); Mon, 25 Jul 2022 04:25:47 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:42354 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229822AbiGYIZq (ORCPT ); Mon, 25 Jul 2022 04:25:46 -0400 Received: from mail-ej1-x635.google.com (mail-ej1-x635.google.com [IPv6:2a00:1450:4864:20::635]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 29A1E13E9B; Mon, 25 Jul 2022 01:25:45 -0700 (PDT) Received: by mail-ej1-x635.google.com with SMTP id tk8so19173658ejc.7; Mon, 25 Jul 2022 01:25:45 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=J5rSRKJzZCEe75lE89H4BacTqhlHPMQzJe7RV2ORfWI=; b=BNlVjsxRro5TG97838xZbVcQ/pG/LD+g/7G/AjwrIrlPvPS37j9HRk59ZPvQZFMbo9 MnOMniee2k168J7vlVevltwedsYw1fwJcNYMweUNuLPFL7JEp9m9CEssAgQLNBEXPpLX 65np3ghAZ/JI0ou7IY+VAdXdeEM9Dx5l6K3VMtdxVw5MaZ+JcN9Mz6qTKX+a72GlbThf YgqMy4pPKGjxlN3v8ojq6p7cX1h0ysW9lnKZ5pLCEPb56UCWlozkB+OoACaoaIIUBRbZ /V/wW4p+YYsXXLnpTvXofuXoBPwxmOEVHWVRTZH6OK6PGjSYJaBn82vKtB7a1B3eaVvy gAUg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=J5rSRKJzZCEe75lE89H4BacTqhlHPMQzJe7RV2ORfWI=; b=KmLawa8UXbcqBjf0QeFvLCZ0gZkepy9msxh2TcI45J0/AKstyDM2vjS0jhEAhMMHcC XINhzzdIYVcgr/l48JvCkbsxVjj7kCBVvm8pju+RoZsEEyuUtcuCpYdfwDZcQigmYPRI 7cflqhlNiNtCzGshQnufoaJoVY8PeAQr/5sonhpTcD4hCt8GwwjsLrZbP5Es3OdbsNqR BEyW4qunCBOr9c4YGiDmIRuC8Metmp/9wifmWsDyLzBeg781ZGF7VSTjkC3i4CE6kj35 S5I0eRZsw2MAO2G+FinrnraRM0k1vuHs0IDIIfWGgq55Z5a4+4yqqfkGD4YEkTrIjMJT QC1w== X-Gm-Message-State: AJIora+hU7VC0LcDSE7wGV5cpWcVpLHCTv4zPhAEsYsFqMl0u7nfMIIr BawBilq4Fe/pPdBgumbhzhronxEJSql//Xjj4ks= X-Google-Smtp-Source: AGRyM1tb8lf0258KwCgCSc1j2TNtucrsLChWD53/F5ZAYHmenBBMp0FJqJ/Hs5trX2iqStdOTyF6IVkbw5ytFnaOucM= X-Received: by 2002:a17:906:8a4a:b0:72b:5b23:3065 with SMTP id gx10-20020a1709068a4a00b0072b5b233065mr9396194ejc.557.1658737543426; Mon, 25 Jul 2022 01:25:43 -0700 (PDT) MIME-Version: 1.0 References: <20220722102407.2205-1-peterwu.pub@gmail.com> <20220722102407.2205-11-peterwu.pub@gmail.com> In-Reply-To: <20220722102407.2205-11-peterwu.pub@gmail.com> From: Andy Shevchenko Date: Mon, 25 Jul 2022 10:25:06 +0200 Message-ID: Subject: Re: [PATCH v6 10/13] power: supply: mt6370: Add MediaTek MT6370 charger driver To: ChiaEn Wu Cc: Lee Jones , Daniel Thompson , Jingoo Han , Pavel Machek , Rob Herring , Krzysztof Kozlowski , Matthias Brugger , Sebastian Reichel , Chunfeng Yun , Greg Kroah-Hartman , Jonathan Cameron , Lars-Peter Clausen , Liam Girdwood , Mark Brown , Guenter Roeck , "Krogerus, Heikki" , Helge Deller , ChiaEn Wu , Alice Chen , cy_huang , dri-devel , Linux LED Subsystem , devicetree , linux-arm Mailing List , "moderated list:ARM/Mediatek SoC support" , Linux Kernel Mailing List , Linux PM , USB , linux-iio , "open list:FRAMEBUFFER LAYER" , szuni chen Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-leds@vger.kernel.org On Fri, Jul 22, 2022 at 12:25 PM ChiaEn Wu wrote: > > From: ChiaEn Wu > > MediaTek MT6370 is a SubPMIC consisting of a single cell battery charger > with ADC monitoring, RGB LEDs, dual channel flashlight, WLED backlight > driver, display bias voltage supply, one general purpose LDO, and the > USB Type-C & PD controller complies with the latest USB Type-C and PD > standards. > > This adds MediaTek MT6370 Charger driver support. The charger module > of MT6370 supports High-Accuracy Voltage/Current Regulation, > Average Input Current Regulation, Battery Temperature Sensing, > Over-Temperature Protection, DPDM Detection for BC1.2. ... > +static inline void mt6370_chg_enable_irq(struct mt6370_priv *priv, > + const char *irq_name, bool en) > +{ > + int irq_num; > + struct platform_device *pdev = to_platform_device(priv->dev); > + > + irq_num = platform_get_irq_byname(pdev, irq_name); Every time the IRQ is not found you will get an error message printed here. 1) Is IRQ optional? 2) If not, can't you do validation only once? > + if (irq_num < 0) > + return; > + > + if (en) > + enable_irq(irq_num); > + else > + disable_irq_nosync(irq_num); > +} ... > + ret = mt6370_chg_field_set(priv, F_USBCHGEN, 0); > + if (ret < 0) { > + ret = mt6370_chg_field_set(priv, F_ICHG, 900000); > + if (ret < 0) { > + ret = mt6370_chg_field_set(priv, F_IINLMTSEL, 3); > + if (ret < 0) { Do all these ' < 0' parts make sense? (Not only these cases, but in many in the entire driver) ... > + /* Check in otg mode or not */ OTG ... > + ret = devm_request_threaded_irq(priv->dev, ret, NULL, > + mt6370_chg_irqs[i].handler, > + IRQF_TRIGGER_FALLING, > + dev_name(priv->dev), priv); > + Redundant blank line. > + if (ret < 0) > + return dev_err_probe(priv->dev, ret, > + "Failed to request irq %s\n", > + mt6370_chg_irqs[i].name); > + } -- With Best Regards, Andy Shevchenko From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id B02CECCA490 for ; Mon, 25 Jul 2022 08:25:49 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 470AB10F364; Mon, 25 Jul 2022 08:25:47 +0000 (UTC) Received: from mail-ej1-x634.google.com (mail-ej1-x634.google.com [IPv6:2a00:1450:4864:20::634]) by gabe.freedesktop.org (Postfix) with ESMTPS id 437FD113ADA for ; Mon, 25 Jul 2022 08:25:45 +0000 (UTC) Received: by mail-ej1-x634.google.com with SMTP id mf4so19245533ejc.3 for ; Mon, 25 Jul 2022 01:25:45 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=J5rSRKJzZCEe75lE89H4BacTqhlHPMQzJe7RV2ORfWI=; b=BNlVjsxRro5TG97838xZbVcQ/pG/LD+g/7G/AjwrIrlPvPS37j9HRk59ZPvQZFMbo9 MnOMniee2k168J7vlVevltwedsYw1fwJcNYMweUNuLPFL7JEp9m9CEssAgQLNBEXPpLX 65np3ghAZ/JI0ou7IY+VAdXdeEM9Dx5l6K3VMtdxVw5MaZ+JcN9Mz6qTKX+a72GlbThf YgqMy4pPKGjxlN3v8ojq6p7cX1h0ysW9lnKZ5pLCEPb56UCWlozkB+OoACaoaIIUBRbZ /V/wW4p+YYsXXLnpTvXofuXoBPwxmOEVHWVRTZH6OK6PGjSYJaBn82vKtB7a1B3eaVvy gAUg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=J5rSRKJzZCEe75lE89H4BacTqhlHPMQzJe7RV2ORfWI=; b=C2JX2wYU4lupm9Z56X1hDrEQjmIQoEG0lkBcJiPoe/VU+WYXBb58miPvgOSg+Aq10Q ZPUC4NWaQc/n6tjnHHeGQirmu+28vWwC/9djyLf+6TxASSUzL+OoTO8bBOXext8gG6/U 7I4hUhHFD/jGSYaSDgzr83lPYeeyzK7bdCr81+bfyiM8WGFN8x+ZpAGIC+7PfUEQSzaX zBkHncp4p8VHQlW2Zi/BaVymSZr0xuzHwMLed/clhu5I+r9wT0jT5pVUuBwCfKfxE4FY /KSG7Qp9Nmq248D51458CQJlEfe8LT7Gx4U/KTVnbs2EvlaQRj52IWOou7S57mW/HZjI FFaA== X-Gm-Message-State: AJIora8+wx7ZVJ1xn5Gs/dv3KhMSxKzKmWTM9Ji7iNvueAKUYfYHJpyO mzvuiBpUOGreH6DwS4wZNSvFuXenLbnZf2YPIHA= X-Google-Smtp-Source: AGRyM1tb8lf0258KwCgCSc1j2TNtucrsLChWD53/F5ZAYHmenBBMp0FJqJ/Hs5trX2iqStdOTyF6IVkbw5ytFnaOucM= X-Received: by 2002:a17:906:8a4a:b0:72b:5b23:3065 with SMTP id gx10-20020a1709068a4a00b0072b5b233065mr9396194ejc.557.1658737543426; Mon, 25 Jul 2022 01:25:43 -0700 (PDT) MIME-Version: 1.0 References: <20220722102407.2205-1-peterwu.pub@gmail.com> <20220722102407.2205-11-peterwu.pub@gmail.com> In-Reply-To: <20220722102407.2205-11-peterwu.pub@gmail.com> From: Andy Shevchenko Date: Mon, 25 Jul 2022 10:25:06 +0200 Message-ID: Subject: Re: [PATCH v6 10/13] power: supply: mt6370: Add MediaTek MT6370 charger driver To: ChiaEn Wu Content-Type: text/plain; charset="UTF-8" X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: "open list:FRAMEBUFFER LAYER" , "Krogerus, Heikki" , Krzysztof Kozlowski , Alice Chen , linux-iio , dri-devel , Liam Girdwood , cy_huang , Pavel Machek , Lee Jones , Linux LED Subsystem , Daniel Thompson , Helge Deller , Rob Herring , Chunfeng Yun , Guenter Roeck , devicetree , Linux PM , szuni chen , Mark Brown , "moderated list:ARM/Mediatek SoC support" , Matthias Brugger , linux-arm Mailing List , Jingoo Han , USB , Sebastian Reichel , Linux Kernel Mailing List , ChiaEn Wu , Greg Kroah-Hartman , Jonathan Cameron Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" On Fri, Jul 22, 2022 at 12:25 PM ChiaEn Wu wrote: > > From: ChiaEn Wu > > MediaTek MT6370 is a SubPMIC consisting of a single cell battery charger > with ADC monitoring, RGB LEDs, dual channel flashlight, WLED backlight > driver, display bias voltage supply, one general purpose LDO, and the > USB Type-C & PD controller complies with the latest USB Type-C and PD > standards. > > This adds MediaTek MT6370 Charger driver support. The charger module > of MT6370 supports High-Accuracy Voltage/Current Regulation, > Average Input Current Regulation, Battery Temperature Sensing, > Over-Temperature Protection, DPDM Detection for BC1.2. ... > +static inline void mt6370_chg_enable_irq(struct mt6370_priv *priv, > + const char *irq_name, bool en) > +{ > + int irq_num; > + struct platform_device *pdev = to_platform_device(priv->dev); > + > + irq_num = platform_get_irq_byname(pdev, irq_name); Every time the IRQ is not found you will get an error message printed here. 1) Is IRQ optional? 2) If not, can't you do validation only once? > + if (irq_num < 0) > + return; > + > + if (en) > + enable_irq(irq_num); > + else > + disable_irq_nosync(irq_num); > +} ... > + ret = mt6370_chg_field_set(priv, F_USBCHGEN, 0); > + if (ret < 0) { > + ret = mt6370_chg_field_set(priv, F_ICHG, 900000); > + if (ret < 0) { > + ret = mt6370_chg_field_set(priv, F_IINLMTSEL, 3); > + if (ret < 0) { Do all these ' < 0' parts make sense? (Not only these cases, but in many in the entire driver) ... > + /* Check in otg mode or not */ OTG ... > + ret = devm_request_threaded_irq(priv->dev, ret, NULL, > + mt6370_chg_irqs[i].handler, > + IRQF_TRIGGER_FALLING, > + dev_name(priv->dev), priv); > + Redundant blank line. > + if (ret < 0) > + return dev_err_probe(priv->dev, ret, > + "Failed to request irq %s\n", > + mt6370_chg_irqs[i].name); > + } -- With Best Regards, Andy Shevchenko From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id A4B09C433EF for ; Mon, 25 Jul 2022 08:27:23 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:Cc:To:Subject:Message-ID:Date:From: In-Reply-To:References:MIME-Version:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=+1n84kCy5vbE/pN8SEabtMtUxBobfyHzTLOl9zqESD8=; b=qJml0vLPbpcPkX +qQMcs41nVsfjVOerJ+IUQecyiV/Xa16ahJ0vkid3pb+gRstc6gf93bKhOj00pmH0VBGxSPyRdp+4 lsMoY9fpnCXz6qY+oepPKv8kctVglk69MKtzNw2GY41qKNxY7wlQdI+8L9SzeUexMnhvWuSX+gCs4 1E5zqcZMt32W7Ptm+JN9rxGWA1fwbP1NIakQMRx3NsHKLJX8c6DWWAPVn3T59/B2YwaITYXaFE+xI VJ4gWoVpeNDFHhhT3p1mlZN2Xmxi79rLJ1HWNSfTwQvunNrX1fY9wL8f/T+LCeFjvNOMJzQfIwylr Vs9CKkFbA7LngG7zO91Q==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1oFtPr-006pG2-VR; Mon, 25 Jul 2022 08:26:16 +0000 Received: from mail-ej1-x636.google.com ([2a00:1450:4864:20::636]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1oFtPO-006ono-Es; Mon, 25 Jul 2022 08:25:47 +0000 Received: by mail-ej1-x636.google.com with SMTP id ss3so19104795ejc.11; Mon, 25 Jul 2022 01:25:44 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=J5rSRKJzZCEe75lE89H4BacTqhlHPMQzJe7RV2ORfWI=; b=BNlVjsxRro5TG97838xZbVcQ/pG/LD+g/7G/AjwrIrlPvPS37j9HRk59ZPvQZFMbo9 MnOMniee2k168J7vlVevltwedsYw1fwJcNYMweUNuLPFL7JEp9m9CEssAgQLNBEXPpLX 65np3ghAZ/JI0ou7IY+VAdXdeEM9Dx5l6K3VMtdxVw5MaZ+JcN9Mz6qTKX+a72GlbThf YgqMy4pPKGjxlN3v8ojq6p7cX1h0ysW9lnKZ5pLCEPb56UCWlozkB+OoACaoaIIUBRbZ /V/wW4p+YYsXXLnpTvXofuXoBPwxmOEVHWVRTZH6OK6PGjSYJaBn82vKtB7a1B3eaVvy gAUg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=J5rSRKJzZCEe75lE89H4BacTqhlHPMQzJe7RV2ORfWI=; b=q1M6hxfrhEBlbk5YSKXiv5QlMj1izcYvRD5eBSCYqRZgD7DsYGafjBVVrikdc+Tdwk rTjEi1yNTE6UwdPevO5hbXaN8QH8MJlhrBB7FD02M+Xr4DzLlM+VHMCLd6hTHSnaALGQ 6So6yd3TTWxvI6MuPPnE7QhmrfEJ8Y+miwRsLbUEJZRt5yPF/FMgARKWGtZ4qRpgza/j KwfqVlwdAD73YHSCPxiD3Dhhb5v5IhbrmDuDgVSv9Zk0XUs7z0Do6uhQKmNgx8KrkICI nooZvDgjuBBttCRzn9SHvc/J9c0HjyfSFpm/BqmQaZ11N17MswWU237PExyarZ+Znv0U 4SyQ== X-Gm-Message-State: AJIora+SfjA8o/+XOG/cwO2rvmPJkKICTVdT1bOi4+THnRStl7TmrpZx OxF+zV5+pa8mob7Fh0Z0m0vK8eUJXezxsoINcF8= X-Google-Smtp-Source: AGRyM1tb8lf0258KwCgCSc1j2TNtucrsLChWD53/F5ZAYHmenBBMp0FJqJ/Hs5trX2iqStdOTyF6IVkbw5ytFnaOucM= X-Received: by 2002:a17:906:8a4a:b0:72b:5b23:3065 with SMTP id gx10-20020a1709068a4a00b0072b5b233065mr9396194ejc.557.1658737543426; Mon, 25 Jul 2022 01:25:43 -0700 (PDT) MIME-Version: 1.0 References: <20220722102407.2205-1-peterwu.pub@gmail.com> <20220722102407.2205-11-peterwu.pub@gmail.com> In-Reply-To: <20220722102407.2205-11-peterwu.pub@gmail.com> From: Andy Shevchenko Date: Mon, 25 Jul 2022 10:25:06 +0200 Message-ID: Subject: Re: [PATCH v6 10/13] power: supply: mt6370: Add MediaTek MT6370 charger driver To: ChiaEn Wu Cc: Lee Jones , Daniel Thompson , Jingoo Han , Pavel Machek , Rob Herring , Krzysztof Kozlowski , Matthias Brugger , Sebastian Reichel , Chunfeng Yun , Greg Kroah-Hartman , Jonathan Cameron , Lars-Peter Clausen , Liam Girdwood , Mark Brown , Guenter Roeck , "Krogerus, Heikki" , Helge Deller , ChiaEn Wu , Alice Chen , cy_huang , dri-devel , Linux LED Subsystem , devicetree , linux-arm Mailing List , "moderated list:ARM/Mediatek SoC support" , Linux Kernel Mailing List , Linux PM , USB , linux-iio , "open list:FRAMEBUFFER LAYER" , szuni chen X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220725_012546_548629_96710DAF X-CRM114-Status: GOOD ( 18.34 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Fri, Jul 22, 2022 at 12:25 PM ChiaEn Wu wrote: > > From: ChiaEn Wu > > MediaTek MT6370 is a SubPMIC consisting of a single cell battery charger > with ADC monitoring, RGB LEDs, dual channel flashlight, WLED backlight > driver, display bias voltage supply, one general purpose LDO, and the > USB Type-C & PD controller complies with the latest USB Type-C and PD > standards. > > This adds MediaTek MT6370 Charger driver support. The charger module > of MT6370 supports High-Accuracy Voltage/Current Regulation, > Average Input Current Regulation, Battery Temperature Sensing, > Over-Temperature Protection, DPDM Detection for BC1.2. ... > +static inline void mt6370_chg_enable_irq(struct mt6370_priv *priv, > + const char *irq_name, bool en) > +{ > + int irq_num; > + struct platform_device *pdev = to_platform_device(priv->dev); > + > + irq_num = platform_get_irq_byname(pdev, irq_name); Every time the IRQ is not found you will get an error message printed here. 1) Is IRQ optional? 2) If not, can't you do validation only once? > + if (irq_num < 0) > + return; > + > + if (en) > + enable_irq(irq_num); > + else > + disable_irq_nosync(irq_num); > +} ... > + ret = mt6370_chg_field_set(priv, F_USBCHGEN, 0); > + if (ret < 0) { > + ret = mt6370_chg_field_set(priv, F_ICHG, 900000); > + if (ret < 0) { > + ret = mt6370_chg_field_set(priv, F_IINLMTSEL, 3); > + if (ret < 0) { Do all these ' < 0' parts make sense? (Not only these cases, but in many in the entire driver) ... > + /* Check in otg mode or not */ OTG ... > + ret = devm_request_threaded_irq(priv->dev, ret, NULL, > + mt6370_chg_irqs[i].handler, > + IRQF_TRIGGER_FALLING, > + dev_name(priv->dev), priv); > + Redundant blank line. > + if (ret < 0) > + return dev_err_probe(priv->dev, ret, > + "Failed to request irq %s\n", > + mt6370_chg_irqs[i].name); > + } -- With Best Regards, Andy Shevchenko _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel