All of lore.kernel.org
 help / color / mirror / Atom feed
From: Andy Shevchenko <andy.shevchenko@gmail.com>
To: Jonathan Cameron <jic23@kernel.org>
Cc: Liam Beguin <liambeguin@gmail.com>, Peter Rosin <peda@axentia.se>,
	Lars-Peter Clausen <lars@metafoo.de>,
	Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
	linux-iio <linux-iio@vger.kernel.org>,
	devicetree <devicetree@vger.kernel.org>,
	Rob Herring <robh+dt@kernel.org>
Subject: Re: [PATCH v13 06/11] iio: afe: rescale: make use of units.h
Date: Sat, 5 Feb 2022 20:23:18 +0200	[thread overview]
Message-ID: <CAHp75Vef4kYqQsd+4A=MQANhEQwvO7N53aB0ypPO-QwDuUZJ8w@mail.gmail.com> (raw)
In-Reply-To: <20220205175404.451c5c56@jic23-huawei>

On Sat, Feb 5, 2022 at 7:47 PM Jonathan Cameron <jic23@kernel.org> wrote:
> On Tue, 1 Feb 2022 14:28:28 -0500
> Liam Beguin <liambeguin@gmail.com> wrote:

...

> Not sure if it would help but maybe it's worth a local define
> of something like
>
> #define MULT9 1000000000LL
> to loose the association with any particular SI basis and
> just indicate it's a bit number being used to retain precision
> in some maths?  Would need a comment to stop people sending
> patches to replace it with GIGA though ;)
>
> My ultimate preference here is for whatever works for Peter and
> Liam as the people who are mostly likely to have to deal
> with any changes to this driver in the future.

SI multipliers are for values with the physical meaning. While Peter
found them confusing, it's a pretty much win in my opinion when we
talk about data from nature. For the pure mathematical scale it may be
confusing.

-- 
With Best Regards,
Andy Shevchenko

  reply	other threads:[~2022-02-05 18:24 UTC|newest]

Thread overview: 26+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-01-30 16:10 [PATCH v13 00/11] iio: afe: add temperature rescaling support Liam Beguin
2022-01-30 16:10 ` [PATCH v13 01/11] iio: afe: rescale: expose scale processing function Liam Beguin
2022-01-30 16:10 ` [PATCH v13 02/11] iio: afe: rescale: add INT_PLUS_{MICRO,NANO} support Liam Beguin
2022-02-02 17:04   ` Peter Rosin
2022-02-02 21:13     ` Liam Beguin
2022-01-30 16:10 ` [PATCH v13 03/11] iio: afe: rescale: add offset support Liam Beguin
2022-01-30 16:10 ` [PATCH v13 04/11] iio: afe: rescale: fix accuracy for small fractional scales Liam Beguin
2022-01-30 16:10 ` [PATCH v13 05/11] iio: afe: rescale: reduce risk of integer overflow Liam Beguin
2022-01-30 16:10 ` [PATCH v13 06/11] iio: afe: rescale: make use of units.h Liam Beguin
2022-01-31 14:50   ` Peter Rosin
2022-01-31 15:23     ` Andy Shevchenko
2022-02-01  1:59       ` Peter Rosin
2022-02-01  9:20         ` Andy Shevchenko
2022-02-01 19:28     ` Liam Beguin
2022-02-05 17:54       ` Jonathan Cameron
2022-02-05 18:23         ` Andy Shevchenko [this message]
2022-02-07 14:05         ` Liam Beguin
2022-02-07 20:22           ` Jonathan Cameron
2022-01-30 16:10 ` [PATCH v13 07/11] iio: test: add basic tests for the iio-rescale driver Liam Beguin
2022-01-30 16:10 ` [PATCH v13 08/11] iio: afe: rescale: add RTD temperature sensor support Liam Beguin
2022-02-02 16:58   ` Peter Rosin
2022-02-02 20:56     ` Liam Beguin
2022-01-30 16:10 ` [PATCH v13 09/11] iio: afe: rescale: add temperature transducers Liam Beguin
2022-01-30 16:11 ` [PATCH v13 10/11] dt-bindings: iio: afe: add bindings for temperature-sense-rtd Liam Beguin
2022-01-30 16:11 ` [PATCH v13 11/11] dt-bindings: iio: afe: add bindings for temperature transducers Liam Beguin
2022-01-31 11:06 ` [PATCH v13 00/11] iio: afe: add temperature rescaling support Andy Shevchenko

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAHp75Vef4kYqQsd+4A=MQANhEQwvO7N53aB0ypPO-QwDuUZJ8w@mail.gmail.com' \
    --to=andy.shevchenko@gmail.com \
    --cc=devicetree@vger.kernel.org \
    --cc=jic23@kernel.org \
    --cc=lars@metafoo.de \
    --cc=liambeguin@gmail.com \
    --cc=linux-iio@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=peda@axentia.se \
    --cc=robh+dt@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.