From mboxrd@z Thu Jan  1 00:00:00 1970
From: Andy Shevchenko <andy.shevchenko@gmail.com>
Date: Mon, 9 Mar 2020 09:41:38 +0200
Subject: [PATCH v2 02/39] spi: Add SPI mode enums
In-Reply-To: <20200308214442.v2.2.I83a459a3914c56ca81dcdfa7e01d83c54f7ab914@changeid>
References: <20200309034504.149659-1-sjg@chromium.org>
 <20200308214442.v2.2.I83a459a3914c56ca81dcdfa7e01d83c54f7ab914@changeid>
Message-ID: <CAHp75VefnUpwRJ4s66Y=oB3JTnaRFGirdPMAMvjqjW=b+ejYfA@mail.gmail.com>
List-Id: <u-boot.lists.denx.de>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
To: u-boot@lists.denx.de

On Mon, Mar 9, 2020 at 5:45 AM Simon Glass <sjg@chromium.org> wrote:
>
> With ACPI we need to describe the settings of the SPI bus. Add enums to
> handle this.
>
> Signed-off-by: Simon Glass <sjg@chromium.org>
> Reviewed-by: Bin Meng <bmeng.cn@gmail.com>
> ---
>
> Changes in v2:
> - Don't bracket the definitions with DM_SPI
>
>  include/spi.h | 33 +++++++++++++++++++++++++++++++++
>  1 file changed, 33 insertions(+)
>
> diff --git a/include/spi.h b/include/spi.h
> index 852f570eaa..2092940f4c 100644
> --- a/include/spi.h
> +++ b/include/spi.h
> @@ -66,6 +66,39 @@ struct dm_spi_slave_platdata {
>
>  #endif /* CONFIG_DM_SPI */
>
> +/**
> + * enum spi_clock_phase - indicates  the clock phase to use for SPI (CPHA)
> + *
> + * @SPI_CLOCK_PHASE_FIRST: Data sampled on the first phase
> + * @SPI_CLOCK_PHASE_SECOND: Data sampled on the second phase
> + */
> +enum spi_clock_phase {
> +       SPI_CLOCK_PHASE_FIRST,
> +       SPI_CLOCK_PHASE_SECOND

I always forget if absence of comma in such cases (where it's not
obvious that the last item in the enum, struct or array is a
terminator line) is U-Boot style, but I this the rule of thumb is to
have comma at the end to simplify extension or adjustment  in the
future.

> +};
> +
> +/**
> + * enum spi_wire_mode - indicates the number of wires used for SPI
> + *
> + * @SPI_4_WIRE_MODE: Normal bidirectional mode with MOSI and MISO
> + * @SPI_3_WIRE_MODE: Unidirectional version with a single data line SISO
> + */
> +enum spi_wire_mode {
> +       SPI_4_WIRE_MODE,
> +       SPI_3_WIRE_MODE
> +};
> +
> +/**
> + * enum spi_polarity - indicates the polarity of the SPI bus (CPOL)
> + *
> + * @SPI_POLARITY_LOW: Clock is low in idle state
> + * @SPI_POLARITY_HIGH: Clock is high in idle state
> + */
> +enum spi_polarity {
> +       SPI_POLARITY_LOW,
> +       SPI_POLARITY_HIGH
> +};
> +
>  /**
>   * struct spi_slave - Representation of a SPI slave
>   *
> --
> 2.25.1.481.gfbce0eb801-goog
>


-- 
With Best Regards,
Andy Shevchenko