From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752392AbdJ0PVL (ORCPT ); Fri, 27 Oct 2017 11:21:11 -0400 Received: from mail-qk0-f196.google.com ([209.85.220.196]:56369 "EHLO mail-qk0-f196.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751025AbdJ0PVI (ORCPT ); Fri, 27 Oct 2017 11:21:08 -0400 X-Google-Smtp-Source: ABhQp+QplROP0Qn4ELOIrKauKXOYJaKuwgBPavbxHJI/jY+RXzOh1bGKnlUbebPm+xp/y3jtqjsW0W2W9oD2aNN13po= MIME-Version: 1.0 In-Reply-To: References: From: Andy Shevchenko Date: Fri, 27 Oct 2017 18:21:06 +0300 Message-ID: Subject: Re: [PATCH 0/4] Topstar ACPI LED Workaround To: =?UTF-8?Q?Guillaume_Dou=C3=A9zan=2DGrard?= Cc: Darren Hart , Andy Shevchenko , Platform Driver , "linux-kernel@vger.kernel.org" Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Transfer-Encoding: 8bit X-MIME-Autoconverted: from quoted-printable to 8bit by nfs id v9RFLGxp009031 On Tue, Oct 17, 2017 at 7:17 PM, Guillaume Douézan-Grard wrote: > Hi Darren, > > On Topstar U931 Notebooks, an issue prevents the WLAN toggle key from > being properly managed by the Embedded Controller and successfully > disconnect the adapter. A specific ACPI method allows to toggle the WLAN > LED state regardless. > > These are barebone laptops, sold under quite a lot of brands and > configurations, with different firmwares and so on. I can only say for sure > that this issue is present for all the models sold under a specific brand, > that's why I'm reluctant to enable this by default with a DMI check. > > Thus, the new `led_workaround` option registers this LED with the > corresponding subsystem, making possible to use a software-based trigger > (rfkill for instance to synchronize the LED with the softkill state). > > Thank you for your time, I have applied to my review and testing queue with some changes: - device names are left unchanged (it's ABI, we can't just change device name to whatever we want if we can't guarantee that doesn't break anything, at least I can't) - labels should mark what is expected to be executed when code chooses that path - I split module authors to two macro calls (this makes slightly better readability in the sources and when one calls modinfo) Can you check if it's okay with your devices and works as expected? If everything okay, take my them from review-andy branch, add commit message to where it's missed and send a new version. Thanks. > > -- > Guillaume Douézan-Grard > > Guillaume Douézan-Grard (4): > platform/x86: topstar-laptop: non-functional changes > platform/x86: topstar-laptop: change to generic module > platform/x86: topstar-laptop: add platform device > platform/x86: topstar-laptop: add optional WLAN LED workaround > > drivers/platform/x86/Kconfig | 2 + > drivers/platform/x86/topstar-laptop.c | 339 ++++++++++++++++++++++++++-------- > 2 files changed, 267 insertions(+), 74 deletions(-) > > -- > 2.14.1 > -- With Best Regards, Andy Shevchenko