From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id A2D80C433EF for ; Fri, 21 Jan 2022 20:12:23 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231970AbiAUUMX (ORCPT ); Fri, 21 Jan 2022 15:12:23 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:38142 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231717AbiAUUMW (ORCPT ); Fri, 21 Jan 2022 15:12:22 -0500 Received: from mail-ej1-x635.google.com (mail-ej1-x635.google.com [IPv6:2a00:1450:4864:20::635]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id DB374C06173B; Fri, 21 Jan 2022 12:12:21 -0800 (PST) Received: by mail-ej1-x635.google.com with SMTP id s13so3033123ejy.3; Fri, 21 Jan 2022 12:12:21 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=TWFhQ8AyYyJtKJhYHxbzZAy/uyi61n/qj66gr+QR1JU=; b=C8EOiSjCDvxrWY2Ruh48zw6GmmqDRMiC4Xh4oNcfGcsAk4QxT/4WpK9v30k7R8BJTP Ox33CjNanCQL5JyR5uyLDlkgeLcOdifO5g9DsCa0rbRNbnWai+SokHAOH8jjHzhYibLU +zS9PNDuW/W449Hl6zRgYlVFU1GH8q3F2fwCNvg0PKdCaFYlX1Oi9gpQMYDiEgeBBn4E gepuFb5h9afDmvRCUqdyNzK+46+J1POQ0Dw50E6frm5NfGq4duBsbIy48/Su6VdUdePn 8FaHt4DcROcLF95bgfpKvTH6CankmVX8ujX+aQajQ6ivme+VErteaMSP9P5K3Gatceg+ C3/g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=TWFhQ8AyYyJtKJhYHxbzZAy/uyi61n/qj66gr+QR1JU=; b=gWDzKTdcP9JrRU/Q4pUA6Ov+KCNcvk2raJiEhNKJS4ncMXPDZ40zkQhM5h0pxYCQ5y azS8bM1Aq2qRYMkrqf8VqxDgep5vnYMApmPkAvwB1NFAqIL64Lye0w+saeyv2/PbixiC CkSc6kvB7L8MY7O4Ld0i5L853tbQ/GGh8LKHd3AenCM9dsf1cV4DDOA9t/qcWVTxBang i+o1z5HVkQ8X8jAGKwSd9Eke1zOzV0/lUtlC8ZPc4i5rstwWtjB876bo946gPimueacX 8WZFFB4ngj0T1+0dv9wuxQauIcCP/7uASO6c0THpioT9pA5vM8XYaxZtYmtTGep/MF9K 3B0Q== X-Gm-Message-State: AOAM532ZzETPGpZkaYQ6dKHa41rx4ZnupIL9IeKOlXqAodRgd+gdYzq7 uG5hwMos9A0fi+6I1S9E5jxTlU7R0G0VtKduQpkmNTkhLB8= X-Google-Smtp-Source: ABdhPJxiTTwzTmbtx9DNC7Ah5PIXbFyKWQWSb2hxPEtw2WvBrKl7feHCqB0yc+Flx4KZez6dtVy+19KCludTGmAPY9M= X-Received: by 2002:a17:906:3004:: with SMTP id 4mr4419944ejz.579.1642795940215; Fri, 21 Jan 2022 12:12:20 -0800 (PST) MIME-Version: 1.0 References: <20220118145251.1548-1-sbinding@opensource.cirrus.com> <20220118145251.1548-6-sbinding@opensource.cirrus.com> In-Reply-To: From: Andy Shevchenko Date: Fri, 21 Jan 2022 22:11:43 +0200 Message-ID: Subject: Re: [PATCH v3 05/10] platform/x86: i2c-multi-instantiate: Move it to drivers/acpi folder To: "Rafael J. Wysocki" Cc: Lucas tanure , Stefan Binding , Mark Brown , Len Brown , Hans de Goede , Mark Gross , Jaroslav Kysela , Takashi Iwai , "moderated list:SOUND - SOC LAYER / DYNAMIC AUDIO POWER MANAGEM..." , Linux Kernel Mailing List , linux-spi , ACPI Devel Maling List , Platform Driver , patches@opensource.cirrus.com Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-acpi@vger.kernel.org On Fri, Jan 21, 2022 at 9:53 PM Rafael J. Wysocki wrote: > On Wed, Jan 19, 2022 at 6:33 PM Lucas tanure > wrote: > > On 1/19/22 16:53, Rafael J. Wysocki wrote: > > > On Tue, Jan 18, 2022 at 3:53 PM Stefan Binding > > > wrote: ... > > > Why are you moving it away from platform/x86? > > > > > > Adding SPI to the mix doesn't seem to be a sufficient reason. > > > > > > If this were going to be needed on non-x86, that would be a good > > > reason for moving it, but is that actually the case? If so, why isn't > > > that mentioned in the changelog above? > > > > > > > It was a request made by Andy Shevchenko: > > https://lkml.org/lkml/2021/12/3/347 > > But he hasn't given any reasons why that'd be better. My thoughts were that these are related to ACPI handling the serial buses in one place. However, counter arguments might be that the cases of the resources like this are found only on x86 hardware (while ACPI should be agnostic to that) and that the i2c and spi already do ACPI stuff on their own. That said, there are pros and cons and I'm fine with either choice at the end of the day. -- With Best Regards, Andy Shevchenko From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id BC0C4C433F5 for ; Fri, 21 Jan 2022 20:13:26 +0000 (UTC) Received: from alsa1.perex.cz (alsa1.perex.cz [207.180.221.201]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by alsa0.perex.cz (Postfix) with ESMTPS id F2BAA2A0E; Fri, 21 Jan 2022 21:12:33 +0100 (CET) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa0.perex.cz F2BAA2A0E DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=alsa-project.org; s=default; t=1642796004; bh=wQ5G60YTfPNaxMZGgqEvLsKSjCnZki+Da92EOx+AWdk=; h=References:In-Reply-To:From:Date:Subject:To:Cc:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From; b=RWOOIu32BqVG/w1O1BtY6CFfnMNmkTH+vERlYuWKC7qvRgqyqpz3/CI8WxwcL7inp zH9IB2AV8X/tHrA/w4tl3HUS4TeOxn7zlkO7oofCSQztD/uHY7oncl1XY92HtFrN6b 2Bw4x/Ut+j95W9ptE9kIoSRk4Vb9ISjy7SBHCGQ0= Received: from alsa1.perex.cz (localhost.localdomain [127.0.0.1]) by alsa1.perex.cz (Postfix) with ESMTP id 93160F80125; Fri, 21 Jan 2022 21:12:33 +0100 (CET) Received: by alsa1.perex.cz (Postfix, from userid 50401) id CC6E7F8028B; Fri, 21 Jan 2022 21:12:29 +0100 (CET) Received: from mail-ej1-x62e.google.com (mail-ej1-x62e.google.com [IPv6:2a00:1450:4864:20::62e]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by alsa1.perex.cz (Postfix) with ESMTPS id AE038F800F8 for ; Fri, 21 Jan 2022 21:12:21 +0100 (CET) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa1.perex.cz AE038F800F8 Authentication-Results: alsa1.perex.cz; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="C8EOiSjC" Received: by mail-ej1-x62e.google.com with SMTP id k25so3019394ejp.5 for ; Fri, 21 Jan 2022 12:12:21 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=TWFhQ8AyYyJtKJhYHxbzZAy/uyi61n/qj66gr+QR1JU=; b=C8EOiSjCDvxrWY2Ruh48zw6GmmqDRMiC4Xh4oNcfGcsAk4QxT/4WpK9v30k7R8BJTP Ox33CjNanCQL5JyR5uyLDlkgeLcOdifO5g9DsCa0rbRNbnWai+SokHAOH8jjHzhYibLU +zS9PNDuW/W449Hl6zRgYlVFU1GH8q3F2fwCNvg0PKdCaFYlX1Oi9gpQMYDiEgeBBn4E gepuFb5h9afDmvRCUqdyNzK+46+J1POQ0Dw50E6frm5NfGq4duBsbIy48/Su6VdUdePn 8FaHt4DcROcLF95bgfpKvTH6CankmVX8ujX+aQajQ6ivme+VErteaMSP9P5K3Gatceg+ C3/g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=TWFhQ8AyYyJtKJhYHxbzZAy/uyi61n/qj66gr+QR1JU=; b=1lF6cLZ2VtLS/ezxn+mkhKhcy20ONn7AsMzNiREP4ZYfD0/E9Pfqgz9Q3DlcxETbbl MJk4BZeVXleWa/o7XLUIsCDHLJZ7kfGeFjgNUZ7j0I0533xUzglAGTaS21QPsAeTL0VX 1CYF7aJE5b/H037L8yDBDzJa/yHvMMTBD92TZcVl5G5MsLHmbDLTokQ2cKMqE3bXZUyJ bPgnOaEqJZZeClOT/UVoXfn3yoWBdBtSp+YnPRuJxZopIxF1sivk/stg/dnQ4noPf5C2 VhU/cq3hlOxfZ4qrayFa3ruKEwNMqE0NEpGfL5hjifLINxWENULT8Eqs89uRh7sSN2Bb KA1w== X-Gm-Message-State: AOAM532gPZ86rp8BqqJ0PuYnryJZdfM86ld06i8ZGpog/lvLUUH5J7Sv ox45jVkMvoBIRp8Qcl/9wP1/MZi+SS8436kzvDk= X-Google-Smtp-Source: ABdhPJxiTTwzTmbtx9DNC7Ah5PIXbFyKWQWSb2hxPEtw2WvBrKl7feHCqB0yc+Flx4KZez6dtVy+19KCludTGmAPY9M= X-Received: by 2002:a17:906:3004:: with SMTP id 4mr4419944ejz.579.1642795940215; Fri, 21 Jan 2022 12:12:20 -0800 (PST) MIME-Version: 1.0 References: <20220118145251.1548-1-sbinding@opensource.cirrus.com> <20220118145251.1548-6-sbinding@opensource.cirrus.com> In-Reply-To: From: Andy Shevchenko Date: Fri, 21 Jan 2022 22:11:43 +0200 Message-ID: Subject: Re: [PATCH v3 05/10] platform/x86: i2c-multi-instantiate: Move it to drivers/acpi folder To: "Rafael J. Wysocki" Content-Type: text/plain; charset="UTF-8" Cc: Platform Driver , Stefan Binding , Lucas tanure , ACPI Devel Maling List , Linux Kernel Mailing List , linux-spi , Takashi Iwai , Mark Gross , Hans de Goede , Mark Brown , patches@opensource.cirrus.com, "moderated list:SOUND - SOC LAYER / DYNAMIC AUDIO POWER MANAGEM..." , Len Brown X-BeenThere: alsa-devel@alsa-project.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: alsa-devel-bounces@alsa-project.org Sender: "Alsa-devel" On Fri, Jan 21, 2022 at 9:53 PM Rafael J. Wysocki wrote: > On Wed, Jan 19, 2022 at 6:33 PM Lucas tanure > wrote: > > On 1/19/22 16:53, Rafael J. Wysocki wrote: > > > On Tue, Jan 18, 2022 at 3:53 PM Stefan Binding > > > wrote: ... > > > Why are you moving it away from platform/x86? > > > > > > Adding SPI to the mix doesn't seem to be a sufficient reason. > > > > > > If this were going to be needed on non-x86, that would be a good > > > reason for moving it, but is that actually the case? If so, why isn't > > > that mentioned in the changelog above? > > > > > > > It was a request made by Andy Shevchenko: > > https://lkml.org/lkml/2021/12/3/347 > > But he hasn't given any reasons why that'd be better. My thoughts were that these are related to ACPI handling the serial buses in one place. However, counter arguments might be that the cases of the resources like this are found only on x86 hardware (while ACPI should be agnostic to that) and that the i2c and spi already do ACPI stuff on their own. That said, there are pros and cons and I'm fine with either choice at the end of the day. -- With Best Regards, Andy Shevchenko