* [PATCH] platform/x86: ideapad-laptop: Increase timeout to wait for EC answer
@ 2018-02-11 9:18 Aaron Ma
2018-02-14 19:29 ` Andy Shevchenko
0 siblings, 1 reply; 2+ messages in thread
From: Aaron Ma @ 2018-02-11 9:18 UTC (permalink / raw)
To: ike.pan, aaron.ma, platform-driver-x86, linux-kernel
Lenovo E41-20 needs more time than 100ms to read VPC,
the funtion keys always failed responding.
Increase timeout to get the value from VPC, then
the funtion keys like mic mute key work well.
Signed-off-by: Aaron Ma <aaron.ma@canonical.com>
---
drivers/platform/x86/ideapad-laptop.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/platform/x86/ideapad-laptop.c b/drivers/platform/x86/ideapad-laptop.c
index 5b6f18b18801..535199c9e6bc 100644
--- a/drivers/platform/x86/ideapad-laptop.c
+++ b/drivers/platform/x86/ideapad-laptop.c
@@ -113,7 +113,7 @@ MODULE_PARM_DESC(no_bt_rfkill, "No rfkill for bluetooth.");
/*
* ACPI Helpers
*/
-#define IDEAPAD_EC_TIMEOUT (100) /* in ms */
+#define IDEAPAD_EC_TIMEOUT (200) /* in ms */
static int read_method_int(acpi_handle handle, const char *method, int *val)
{
--
2.14.3
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] platform/x86: ideapad-laptop: Increase timeout to wait for EC answer
2018-02-11 9:18 [PATCH] platform/x86: ideapad-laptop: Increase timeout to wait for EC answer Aaron Ma
@ 2018-02-14 19:29 ` Andy Shevchenko
0 siblings, 0 replies; 2+ messages in thread
From: Andy Shevchenko @ 2018-02-14 19:29 UTC (permalink / raw)
To: Aaron Ma; +Cc: Ike Panhc, Platform Driver, Linux Kernel Mailing List
On Sun, Feb 11, 2018 at 11:18 AM, Aaron Ma <aaron.ma@canonical.com> wrote:
> Lenovo E41-20 needs more time than 100ms to read VPC,
> the funtion keys always failed responding.
> Increase timeout to get the value from VPC, then
> the funtion keys like mic mute key work well.
>
Pushed to my review and testing queue, thanks!
> Signed-off-by: Aaron Ma <aaron.ma@canonical.com>
> ---
> drivers/platform/x86/ideapad-laptop.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/platform/x86/ideapad-laptop.c b/drivers/platform/x86/ideapad-laptop.c
> index 5b6f18b18801..535199c9e6bc 100644
> --- a/drivers/platform/x86/ideapad-laptop.c
> +++ b/drivers/platform/x86/ideapad-laptop.c
> @@ -113,7 +113,7 @@ MODULE_PARM_DESC(no_bt_rfkill, "No rfkill for bluetooth.");
> /*
> * ACPI Helpers
> */
> -#define IDEAPAD_EC_TIMEOUT (100) /* in ms */
> +#define IDEAPAD_EC_TIMEOUT (200) /* in ms */
>
> static int read_method_int(acpi_handle handle, const char *method, int *val)
> {
> --
> 2.14.3
>
--
With Best Regards,
Andy Shevchenko
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2018-02-14 19:30 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-02-11 9:18 [PATCH] platform/x86: ideapad-laptop: Increase timeout to wait for EC answer Aaron Ma
2018-02-14 19:29 ` Andy Shevchenko
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.