All of lore.kernel.org
 help / color / mirror / Atom feed
From: Andy Shevchenko <andy.shevchenko@gmail.com>
To: Hans de Goede <hdegoede@redhat.com>
Cc: Henning Schild <henning.schild@siemens.com>,
	Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
	Linux LED Subsystem <linux-leds@vger.kernel.org>,
	Platform Driver <platform-driver-x86@vger.kernel.org>,
	linux-watchdog@vger.kernel.org,
	Srikanth Krishnakar <skrishnakar@gmail.com>,
	Jan Kiszka <jan.kiszka@siemens.com>,
	Gerd Haeussler <gerd.haeussler.ext@siemens.com>,
	Guenter Roeck <linux@roeck-us.net>,
	Wim Van Sebroeck <wim@linux-watchdog.org>,
	Mark Gross <mgross@linux.intel.com>, Pavel Machek <pavel@ucw.cz>
Subject: Re: [PATCH 1/4] platform/x86: simatic-ipc: add main driver for Siemens devices
Date: Fri, 5 Mar 2021 18:47:05 +0200	[thread overview]
Message-ID: <CAHp75Venef8C+njLAOskjhm=XZg=SApQ3SQM398tTVWZDXfkFQ@mail.gmail.com> (raw)
In-Reply-To: <CAHp75VcC5OVDceizzCeZ48FwP=TKccermS6UtV1zd6tSD0OP8Q@mail.gmail.com>

On Fri, Mar 5, 2021 at 6:41 PM Andy Shevchenko
<andy.shevchenko@gmail.com> wrote:
>
> On Fri, Mar 5, 2021 at 6:25 PM Andy Shevchenko
> <andy.shevchenko@gmail.com> wrote:
> > On Fri, Mar 5, 2021 at 6:14 PM Hans de Goede <hdegoede@redhat.com> wrote:
> > > On 3/5/21 4:42 PM, Andy Shevchenko wrote:
>
> ...
>
> > > So I took a quick look at the following 2 commits:
> >
> > (One of the latter commits moves the code to drivers/pci/pci-p2sb.c,
> > do you think it's better like that? The idea is to deduplicate
> > __pci_bus_read_base() call)
> >
> > > "platform/x86: p2sb: New Primary to Sideband bridge support library"
> > > "mfd: lpc_ich: Switch to generic p2sb_bar()"
> > >
> > > And this looks good to me, although compared to the code from this
> > > patch-set you are missing the pci_lock_rescan_remove(); and
> > > pci_unlock_rescan_remove(); calls.
> >
> > Oh, indeed.
>
> Correction here, I'm using pci_bus_sem in the latest version.

Okay, it seems that semaphore is not what I need and PCI rescan lock
is what is mandatory to take here.


-- 
With Best Regards,
Andy Shevchenko

  reply	other threads:[~2021-03-05 16:48 UTC|newest]

Thread overview: 46+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-03-02 16:33 [PATCH 0/4] add device drivers for Siemens Industrial PCs Henning Schild
2021-03-02 16:33 ` [PATCH 1/4] platform/x86: simatic-ipc: add main driver for Siemens devices Henning Schild
2021-03-04 10:11   ` Andy Shevchenko
2021-03-04 13:47     ` Hans de Goede
2021-03-05 15:42       ` Andy Shevchenko
2021-03-05 16:14         ` Hans de Goede
2021-03-05 16:25           ` Andy Shevchenko
2021-03-05 16:36             ` Hans de Goede
2021-03-05 16:41             ` Andy Shevchenko
2021-03-05 16:47               ` Andy Shevchenko [this message]
2021-03-05 16:42         ` Henning Schild
2021-03-05 17:17           ` Andy Shevchenko
2021-03-05 17:44             ` Andy Shevchenko
2021-03-08 12:57               ` Henning Schild
2021-03-08 13:43                 ` Andy Shevchenko
2021-03-04 19:42     ` Henning Schild
2021-03-05 15:46       ` Andy Shevchenko
2021-03-05 16:31         ` Henning Schild
2021-03-04 14:03   ` Hans de Goede
2021-03-02 16:33 ` [PATCH 2/4] leds: simatic-ipc-leds: add new driver for Siemens Industial PCs Henning Schild
2021-03-02 20:54   ` Pavel Machek
2021-03-03 13:11     ` Henning Schild
2021-03-03 19:31       ` Pavel Machek
2021-03-03 20:48         ` Henning Schild
2021-03-03 20:56           ` Henning Schild
2021-03-05 18:25             ` Henning Schild
2021-03-06 12:54               ` Henning Schild
2021-03-06 13:06                 ` Henning Schild
2021-03-15 11:49                   ` Pavel Machek
2021-03-15 11:41               ` Pavel Machek
2021-03-03 17:37     ` Henning Schild
2021-03-03 17:40       ` Pavel Machek
2021-03-03 18:49         ` Henning Schild
2021-03-03 19:27           ` Pavel Machek
2021-03-02 16:33 ` [PATCH 3/4] watchdog: simatic-ipc-wdt: add new driver for Siemens Industrial PCs Henning Schild
2021-03-02 18:38   ` Guenter Roeck
2021-03-03 14:21     ` Henning Schild
2021-03-03 14:49       ` Jan Kiszka
2021-03-08 15:20       ` Henning Schild
     [not found]   ` <CAHp75VdUXWDg-2o8fmeo7EoMtRLfCnFOw5ptwjXTv9fKMmHv2A@mail.gmail.com>
2021-03-04  9:00     ` Henning Schild
2021-03-02 16:33 ` [PATCH 4/4] platform/x86: pmc_atom: improve critclk_systems matching for Siemens PCs Henning Schild
2021-03-04  9:50   ` Andy Shevchenko
2021-03-04 10:19 ` [PATCH 0/4] add device drivers for Siemens Industrial PCs Andy Shevchenko
2021-03-04 10:20   ` Andy Shevchenko
2021-03-04 19:26     ` Henning Schild
2021-03-04 19:14   ` Henning Schild

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAHp75Venef8C+njLAOskjhm=XZg=SApQ3SQM398tTVWZDXfkFQ@mail.gmail.com' \
    --to=andy.shevchenko@gmail.com \
    --cc=gerd.haeussler.ext@siemens.com \
    --cc=hdegoede@redhat.com \
    --cc=henning.schild@siemens.com \
    --cc=jan.kiszka@siemens.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-leds@vger.kernel.org \
    --cc=linux-watchdog@vger.kernel.org \
    --cc=linux@roeck-us.net \
    --cc=mgross@linux.intel.com \
    --cc=pavel@ucw.cz \
    --cc=platform-driver-x86@vger.kernel.org \
    --cc=skrishnakar@gmail.com \
    --cc=wim@linux-watchdog.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.