From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2514BC43334 for ; Tue, 28 Jun 2022 19:09:56 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234936AbiF1TJy (ORCPT ); Tue, 28 Jun 2022 15:09:54 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:42464 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S236068AbiF1TJu (ORCPT ); Tue, 28 Jun 2022 15:09:50 -0400 Received: from mail-yw1-x112b.google.com (mail-yw1-x112b.google.com [IPv6:2607:f8b0:4864:20::112b]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id AACCC192B2; Tue, 28 Jun 2022 12:09:49 -0700 (PDT) Received: by mail-yw1-x112b.google.com with SMTP id 00721157ae682-3176b6ed923so126830847b3.11; Tue, 28 Jun 2022 12:09:49 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc:content-transfer-encoding; bh=Df+MKXJfNDPG+S9kvWPeYAx6XZpxE7WPz2ahAfIBELQ=; b=pm/CU9ccX46GwxUJNxGvRTMDaiONUskg50NFy9k6irBkgRKofkyc6ddePCEDw3hp/D YUNclZZG1b0PGUW5ktGHPaluX0gZX3ouDXNnNk17kL7G9DAJaSoKAE/u5aieZ99bpoat o9MZCnagpwdR6CJEt+GXTI0/iMSRU7hTqCYCVv0yIB2PkugqcBkmMzdxudzbuXuleZN6 zyrL31ToCzBXN99LUZqT79PzJOD0+mmhhryKp75gePf38PodiDcoDenGzGyEHCes/zRE unNmXiH32sp9QN/g8JaseaG9ef4D+J5vrxXfUthTp7fX8PJw7NwQKNJHjCe9sARr5gg5 tZWQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=Df+MKXJfNDPG+S9kvWPeYAx6XZpxE7WPz2ahAfIBELQ=; b=dEv6zL8U8soL0h0frb3laR38/AMwYPwmJs/jY9A6DRYtIL9zsPxYa2Pml2bghueYCD zJ6bCyVdHiynHbwNAFKn+D3K6kHiJlvRVKyaJ+lYsFwgWqk1eQ/ffTWwhyxvLPMCnS31 DXfvTkxvs5QFdbySms6o68Dw1eqo+kHhgi2vFg0L55lBaKg+/lPX04/hKYqN9oWsKnFD MExcjY3w/rjE9/j/WQCTw7B5dhsLNE6hqC+OmvU0qKVs/UdxLg44jx59yxCmC6PuX7GV rQ5yHJBOXnW91xtgDvybBpqWh+nmrHvV4LPbQwsYrnYBIbjkg9bPTOO5aC92tR5bP5Xi NleQ== X-Gm-Message-State: AJIora+yT87CmGKj4Xsd1aa8PzYIqvP6RPqyouQtYbMNPejavcoaazFd Dha1ZHKN4ViJXNwnqRzWy6tIiZBhmrxUPdoFepo= X-Google-Smtp-Source: AGRyM1vUp1dBPu4iDpJJOmQhrlwsWm72LE+ItI0NXjClMBY6C43R8UMBqnE261JrKVtOs4rDzv0NkQvPJIUx7WwNpR8= X-Received: by 2002:a81:5d88:0:b0:318:31c1:56f3 with SMTP id r130-20020a815d88000000b0031831c156f3mr23363889ywb.18.1656443388713; Tue, 28 Jun 2022 12:09:48 -0700 (PDT) MIME-Version: 1.0 References: <20220628140313.74984-1-u.kleine-koenig@pengutronix.de> <20220628140313.74984-6-u.kleine-koenig@pengutronix.de> In-Reply-To: <20220628140313.74984-6-u.kleine-koenig@pengutronix.de> From: Andy Shevchenko Date: Tue, 28 Jun 2022 21:09:09 +0200 Message-ID: Subject: Re: [PATCH 5/6] gpio: pca953x: Make platform teardown callback return void To: =?UTF-8?Q?Uwe_Kleine=2DK=C3=B6nig?= Cc: Sekhar Nori , Bartosz Golaszewski , Russell King , Linus Walleij , linux-arm Mailing List , "open list:GPIO SUBSYSTEM" , Sascha Hauer , linux-i2c Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-gpio@vger.kernel.org On Tue, Jun 28, 2022 at 4:04 PM Uwe Kleine-K=C3=B6nig wrote: > > All platforms that provide a teardown callback return 0. New users are > supposed to not make use of platform support, so there is no > functionality lost. > > This patch is a preparation for making i2c remove callbacks return void. > > Signed-off-by: Uwe Kleine-K=C3=B6nig > Forwarded: id:20220502170555.51183-1-u.kleine-koenig@pengutronix.de What is this tag for? Has it been documented? (Linus recently was ranting against homegrown custom (read: non-documented) tags) For now the code looks good, Reviewed-by: Andy Shevchenko However, I prefer to see dropping those callbacks altogether (find the way how to use GPIO descriptors / GPIO table / etc instead of ugly custom callbacks). > --- > arch/arm/mach-davinci/board-da850-evm.c | 12 ++++-------- > drivers/gpio/gpio-pca953x.c | 11 +++-------- > include/linux/platform_data/pca953x.h | 2 +- > 3 files changed, 8 insertions(+), 17 deletions(-) > > diff --git a/arch/arm/mach-davinci/board-da850-evm.c b/arch/arm/mach-davi= nci/board-da850-evm.c > index efc26b472ef8..09253e70d0dc 100644 > --- a/arch/arm/mach-davinci/board-da850-evm.c > +++ b/arch/arm/mach-davinci/board-da850-evm.c > @@ -518,8 +518,8 @@ static int da850_evm_ui_expander_setup(struct i2c_cli= ent *client, unsigned gpio, > return ret; > } > > -static int da850_evm_ui_expander_teardown(struct i2c_client *client, > - unsigned gpio, unsigned ngpio, vo= id *c) > +static void da850_evm_ui_expander_teardown(struct i2c_client *client, > + unsigned gpio, unsigned ngpio,= void *c) > { > platform_device_unregister(&da850_evm_ui_keys_device); > > @@ -531,8 +531,6 @@ static int da850_evm_ui_expander_teardown(struct i2c_= client *client, > gpio_free(gpio + DA850_EVM_UI_EXP_SEL_C); > gpio_free(gpio + DA850_EVM_UI_EXP_SEL_B); > gpio_free(gpio + DA850_EVM_UI_EXP_SEL_A); > - > - return 0; > } > > /* assign the baseboard expander's GPIOs after the UI board's */ > @@ -699,13 +697,11 @@ static int da850_evm_bb_expander_setup(struct i2c_c= lient *client, > return ret; > } > > -static int da850_evm_bb_expander_teardown(struct i2c_client *client, > - unsigned gpio, unsigned ngpio, vo= id *c) > +static void da850_evm_bb_expander_teardown(struct i2c_client *client, > + unsigned gpio, unsigned ngpio,= void *c) > { > platform_device_unregister(&da850_evm_bb_leds_device); > platform_device_unregister(&da850_evm_bb_keys_device); > - > - return 0; > } > > static struct pca953x_platform_data da850_evm_ui_expander_info =3D { > diff --git a/drivers/gpio/gpio-pca953x.c b/drivers/gpio/gpio-pca953x.c > index 08bc52c3cdcb..3eedeac9ec8d 100644 > --- a/drivers/gpio/gpio-pca953x.c > +++ b/drivers/gpio/gpio-pca953x.c > @@ -1099,20 +1099,15 @@ static int pca953x_remove(struct i2c_client *clie= nt) > { > struct pca953x_platform_data *pdata =3D dev_get_platdata(&client-= >dev); > struct pca953x_chip *chip =3D i2c_get_clientdata(client); > - int ret; > > if (pdata && pdata->teardown) { > - ret =3D pdata->teardown(client, chip->gpio_chip.base, > - chip->gpio_chip.ngpio, pdata->conte= xt); > - if (ret < 0) > - dev_err(&client->dev, "teardown failed, %d\n", re= t); > - } else { > - ret =3D 0; > + pdata->teardown(client, chip->gpio_chip.base, > + chip->gpio_chip.ngpio, pdata->context); > } > > regulator_disable(chip->regulator); > > - return ret; > + return 0; > } > > #ifdef CONFIG_PM_SLEEP > diff --git a/include/linux/platform_data/pca953x.h b/include/linux/platfo= rm_data/pca953x.h > index 4eb53e023997..96c1a14ab365 100644 > --- a/include/linux/platform_data/pca953x.h > +++ b/include/linux/platform_data/pca953x.h > @@ -22,7 +22,7 @@ struct pca953x_platform_data { > int (*setup)(struct i2c_client *client, > unsigned gpio, unsigned ngpio, > void *context); > - int (*teardown)(struct i2c_client *client, > + void (*teardown)(struct i2c_client *client, > unsigned gpio, unsigned ngpio, > void *context); > const char *const *names; > -- > 2.36.1 > --=20 With Best Regards, Andy Shevchenko From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id CE6B1C43334 for ; Tue, 28 Jun 2022 19:10:53 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:Cc:To:Subject:Message-ID:Date:From: In-Reply-To:References:MIME-Version:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=irIwBKanZBFCROpl3H2TRdL+LKMoRvEyHdSE5mXJSP0=; b=k+n+27Gw9YeJR6 PXdhSBOY5+0ELC+GsspyjveN6gdwkxhdOZM77MSxlfEKuukh0IixDARVcgaVn5PSnChTLfDR8RHGp GyAGYnjeqOtwN/f//K6Ql7+UvLmHqZvN+wZka/hUXDtJImzqL+e4eS4aQQHolpGbt29rYma4oZKx/ OkUswLzeAkuOxvWJNvrhgolEMnNNTwGGXlw3eplV6RDCNMJuT5I49RFmNLroTB49wc0uM2STDH5fi psLHysRRbYc+DU3MPrXx8+xwiDdjHAAYFUAUfSgDMvQPBffQTPmKGmziTDVGxTWuzDGbFZXaCTyOS +IuzrozVG89w5+D0jAZg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1o6Gav-007lqg-8L; Tue, 28 Jun 2022 19:09:53 +0000 Received: from mail-yw1-x112c.google.com ([2607:f8b0:4864:20::112c]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1o6Gas-007lpJ-Hu for linux-arm-kernel@lists.infradead.org; Tue, 28 Jun 2022 19:09:52 +0000 Received: by mail-yw1-x112c.google.com with SMTP id 00721157ae682-31780ad7535so126991887b3.8 for ; Tue, 28 Jun 2022 12:09:49 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc:content-transfer-encoding; bh=Df+MKXJfNDPG+S9kvWPeYAx6XZpxE7WPz2ahAfIBELQ=; b=pm/CU9ccX46GwxUJNxGvRTMDaiONUskg50NFy9k6irBkgRKofkyc6ddePCEDw3hp/D YUNclZZG1b0PGUW5ktGHPaluX0gZX3ouDXNnNk17kL7G9DAJaSoKAE/u5aieZ99bpoat o9MZCnagpwdR6CJEt+GXTI0/iMSRU7hTqCYCVv0yIB2PkugqcBkmMzdxudzbuXuleZN6 zyrL31ToCzBXN99LUZqT79PzJOD0+mmhhryKp75gePf38PodiDcoDenGzGyEHCes/zRE unNmXiH32sp9QN/g8JaseaG9ef4D+J5vrxXfUthTp7fX8PJw7NwQKNJHjCe9sARr5gg5 tZWQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=Df+MKXJfNDPG+S9kvWPeYAx6XZpxE7WPz2ahAfIBELQ=; b=G0ikl8IdrSkWzDhAHTp0Fa7hrtBa08Ha5V5XJ9sfaQjlTnPJP0SBK8pWB29a0sibYU RiEQOPWGbv68aCAJbifxQrvT8AwWWxgXj7WazHcICce8ys79ai9sZbF08vQ5o4dHWnoz zgbFiTO502ghv2kt2c/gGUIlPOdJrvyXhmq8MolFw1kYkSTNJKH+nldBm97/wuV1DGeT Og/6OeU0Re7qGh0a7A/g6vvppCHnB64DA9Az2vebU4L2H3PfqUj757OcH3kejuGd74fW qLuVTkY10tbcj1FbVsCDzTh25imZWADM5TxvZ1grVz+tgj7SZwkdbYRYOTeGkWXZpBXV 5Z0Q== X-Gm-Message-State: AJIora8/IIAt14Hg4TzRdxHxqP4fSL3tDQfZNSj2SssbqHJ0GZRRxKhK sDGwhV2fg/LXRxVoNbm2G36JgXExlxowFKtVD9c= X-Google-Smtp-Source: AGRyM1vUp1dBPu4iDpJJOmQhrlwsWm72LE+ItI0NXjClMBY6C43R8UMBqnE261JrKVtOs4rDzv0NkQvPJIUx7WwNpR8= X-Received: by 2002:a81:5d88:0:b0:318:31c1:56f3 with SMTP id r130-20020a815d88000000b0031831c156f3mr23363889ywb.18.1656443388713; Tue, 28 Jun 2022 12:09:48 -0700 (PDT) MIME-Version: 1.0 References: <20220628140313.74984-1-u.kleine-koenig@pengutronix.de> <20220628140313.74984-6-u.kleine-koenig@pengutronix.de> In-Reply-To: <20220628140313.74984-6-u.kleine-koenig@pengutronix.de> From: Andy Shevchenko Date: Tue, 28 Jun 2022 21:09:09 +0200 Message-ID: Subject: Re: [PATCH 5/6] gpio: pca953x: Make platform teardown callback return void To: =?UTF-8?Q?Uwe_Kleine=2DK=C3=B6nig?= Cc: Sekhar Nori , Bartosz Golaszewski , Russell King , Linus Walleij , linux-arm Mailing List , "open list:GPIO SUBSYSTEM" , Sascha Hauer , linux-i2c X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220628_120950_631275_F0ABBB12 X-CRM114-Status: GOOD ( 24.75 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org T24gVHVlLCBKdW4gMjgsIDIwMjIgYXQgNDowNCBQTSBVd2UgS2xlaW5lLUvDtm5pZwo8dS5rbGVp bmUta29lbmlnQHBlbmd1dHJvbml4LmRlPiB3cm90ZToKPgo+IEFsbCBwbGF0Zm9ybXMgdGhhdCBw cm92aWRlIGEgdGVhcmRvd24gY2FsbGJhY2sgcmV0dXJuIDAuIE5ldyB1c2VycyBhcmUKPiBzdXBw b3NlZCB0byBub3QgbWFrZSB1c2Ugb2YgcGxhdGZvcm0gc3VwcG9ydCwgc28gdGhlcmUgaXMgbm8K PiBmdW5jdGlvbmFsaXR5IGxvc3QuCj4KPiBUaGlzIHBhdGNoIGlzIGEgcHJlcGFyYXRpb24gZm9y IG1ha2luZyBpMmMgcmVtb3ZlIGNhbGxiYWNrcyByZXR1cm4gdm9pZC4KPgo+IFNpZ25lZC1vZmYt Ynk6IFV3ZSBLbGVpbmUtS8O2bmlnIDx1LmtsZWluZS1rb2VuaWdAcGVuZ3V0cm9uaXguZGU+Cj4g Rm9yd2FyZGVkOiBpZDoyMDIyMDUwMjE3MDU1NS41MTE4My0xLXUua2xlaW5lLWtvZW5pZ0BwZW5n dXRyb25peC5kZQoKV2hhdCBpcyB0aGlzIHRhZyBmb3I/IEhhcyBpdCBiZWVuIGRvY3VtZW50ZWQ/ CgooTGludXMgcmVjZW50bHkgd2FzIHJhbnRpbmcgYWdhaW5zdCBob21lZ3Jvd24gY3VzdG9tIChy ZWFkOgpub24tZG9jdW1lbnRlZCkgdGFncykKCkZvciBub3cgdGhlIGNvZGUgbG9va3MgZ29vZCwK UmV2aWV3ZWQtYnk6IEFuZHkgU2hldmNoZW5rbyA8YW5keS5zaGV2Y2hlbmtvQGdtYWlsLmNvbT4K Ckhvd2V2ZXIsIEkgcHJlZmVyIHRvIHNlZSBkcm9wcGluZyB0aG9zZSBjYWxsYmFja3MgYWx0b2dl dGhlciAoZmluZCB0aGUKd2F5IGhvdyB0byB1c2UgR1BJTyBkZXNjcmlwdG9ycyAvIEdQSU8gdGFi bGUgLyBldGMgaW5zdGVhZCBvZiB1Z2x5CmN1c3RvbSBjYWxsYmFja3MpLgoKPiAtLS0KPiAgYXJj aC9hcm0vbWFjaC1kYXZpbmNpL2JvYXJkLWRhODUwLWV2bS5jIHwgMTIgKysrKy0tLS0tLS0tCj4g IGRyaXZlcnMvZ3Bpby9ncGlvLXBjYTk1M3guYyAgICAgICAgICAgICB8IDExICsrKy0tLS0tLS0t Cj4gIGluY2x1ZGUvbGludXgvcGxhdGZvcm1fZGF0YS9wY2E5NTN4LmggICB8ICAyICstCj4gIDMg ZmlsZXMgY2hhbmdlZCwgOCBpbnNlcnRpb25zKCspLCAxNyBkZWxldGlvbnMoLSkKPgo+IGRpZmYg LS1naXQgYS9hcmNoL2FybS9tYWNoLWRhdmluY2kvYm9hcmQtZGE4NTAtZXZtLmMgYi9hcmNoL2Fy bS9tYWNoLWRhdmluY2kvYm9hcmQtZGE4NTAtZXZtLmMKPiBpbmRleCBlZmMyNmI0NzJlZjguLjA5 MjUzZTcwZDBkYyAxMDA2NDQKPiAtLS0gYS9hcmNoL2FybS9tYWNoLWRhdmluY2kvYm9hcmQtZGE4 NTAtZXZtLmMKPiArKysgYi9hcmNoL2FybS9tYWNoLWRhdmluY2kvYm9hcmQtZGE4NTAtZXZtLmMK PiBAQCAtNTE4LDggKzUxOCw4IEBAIHN0YXRpYyBpbnQgZGE4NTBfZXZtX3VpX2V4cGFuZGVyX3Nl dHVwKHN0cnVjdCBpMmNfY2xpZW50ICpjbGllbnQsIHVuc2lnbmVkIGdwaW8sCj4gICAgICAgICBy ZXR1cm4gcmV0Owo+ICB9Cj4KPiAtc3RhdGljIGludCBkYTg1MF9ldm1fdWlfZXhwYW5kZXJfdGVh cmRvd24oc3RydWN0IGkyY19jbGllbnQgKmNsaWVudCwKPiAtICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgdW5zaWduZWQgZ3BpbywgdW5zaWduZWQgbmdwaW8sIHZvaWQgKmMp Cj4gK3N0YXRpYyB2b2lkIGRhODUwX2V2bV91aV9leHBhbmRlcl90ZWFyZG93bihzdHJ1Y3QgaTJj X2NsaWVudCAqY2xpZW50LAo+ICsgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICB1bnNpZ25lZCBncGlvLCB1bnNpZ25lZCBuZ3Bpbywgdm9pZCAqYykKPiAgewo+ICAgICAg ICAgcGxhdGZvcm1fZGV2aWNlX3VucmVnaXN0ZXIoJmRhODUwX2V2bV91aV9rZXlzX2RldmljZSk7 Cj4KPiBAQCAtNTMxLDggKzUzMSw2IEBAIHN0YXRpYyBpbnQgZGE4NTBfZXZtX3VpX2V4cGFuZGVy X3RlYXJkb3duKHN0cnVjdCBpMmNfY2xpZW50ICpjbGllbnQsCj4gICAgICAgICBncGlvX2ZyZWUo Z3BpbyArIERBODUwX0VWTV9VSV9FWFBfU0VMX0MpOwo+ICAgICAgICAgZ3Bpb19mcmVlKGdwaW8g KyBEQTg1MF9FVk1fVUlfRVhQX1NFTF9CKTsKPiAgICAgICAgIGdwaW9fZnJlZShncGlvICsgREE4 NTBfRVZNX1VJX0VYUF9TRUxfQSk7Cj4gLQo+IC0gICAgICAgcmV0dXJuIDA7Cj4gIH0KPgo+ICAv KiBhc3NpZ24gdGhlIGJhc2Vib2FyZCBleHBhbmRlcidzIEdQSU9zIGFmdGVyIHRoZSBVSSBib2Fy ZCdzICovCj4gQEAgLTY5OSwxMyArNjk3LDExIEBAIHN0YXRpYyBpbnQgZGE4NTBfZXZtX2JiX2V4 cGFuZGVyX3NldHVwKHN0cnVjdCBpMmNfY2xpZW50ICpjbGllbnQsCj4gICAgICAgICByZXR1cm4g cmV0Owo+ICB9Cj4KPiAtc3RhdGljIGludCBkYTg1MF9ldm1fYmJfZXhwYW5kZXJfdGVhcmRvd24o c3RydWN0IGkyY19jbGllbnQgKmNsaWVudCwKPiAtICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgdW5zaWduZWQgZ3BpbywgdW5zaWduZWQgbmdwaW8sIHZvaWQgKmMpCj4gK3N0 YXRpYyB2b2lkIGRhODUwX2V2bV9iYl9leHBhbmRlcl90ZWFyZG93bihzdHJ1Y3QgaTJjX2NsaWVu dCAqY2xpZW50LAo+ICsgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICB1 bnNpZ25lZCBncGlvLCB1bnNpZ25lZCBuZ3Bpbywgdm9pZCAqYykKPiAgewo+ICAgICAgICAgcGxh dGZvcm1fZGV2aWNlX3VucmVnaXN0ZXIoJmRhODUwX2V2bV9iYl9sZWRzX2RldmljZSk7Cj4gICAg ICAgICBwbGF0Zm9ybV9kZXZpY2VfdW5yZWdpc3RlcigmZGE4NTBfZXZtX2JiX2tleXNfZGV2aWNl KTsKPiAtCj4gLSAgICAgICByZXR1cm4gMDsKPiAgfQo+Cj4gIHN0YXRpYyBzdHJ1Y3QgcGNhOTUz eF9wbGF0Zm9ybV9kYXRhIGRhODUwX2V2bV91aV9leHBhbmRlcl9pbmZvID0gewo+IGRpZmYgLS1n aXQgYS9kcml2ZXJzL2dwaW8vZ3Bpby1wY2E5NTN4LmMgYi9kcml2ZXJzL2dwaW8vZ3Bpby1wY2E5 NTN4LmMKPiBpbmRleCAwOGJjNTJjM2NkY2IuLjNlZWRlYWM5ZWM4ZCAxMDA2NDQKPiAtLS0gYS9k cml2ZXJzL2dwaW8vZ3Bpby1wY2E5NTN4LmMKPiArKysgYi9kcml2ZXJzL2dwaW8vZ3Bpby1wY2E5 NTN4LmMKPiBAQCAtMTA5OSwyMCArMTA5OSwxNSBAQCBzdGF0aWMgaW50IHBjYTk1M3hfcmVtb3Zl KHN0cnVjdCBpMmNfY2xpZW50ICpjbGllbnQpCj4gIHsKPiAgICAgICAgIHN0cnVjdCBwY2E5NTN4 X3BsYXRmb3JtX2RhdGEgKnBkYXRhID0gZGV2X2dldF9wbGF0ZGF0YSgmY2xpZW50LT5kZXYpOwo+ ICAgICAgICAgc3RydWN0IHBjYTk1M3hfY2hpcCAqY2hpcCA9IGkyY19nZXRfY2xpZW50ZGF0YShj bGllbnQpOwo+IC0gICAgICAgaW50IHJldDsKPgo+ICAgICAgICAgaWYgKHBkYXRhICYmIHBkYXRh LT50ZWFyZG93bikgewo+IC0gICAgICAgICAgICAgICByZXQgPSBwZGF0YS0+dGVhcmRvd24oY2xp ZW50LCBjaGlwLT5ncGlvX2NoaXAuYmFzZSwKPiAtICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgIGNoaXAtPmdwaW9fY2hpcC5uZ3BpbywgcGRhdGEtPmNvbnRleHQpOwo+IC0gICAg ICAgICAgICAgICBpZiAocmV0IDwgMCkKPiAtICAgICAgICAgICAgICAgICAgICAgICBkZXZfZXJy KCZjbGllbnQtPmRldiwgInRlYXJkb3duIGZhaWxlZCwgJWRcbiIsIHJldCk7Cj4gLSAgICAgICB9 IGVsc2Ugewo+IC0gICAgICAgICAgICAgICByZXQgPSAwOwo+ICsgICAgICAgICAgICAgICBwZGF0 YS0+dGVhcmRvd24oY2xpZW50LCBjaGlwLT5ncGlvX2NoaXAuYmFzZSwKPiArICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgIGNoaXAtPmdwaW9fY2hpcC5uZ3BpbywgcGRhdGEtPmNvbnRleHQp Owo+ICAgICAgICAgfQo+Cj4gICAgICAgICByZWd1bGF0b3JfZGlzYWJsZShjaGlwLT5yZWd1bGF0 b3IpOwo+Cj4gLSAgICAgICByZXR1cm4gcmV0Owo+ICsgICAgICAgcmV0dXJuIDA7Cj4gIH0KPgo+ ICAjaWZkZWYgQ09ORklHX1BNX1NMRUVQCj4gZGlmZiAtLWdpdCBhL2luY2x1ZGUvbGludXgvcGxh dGZvcm1fZGF0YS9wY2E5NTN4LmggYi9pbmNsdWRlL2xpbnV4L3BsYXRmb3JtX2RhdGEvcGNhOTUz eC5oCj4gaW5kZXggNGViNTNlMDIzOTk3Li45NmMxYTE0YWIzNjUgMTAwNjQ0Cj4gLS0tIGEvaW5j bHVkZS9saW51eC9wbGF0Zm9ybV9kYXRhL3BjYTk1M3guaAo+ICsrKyBiL2luY2x1ZGUvbGludXgv cGxhdGZvcm1fZGF0YS9wY2E5NTN4LmgKPiBAQCAtMjIsNyArMjIsNyBAQCBzdHJ1Y3QgcGNhOTUz eF9wbGF0Zm9ybV9kYXRhIHsKPiAgICAgICAgIGludCAgICAgICAgICAgICAoKnNldHVwKShzdHJ1 Y3QgaTJjX2NsaWVudCAqY2xpZW50LAo+ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg dW5zaWduZWQgZ3BpbywgdW5zaWduZWQgbmdwaW8sCj4gICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICB2b2lkICpjb250ZXh0KTsKPiAtICAgICAgIGludCAgICAgICAgICAgICAoKnRlYXJk b3duKShzdHJ1Y3QgaTJjX2NsaWVudCAqY2xpZW50LAo+ICsgICAgICAgdm9pZCAgICAgICAgICAg ICgqdGVhcmRvd24pKHN0cnVjdCBpMmNfY2xpZW50ICpjbGllbnQsCj4gICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICB1bnNpZ25lZCBncGlvLCB1bnNpZ25lZCBuZ3BpbywKPiAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgIHZvaWQgKmNvbnRleHQpOwo+ICAgICAgICAgY29uc3Qg Y2hhciAgICAgICpjb25zdCAqbmFtZXM7Cj4gLS0KPiAyLjM2LjEKPgoKCi0tIApXaXRoIEJlc3Qg UmVnYXJkcywKQW5keSBTaGV2Y2hlbmtvCgpfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fXwpsaW51eC1hcm0ta2VybmVsIG1haWxpbmcgbGlzdApsaW51eC1hcm0t a2VybmVsQGxpc3RzLmluZnJhZGVhZC5vcmcKaHR0cDovL2xpc3RzLmluZnJhZGVhZC5vcmcvbWFp bG1hbi9saXN0aW5mby9saW51eC1hcm0ta2VybmVsCg==