From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932250AbbKMBbH (ORCPT ); Thu, 12 Nov 2015 20:31:07 -0500 Received: from mail-yk0-f180.google.com ([209.85.160.180]:36306 "EHLO mail-yk0-f180.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754270AbbKMBbF (ORCPT ); Thu, 12 Nov 2015 20:31:05 -0500 MIME-Version: 1.0 In-Reply-To: <1447334483-126186-1-git-send-email-heikki.krogerus@linux.intel.com> References: <1447334483-126186-1-git-send-email-heikki.krogerus@linux.intel.com> Date: Fri, 13 Nov 2015 03:31:04 +0200 Message-ID: Subject: Re: [PATCH] serial: 8250_mid: Add missing dependency From: Andy Shevchenko To: Heikki Krogerus Cc: Greg Kroah-Hartman , Randy Dunlap , Stephen Rothwell , "linux-serial@vger.kernel.org" , "linux-kernel@vger.kernel.org" Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Nov 12, 2015 at 3:21 PM, Heikki Krogerus wrote: > 8250_mid uses rational_best_approximation() function, so the > driver needs to select CONFIG_RATIONAL option. > > This fixes build error when CONFIG_RATIONAL is not enabled: > > drivers/built-in.o: In function `mid8250_set_termios': > 8250_mid.c:(.text+0x10169a): undefined reference to `rational_best_approximation' > Oh, man, I have the same fix in my local tree for weeks ;-) Acked-by: Andy Shevchenko > Reported-by: Randy Dunlap > Signed-off-by: Heikki Krogerus > --- > drivers/tty/serial/8250/Kconfig | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/tty/serial/8250/Kconfig b/drivers/tty/serial/8250/Kconfig > index e6f5e12..6412f14 100644 > --- a/drivers/tty/serial/8250/Kconfig > +++ b/drivers/tty/serial/8250/Kconfig > @@ -373,6 +373,7 @@ config SERIAL_8250_MID > depends on SERIAL_8250 && PCI > select HSU_DMA if SERIAL_8250_DMA > select HSU_DMA_PCI if X86_INTEL_MID > + select RATIONAL > help > Selecting this option will enable handling of the extra features > present on the UART found on Intel Medfield SOC and various other > -- > 2.6.2 > > -- > To unsubscribe from this list: send the line "unsubscribe linux-kernel" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html > Please read the FAQ at http://www.tux.org/lkml/ -- With Best Regards, Andy Shevchenko