All of lore.kernel.org
 help / color / mirror / Atom feed
From: Andy Shevchenko <andy.shevchenko@gmail.com>
To: Al Viro <viro@zeniv.linux.org.uk>
Cc: Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
	"J. Bruce Fields" <bfields@redhat.com>,
	Kefeng Wang <wangkefeng.wang@huawei.com>,
	Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
	linux-nfs@vger.kernel.org,
	Linux FS Devel <linux-fsdevel@vger.kernel.org>,
	"J. Bruce Fields" <bfields@fieldses.org>,
	Chuck Lever <chuck.lever@oracle.com>,
	Andy Shevchenko <andy@kernel.org>,
	Andrew Morton <akpm@linux-foundation.org>
Subject: Re: [PATCH v1 10/12] nfsd: Avoid non-flexible API in seq_quote_mem()
Date: Tue, 4 May 2021 00:11:20 +0300	[thread overview]
Message-ID: <CAHp75Vet8CN3Cx2Loi_7PiXyf_XX1FWF3uPB-jUS51UC5B8U_w@mail.gmail.com> (raw)
In-Reply-To: <YJBmkNky4QfFhPD1@zeniv-ca.linux.org.uk>

On Tue, May 4, 2021 at 12:09 AM Al Viro <viro@zeniv.linux.org.uk> wrote:
> On Mon, May 03, 2021 at 11:56:41PM +0300, Andy Shevchenko wrote:
> > On Mon, May 3, 2021 at 11:54 PM Al Viro <viro@zeniv.linux.org.uk> wrote:
> > >
> > > On Mon, May 03, 2021 at 11:49:05PM +0300, Andy Shevchenko wrote:
> > > > string_escape_mem_ascii() followed by seq_escape_mem_ascii() is completely
> > > > non-flexible and shouldn't be exist from day 1.
> > > >
> > > > Replace it with properly called string_escape_mem().
> > >
> > > NAKed-by: Al Viro <viro@zeniv.linux.org.uk>
> > >
> > > Reason: use of seq_get_buf().  Which should have been static inline in
> > > fs/seq_file.c, to start with.
> >
> > I see.
> >
> > > Again, any new uses of seq_get_buf()/seq_commit() are grounds for automatic
> > > NAK.  These interfaces *will* be withdrawn.
> >
> > You meant that this is no way to get rid of this guy?
> > Any suggestions how to replace that API with a newer one?
>
> seq_escape_mem(), perhaps?

I think I have a better idea. What about adding seq_escape_with_flags()
and seq_escape() --> seq_escape_with_flags(..., ESCAPE_OCTAL, ...) ?

Would it work for you?

-- 
With Best Regards,
Andy Shevchenko

  reply	other threads:[~2021-05-03 21:11 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-05-03 20:48 [PATCH v1 00/12] lib/string_helpers: get rid of ugly *_escape_mem_ascii() API Andy Shevchenko
2021-05-03 20:48 ` [PATCH v1 01/12] lib/string_helpers: Switch to use BIT() macro Andy Shevchenko
2021-05-03 20:48 ` [PATCH v1 02/12] lib/string_helpers: Move ESCAPE_NP check inside 'else' branch in a loop Andy Shevchenko
2021-05-03 20:48 ` [PATCH v1 03/12] lib/string_helpers: Introduce ESCAPE_NA for escaping non-ASCII Andy Shevchenko
2021-05-03 20:48 ` [PATCH v1 04/12] lib/string_helpers: Introduce ESCAPE_NAP to escape non-ASCII and non-printable Andy Shevchenko
2021-05-03 20:49 ` [PATCH v1 05/12] lib/string_helpers: Drop indentation level in string_escape_mem() Andy Shevchenko
2021-05-03 20:49 ` [PATCH v1 06/12] lib/string_helpers: Allow to append additional characters to be escaped Andy Shevchenko
2021-05-03 20:49 ` [PATCH v1 07/12] lib/test-string_helpers: Print flags in hexadecimal format Andy Shevchenko
2021-05-03 20:49 ` [PATCH v1 08/12] lib/test-string_helpers: Get rid of trailing comma in terminators Andy Shevchenko
2021-05-03 20:49 ` [PATCH v1 09/12] lib/test-string_helpers: Add test cases for new features Andy Shevchenko
2021-05-03 20:49 ` [PATCH v1 10/12] nfsd: Avoid non-flexible API in seq_quote_mem() Andy Shevchenko
2021-05-03 20:53   ` Al Viro
2021-05-03 20:56     ` Andy Shevchenko
2021-05-03 21:09       ` Al Viro
2021-05-03 21:11         ` Andy Shevchenko [this message]
2021-05-03 21:14           ` Andy Shevchenko
2021-05-03 20:49 ` [PATCH v1 11/12] lib/string_helpers: Drop unused *_escape_mem_ascii() Andy Shevchenko
2021-05-03 20:49 ` [PATCH v1 12/12] MAINTAINERS: Add myself as designated reviewer for generic string library Andy Shevchenko

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAHp75Vet8CN3Cx2Loi_7PiXyf_XX1FWF3uPB-jUS51UC5B8U_w@mail.gmail.com \
    --to=andy.shevchenko@gmail.com \
    --cc=akpm@linux-foundation.org \
    --cc=andriy.shevchenko@linux.intel.com \
    --cc=andy@kernel.org \
    --cc=bfields@fieldses.org \
    --cc=bfields@redhat.com \
    --cc=chuck.lever@oracle.com \
    --cc=linux-fsdevel@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-nfs@vger.kernel.org \
    --cc=viro@zeniv.linux.org.uk \
    --cc=wangkefeng.wang@huawei.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.