From: Andy Shevchenko <andy.shevchenko@gmail.com>
To: "Jonas Dreßler" <verdre@v0yd.nl>
Cc: "Amitkumar Karwar" <amitkarwar@gmail.com>,
"Ganapathi Bhat" <ganapathi017@gmail.com>,
"Xinming Hu" <huxinming820@gmail.com>,
"Kalle Valo" <kvalo@codeaurora.org>,
"David S. Miller" <davem@davemloft.net>,
"Jakub Kicinski" <kuba@kernel.org>,
"Tsuchiya Yuto" <kitakar@gmail.com>,
"open list:TI WILINK WIRELES..." <linux-wireless@vger.kernel.org>,
netdev <netdev@vger.kernel.org>,
"Linux Kernel Mailing List" <linux-kernel@vger.kernel.org>,
linux-pci <linux-pci@vger.kernel.org>,
"Maximilian Luz" <luzmaximilian@gmail.com>,
"Andy Shevchenko" <andriy.shevchenko@linux.intel.com>,
"Bjorn Helgaas" <bhelgaas@google.com>,
"Pali Rohár" <pali@kernel.org>
Subject: Re: [PATCH 2/2] mwifiex: Try waking the firmware until we get an interrupt
Date: Mon, 30 Aug 2021 15:55:40 +0300 [thread overview]
Message-ID: <CAHp75VetWJ1e-JCdoi4dSfKEvYbdFS8w9bzmYjL=GZJndNYaug@mail.gmail.com> (raw)
In-Reply-To: <CAHp75Vf-ekdTh=86nR7wqufFPmEb5bve0hf1Oq_k_OAJCkNvWg@mail.gmail.com>
On Mon, Aug 30, 2021 at 3:51 PM Andy Shevchenko
<andy.shevchenko@gmail.com> wrote:
> On Mon, Aug 30, 2021 at 3:39 PM Jonas Dreßler <verdre@v0yd.nl> wrote:
...
> > + do {
> > + if (mwifiex_write_reg(adapter, reg->fw_status, FIRMWARE_READY_PCIE)) {
> > + mwifiex_dbg(adapter, ERROR,
> > + "Writing fw_status register failed\n");
> > + return -1;
Please, use proper code. -EIO or so.
> > + }
> > +
> > + n_tries++;
> > +
> > + if (n_tries <= 15)
> > + usleep_range(400, 700);
> > + else
> > + msleep(10);
> > + } while (n_tries <= 50 && READ_ONCE(adapter->int_status) == 0);
Can you use definitions for 15 and 50?
> NIH read_poll_timeout() from iopoll.h.
On the second thought it might be not optimal to use it (requires
anyway an additional function and doesn't provide an abortion on
error). Just see above.
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2021-08-30 12:56 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-08-30 12:37 [PATCH 0/2] mwifiex: Work around firmware bugs on 88W8897 chip Jonas Dreßler
2021-08-30 12:37 ` [PATCH 1/2] mwifiex: Use non-posted PCI register writes Jonas Dreßler
2021-08-30 12:49 ` Andy Shevchenko
2021-09-01 14:01 ` Jonas Dreßler
2021-09-01 15:47 ` Andy Shevchenko
2021-09-01 15:51 ` Pali Rohár
2021-09-01 16:51 ` Heiner Kallweit
2021-09-01 17:07 ` Johannes Berg
2021-09-01 19:07 ` Heiner Kallweit
2021-09-01 22:41 ` Bjorn Helgaas
2021-09-02 14:05 ` Bjorn Helgaas
2021-09-01 19:40 ` Brian Norris
2021-09-01 20:40 ` Andy Shevchenko
2021-09-01 21:04 ` Brian Norris
2021-09-01 21:07 ` Brian Norris
2021-09-18 7:37 ` Jonas Dreßler
2021-09-20 17:48 ` Brian Norris
2021-09-22 12:50 ` Jonas Dreßler
2021-09-23 15:28 ` Jonas Dreßler
2021-09-23 19:37 ` Andy Shevchenko
2021-09-23 19:41 ` Andy Shevchenko
2021-09-23 20:22 ` Pali Rohár
2021-09-30 15:38 ` Jonas Dreßler
2021-09-30 15:42 ` Pali Rohár
2021-09-30 16:14 ` Jonas Dreßler
2021-09-30 16:19 ` Pali Rohár
2021-09-30 16:22 ` Jonas Dreßler
2021-09-30 16:39 ` Pali Rohár
2021-08-30 12:37 ` [PATCH 2/2] mwifiex: Try waking the firmware until we get an interrupt Jonas Dreßler
2021-08-30 12:51 ` Andy Shevchenko
2021-08-30 12:55 ` Andy Shevchenko [this message]
2021-09-25 17:32 ` [PATCH 0/2] mwifiex: Work around firmware bugs on 88W8897 chip Pali Rohár
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAHp75VetWJ1e-JCdoi4dSfKEvYbdFS8w9bzmYjL=GZJndNYaug@mail.gmail.com' \
--to=andy.shevchenko@gmail.com \
--cc=amitkarwar@gmail.com \
--cc=andriy.shevchenko@linux.intel.com \
--cc=bhelgaas@google.com \
--cc=davem@davemloft.net \
--cc=ganapathi017@gmail.com \
--cc=huxinming820@gmail.com \
--cc=kitakar@gmail.com \
--cc=kuba@kernel.org \
--cc=kvalo@codeaurora.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=luzmaximilian@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=pali@kernel.org \
--cc=verdre@v0yd.nl \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.